diff options
author | Peter Oberparleiter <peter.oberparleiter@de.ibm.com> | 2011-10-30 10:16:04 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2011-10-30 10:16:15 -0400 |
commit | de400d6b78d15a73023485f050bc6b1709dc7a79 (patch) | |
tree | 2d2e7233a76982db4cf12ff0859054a33e46a911 /drivers/s390/char | |
parent | ce949717b559709423c1ef716a9db16d1dcadaed (diff) |
[S390] fix mismatch in summation of I/O IRQ statistics
Current IRQ statistics support does not show detail counts for I/O
interrupts which are processed internally only. The result is a
summation count which is way off such as this one:
CPU0 CPU1 CPU2
I/O: 1331 710 442
[...]
QAI: 15 16 16 [I/O] QDIO Adapter Interrupt
QDI: 1 0 0 [I/O] QDIO Interrupt
DAS: 706 645 381 [I/O] DASD
C15: 26 10 0 [I/O] 3215
C70: 0 0 0 [I/O] 3270
TAP: 0 0 0 [I/O] Tape
VMR: 0 0 0 [I/O] Unit Record Devices
LCS: 0 0 0 [I/O] LCS
CLW: 0 0 0 [I/O] CLAW
CTC: 0 0 0 [I/O] CTC
APB: 0 0 0 [I/O] AP Bus
Fix this by moving I/O interrupt accounting into the common I/O layer.
Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/char')
-rw-r--r-- | drivers/s390/char/con3215.c | 3 | ||||
-rw-r--r-- | drivers/s390/char/raw3270.c | 3 | ||||
-rw-r--r-- | drivers/s390/char/tape_34xx.c | 1 | ||||
-rw-r--r-- | drivers/s390/char/tape_3590.c | 1 | ||||
-rw-r--r-- | drivers/s390/char/tape_core.c | 2 | ||||
-rw-r--r-- | drivers/s390/char/vmur.c | 3 |
6 files changed, 5 insertions, 8 deletions
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c index 694464c65fcd..934458ad55e5 100644 --- a/drivers/s390/char/con3215.c +++ b/drivers/s390/char/con3215.c | |||
@@ -9,7 +9,6 @@ | |||
9 | * Dan Morrison, IBM Corporation <dmorriso@cse.buffalo.edu> | 9 | * Dan Morrison, IBM Corporation <dmorriso@cse.buffalo.edu> |
10 | */ | 10 | */ |
11 | 11 | ||
12 | #include <linux/kernel_stat.h> | ||
13 | #include <linux/module.h> | 12 | #include <linux/module.h> |
14 | #include <linux/types.h> | 13 | #include <linux/types.h> |
15 | #include <linux/kdev_t.h> | 14 | #include <linux/kdev_t.h> |
@@ -362,7 +361,6 @@ static void raw3215_irq(struct ccw_device *cdev, unsigned long intparm, | |||
362 | int cstat, dstat; | 361 | int cstat, dstat; |
363 | int count; | 362 | int count; |
364 | 363 | ||
365 | kstat_cpu(smp_processor_id()).irqs[IOINT_C15]++; | ||
366 | raw = dev_get_drvdata(&cdev->dev); | 364 | raw = dev_get_drvdata(&cdev->dev); |
367 | req = (struct raw3215_req *) intparm; | 365 | req = (struct raw3215_req *) intparm; |
368 | cstat = irb->scsw.cmd.cstat; | 366 | cstat = irb->scsw.cmd.cstat; |
@@ -776,6 +774,7 @@ static struct ccw_driver raw3215_ccw_driver = { | |||
776 | .freeze = &raw3215_pm_stop, | 774 | .freeze = &raw3215_pm_stop, |
777 | .thaw = &raw3215_pm_start, | 775 | .thaw = &raw3215_pm_start, |
778 | .restore = &raw3215_pm_start, | 776 | .restore = &raw3215_pm_start, |
777 | .int_class = IOINT_C15, | ||
779 | }; | 778 | }; |
780 | 779 | ||
781 | #ifdef CONFIG_TN3215_CONSOLE | 780 | #ifdef CONFIG_TN3215_CONSOLE |
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c index 810ac38631c3..e5cb9248a442 100644 --- a/drivers/s390/char/raw3270.c +++ b/drivers/s390/char/raw3270.c | |||
@@ -7,7 +7,6 @@ | |||
7 | * Copyright IBM Corp. 2003, 2009 | 7 | * Copyright IBM Corp. 2003, 2009 |
8 | */ | 8 | */ |
9 | 9 | ||
10 | #include <linux/kernel_stat.h> | ||
11 | #include <linux/module.h> | 10 | #include <linux/module.h> |
12 | #include <linux/err.h> | 11 | #include <linux/err.h> |
13 | #include <linux/init.h> | 12 | #include <linux/init.h> |
@@ -330,7 +329,6 @@ raw3270_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb) | |||
330 | struct raw3270_request *rq; | 329 | struct raw3270_request *rq; |
331 | int rc; | 330 | int rc; |
332 | 331 | ||
333 | kstat_cpu(smp_processor_id()).irqs[IOINT_C70]++; | ||
334 | rp = dev_get_drvdata(&cdev->dev); | 332 | rp = dev_get_drvdata(&cdev->dev); |
335 | if (!rp) | 333 | if (!rp) |
336 | return; | 334 | return; |
@@ -1398,6 +1396,7 @@ static struct ccw_driver raw3270_ccw_driver = { | |||
1398 | .freeze = &raw3270_pm_stop, | 1396 | .freeze = &raw3270_pm_stop, |
1399 | .thaw = &raw3270_pm_start, | 1397 | .thaw = &raw3270_pm_start, |
1400 | .restore = &raw3270_pm_start, | 1398 | .restore = &raw3270_pm_start, |
1399 | .int_class = IOINT_C70, | ||
1401 | }; | 1400 | }; |
1402 | 1401 | ||
1403 | static int | 1402 | static int |
diff --git a/drivers/s390/char/tape_34xx.c b/drivers/s390/char/tape_34xx.c index 9eff2df70ddb..934ef33eb9a4 100644 --- a/drivers/s390/char/tape_34xx.c +++ b/drivers/s390/char/tape_34xx.c | |||
@@ -1330,6 +1330,7 @@ static struct ccw_driver tape_34xx_driver = { | |||
1330 | .set_online = tape_34xx_online, | 1330 | .set_online = tape_34xx_online, |
1331 | .set_offline = tape_generic_offline, | 1331 | .set_offline = tape_generic_offline, |
1332 | .freeze = tape_generic_pm_suspend, | 1332 | .freeze = tape_generic_pm_suspend, |
1333 | .int_class = IOINT_TAP, | ||
1333 | }; | 1334 | }; |
1334 | 1335 | ||
1335 | static int | 1336 | static int |
diff --git a/drivers/s390/char/tape_3590.c b/drivers/s390/char/tape_3590.c index a7d570728882..49c6aab7ad78 100644 --- a/drivers/s390/char/tape_3590.c +++ b/drivers/s390/char/tape_3590.c | |||
@@ -1762,6 +1762,7 @@ static struct ccw_driver tape_3590_driver = { | |||
1762 | .set_offline = tape_generic_offline, | 1762 | .set_offline = tape_generic_offline, |
1763 | .set_online = tape_3590_online, | 1763 | .set_online = tape_3590_online, |
1764 | .freeze = tape_generic_pm_suspend, | 1764 | .freeze = tape_generic_pm_suspend, |
1765 | .int_class = IOINT_TAP, | ||
1765 | }; | 1766 | }; |
1766 | 1767 | ||
1767 | /* | 1768 | /* |
diff --git a/drivers/s390/char/tape_core.c b/drivers/s390/char/tape_core.c index 7978a0adeaf3..b3a3e8e8656e 100644 --- a/drivers/s390/char/tape_core.c +++ b/drivers/s390/char/tape_core.c | |||
@@ -14,7 +14,6 @@ | |||
14 | #define KMSG_COMPONENT "tape" | 14 | #define KMSG_COMPONENT "tape" |
15 | #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt | 15 | #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt |
16 | 16 | ||
17 | #include <linux/kernel_stat.h> | ||
18 | #include <linux/module.h> | 17 | #include <linux/module.h> |
19 | #include <linux/init.h> // for kernel parameters | 18 | #include <linux/init.h> // for kernel parameters |
20 | #include <linux/kmod.h> // for requesting modules | 19 | #include <linux/kmod.h> // for requesting modules |
@@ -1115,7 +1114,6 @@ __tape_do_irq (struct ccw_device *cdev, unsigned long intparm, struct irb *irb) | |||
1115 | struct tape_request *request; | 1114 | struct tape_request *request; |
1116 | int rc; | 1115 | int rc; |
1117 | 1116 | ||
1118 | kstat_cpu(smp_processor_id()).irqs[IOINT_TAP]++; | ||
1119 | device = dev_get_drvdata(&cdev->dev); | 1117 | device = dev_get_drvdata(&cdev->dev); |
1120 | if (device == NULL) { | 1118 | if (device == NULL) { |
1121 | return; | 1119 | return; |
diff --git a/drivers/s390/char/vmur.c b/drivers/s390/char/vmur.c index f6b00c3df425..d291a54acfad 100644 --- a/drivers/s390/char/vmur.c +++ b/drivers/s390/char/vmur.c | |||
@@ -11,7 +11,6 @@ | |||
11 | #define KMSG_COMPONENT "vmur" | 11 | #define KMSG_COMPONENT "vmur" |
12 | #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt | 12 | #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt |
13 | 13 | ||
14 | #include <linux/kernel_stat.h> | ||
15 | #include <linux/cdev.h> | 14 | #include <linux/cdev.h> |
16 | #include <linux/slab.h> | 15 | #include <linux/slab.h> |
17 | 16 | ||
@@ -74,6 +73,7 @@ static struct ccw_driver ur_driver = { | |||
74 | .set_online = ur_set_online, | 73 | .set_online = ur_set_online, |
75 | .set_offline = ur_set_offline, | 74 | .set_offline = ur_set_offline, |
76 | .freeze = ur_pm_suspend, | 75 | .freeze = ur_pm_suspend, |
76 | .int_class = IOINT_VMR, | ||
77 | }; | 77 | }; |
78 | 78 | ||
79 | static DEFINE_MUTEX(vmur_mutex); | 79 | static DEFINE_MUTEX(vmur_mutex); |
@@ -305,7 +305,6 @@ static void ur_int_handler(struct ccw_device *cdev, unsigned long intparm, | |||
305 | { | 305 | { |
306 | struct urdev *urd; | 306 | struct urdev *urd; |
307 | 307 | ||
308 | kstat_cpu(smp_processor_id()).irqs[IOINT_VMR]++; | ||
309 | TRACE("ur_int_handler: intparm=0x%lx cstat=%02x dstat=%02x res=%u\n", | 308 | TRACE("ur_int_handler: intparm=0x%lx cstat=%02x dstat=%02x res=%u\n", |
310 | intparm, irb->scsw.cmd.cstat, irb->scsw.cmd.dstat, | 309 | intparm, irb->scsw.cmd.cstat, irb->scsw.cmd.dstat, |
311 | irb->scsw.cmd.count); | 310 | irb->scsw.cmd.count); |