diff options
author | Christian Borntraeger <borntraeger@de.ibm.com> | 2007-07-17 07:36:05 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2007-07-17 07:36:19 -0400 |
commit | d9d119f12fdb14d57e96e4698ef2ec303b102ae9 (patch) | |
tree | 80bed550e0bd4c36fed15a0ecbfc52f6534fda43 /drivers/s390/char/vmcp.h | |
parent | 6cbed91ab78e750eef2dacb75bd51bd63792fd07 (diff) |
[S390] vmcp cleanup
A number of small changes to vmcp:
- Change preferred email address.
- Use PRINT_xxx machros from debug.h like most s390 drivers, define
"vmcp:" as PRINTK_HEADER and wrap error message at column 80.
- Add error number to error message.
- Update copyright, as I touched this file.
- Small whitespace diff.
- Use mutex instead of semaphore (Thanks Heiko for the patch)
- Don't register debug feature on failure.
- Check debug feature registration on init to avoid a potential oops
on unload if the debug feature could not be registered--> 2 more
messages.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/char/vmcp.h')
-rw-r--r-- | drivers/s390/char/vmcp.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/char/vmcp.h b/drivers/s390/char/vmcp.h index 8a5975f3dad7..6a993948e188 100644 --- a/drivers/s390/char/vmcp.h +++ b/drivers/s390/char/vmcp.h | |||
@@ -12,8 +12,8 @@ | |||
12 | * The idea of this driver is based on cpint from Neale Ferguson | 12 | * The idea of this driver is based on cpint from Neale Ferguson |
13 | */ | 13 | */ |
14 | 14 | ||
15 | #include <asm/semaphore.h> | ||
16 | #include <linux/ioctl.h> | 15 | #include <linux/ioctl.h> |
16 | #include <linux/mutex.h> | ||
17 | 17 | ||
18 | #define VMCP_GETCODE _IOR(0x10, 1, int) | 18 | #define VMCP_GETCODE _IOR(0x10, 1, int) |
19 | #define VMCP_SETBUF _IOW(0x10, 2, int) | 19 | #define VMCP_SETBUF _IOW(0x10, 2, int) |
@@ -26,5 +26,5 @@ struct vmcp_session { | |||
26 | int resp_code; | 26 | int resp_code; |
27 | /* As we use copy_from/to_user, which might * | 27 | /* As we use copy_from/to_user, which might * |
28 | * sleep and cannot use a spinlock */ | 28 | * sleep and cannot use a spinlock */ |
29 | struct semaphore mutex; | 29 | struct mutex mutex; |
30 | }; | 30 | }; |