diff options
author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2008-04-30 03:54:00 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-30 11:29:45 -0400 |
commit | 9e7c9a19c1df8a7450c56c41b9c7405eca7eda07 (patch) | |
tree | 8fd3e57dad8f05c7e43969d391bfd33a31738f27 /drivers/s390/char/sclp_vt220.c | |
parent | 978e595f88a1fba5869aa42a4af4fba36f33ecac (diff) |
s390 tty: Prepare for put_char to return success/fail
Put the changes into the drivers first. This will still compile/work but
produce a warning if bisected so can still be debugged
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/s390/char/sclp_vt220.c')
-rw-r--r-- | drivers/s390/char/sclp_vt220.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c index ed507594e62b..35707c04e613 100644 --- a/drivers/s390/char/sclp_vt220.c +++ b/drivers/s390/char/sclp_vt220.c | |||
@@ -524,11 +524,15 @@ sclp_vt220_close(struct tty_struct *tty, struct file *filp) | |||
524 | * NOTE: include/linux/tty_driver.h specifies that a character should be | 524 | * NOTE: include/linux/tty_driver.h specifies that a character should be |
525 | * ignored if there is no room in the queue. This driver implements a different | 525 | * ignored if there is no room in the queue. This driver implements a different |
526 | * semantic in that it will block when there is no more room left. | 526 | * semantic in that it will block when there is no more room left. |
527 | * | ||
528 | * FIXME: putchar can currently be called from BH and other non blocking | ||
529 | * handlers so this semantic isn't a good idea. | ||
527 | */ | 530 | */ |
528 | static void | 531 | static int |
529 | sclp_vt220_put_char(struct tty_struct *tty, unsigned char ch) | 532 | sclp_vt220_put_char(struct tty_struct *tty, unsigned char ch) |
530 | { | 533 | { |
531 | __sclp_vt220_write(&ch, 1, 0, 0, 1); | 534 | __sclp_vt220_write(&ch, 1, 0, 0, 1); |
535 | return 1; | ||
532 | } | 536 | } |
533 | 537 | ||
534 | /* | 538 | /* |