diff options
author | Christoph Hellwig <hch@lst.de> | 2006-03-24 06:15:20 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-24 10:33:17 -0500 |
commit | 1107ccfbdef280fedc677af3bdbc405611ba554a (patch) | |
tree | a3588525dbe853d13e5f25fa496deecaa022ab3a /drivers/s390/block/dasd_int.h | |
parent | 13c6204facb01d425320411c17febff666875518 (diff) |
[PATCH] s390: use normal switch statement for ioctls in dasd_ioctlc
Add an ->ioctl method to the dasd_discipline structure. This allows to apply
the same kind of cleanups the last patch applied to dasd_ioctl.c to
dasd_eckd.c (the only dasd discipline with special ioctls) aswell.
Again lots of code removed. During auditing the ioctls I found two fishy
return value propagations from copy_{from,to}_user, maintainers please check
those, I've marked them with XXX comments.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/s390/block/dasd_int.h')
-rw-r--r-- | drivers/s390/block/dasd_int.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/s390/block/dasd_int.h b/drivers/s390/block/dasd_int.h index 6010ecf76b4c..e9485559e22e 100644 --- a/drivers/s390/block/dasd_int.h +++ b/drivers/s390/block/dasd_int.h | |||
@@ -272,6 +272,7 @@ struct dasd_discipline { | |||
272 | /* i/o control functions. */ | 272 | /* i/o control functions. */ |
273 | int (*fill_geometry) (struct dasd_device *, struct hd_geometry *); | 273 | int (*fill_geometry) (struct dasd_device *, struct hd_geometry *); |
274 | int (*fill_info) (struct dasd_device *, struct dasd_information2_t *); | 274 | int (*fill_info) (struct dasd_device *, struct dasd_information2_t *); |
275 | int (*ioctl) (struct dasd_device *, unsigned int, void __user *); | ||
275 | }; | 276 | }; |
276 | 277 | ||
277 | extern struct dasd_discipline *dasd_diag_discipline_pointer; | 278 | extern struct dasd_discipline *dasd_diag_discipline_pointer; |