diff options
author | Stefan Haberland <stefan.haberland@de.ibm.com> | 2009-03-26 10:23:49 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2009-03-26 10:24:05 -0400 |
commit | fc19f381b3828aa4f8a3417dbefc3418ec6bbe10 (patch) | |
tree | 521d7537e5929de141ba4b616ccc2ab191d4b9fe /drivers/s390/block/dasd_devmap.c | |
parent | f3eb5384cf0325c02e306b1d81e70f81a03d7432 (diff) |
[S390] dasd: message cleanup
Moved some Messages into s390 debug feature and changed remaining
messages to use the dev_xxx and pr_xxx macros.
Signed-off-by: Stefan Haberland <stefan.haberland@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/block/dasd_devmap.c')
-rw-r--r-- | drivers/s390/block/dasd_devmap.c | 38 |
1 files changed, 19 insertions, 19 deletions
diff --git a/drivers/s390/block/dasd_devmap.c b/drivers/s390/block/dasd_devmap.c index da231a787cee..e77666c8e6c0 100644 --- a/drivers/s390/block/dasd_devmap.c +++ b/drivers/s390/block/dasd_devmap.c | |||
@@ -13,6 +13,8 @@ | |||
13 | * | 13 | * |
14 | */ | 14 | */ |
15 | 15 | ||
16 | #define KMSG_COMPONENT "dasd" | ||
17 | |||
16 | #include <linux/ctype.h> | 18 | #include <linux/ctype.h> |
17 | #include <linux/init.h> | 19 | #include <linux/init.h> |
18 | #include <linux/module.h> | 20 | #include <linux/module.h> |
@@ -127,6 +129,7 @@ __setup ("dasd=", dasd_call_setup); | |||
127 | * Read a device busid/devno from a string. | 129 | * Read a device busid/devno from a string. |
128 | */ | 130 | */ |
129 | static int | 131 | static int |
132 | |||
130 | dasd_busid(char **str, int *id0, int *id1, int *devno) | 133 | dasd_busid(char **str, int *id0, int *id1, int *devno) |
131 | { | 134 | { |
132 | int val, old_style; | 135 | int val, old_style; |
@@ -134,8 +137,7 @@ dasd_busid(char **str, int *id0, int *id1, int *devno) | |||
134 | /* Interpret ipldev busid */ | 137 | /* Interpret ipldev busid */ |
135 | if (strncmp(DASD_IPLDEV, *str, strlen(DASD_IPLDEV)) == 0) { | 138 | if (strncmp(DASD_IPLDEV, *str, strlen(DASD_IPLDEV)) == 0) { |
136 | if (ipl_info.type != IPL_TYPE_CCW) { | 139 | if (ipl_info.type != IPL_TYPE_CCW) { |
137 | MESSAGE(KERN_ERR, "%s", "ipl device is not a ccw " | 140 | pr_err("The IPL device is not a CCW device\n"); |
138 | "device"); | ||
139 | return -EINVAL; | 141 | return -EINVAL; |
140 | } | 142 | } |
141 | *id0 = 0; | 143 | *id0 = 0; |
@@ -211,9 +213,8 @@ dasd_feature_list(char *str, char **endp) | |||
211 | else if (len == 8 && !strncmp(str, "failfast", 8)) | 213 | else if (len == 8 && !strncmp(str, "failfast", 8)) |
212 | features |= DASD_FEATURE_FAILFAST; | 214 | features |= DASD_FEATURE_FAILFAST; |
213 | else { | 215 | else { |
214 | MESSAGE(KERN_WARNING, | 216 | pr_warning("%*s is not a supported device option\n", |
215 | "unsupported feature: %*s, " | 217 | len, str); |
216 | "ignoring setting", len, str); | ||
217 | rc = -EINVAL; | 218 | rc = -EINVAL; |
218 | } | 219 | } |
219 | str += len; | 220 | str += len; |
@@ -222,8 +223,8 @@ dasd_feature_list(char *str, char **endp) | |||
222 | str++; | 223 | str++; |
223 | } | 224 | } |
224 | if (*str != ')') { | 225 | if (*str != ')') { |
225 | MESSAGE(KERN_WARNING, "%s", | 226 | pr_warning("A closing parenthesis ')' is missing in the " |
226 | "missing ')' in dasd parameter string\n"); | 227 | "dasd= parameter\n"); |
227 | rc = -EINVAL; | 228 | rc = -EINVAL; |
228 | } else | 229 | } else |
229 | str++; | 230 | str++; |
@@ -255,28 +256,27 @@ dasd_parse_keyword( char *parsestring ) { | |||
255 | } | 256 | } |
256 | if (strncmp("autodetect", parsestring, length) == 0) { | 257 | if (strncmp("autodetect", parsestring, length) == 0) { |
257 | dasd_autodetect = 1; | 258 | dasd_autodetect = 1; |
258 | MESSAGE (KERN_INFO, "%s", | 259 | pr_info("The autodetection mode has been activated\n"); |
259 | "turning to autodetection mode"); | ||
260 | return residual_str; | 260 | return residual_str; |
261 | } | 261 | } |
262 | if (strncmp("probeonly", parsestring, length) == 0) { | 262 | if (strncmp("probeonly", parsestring, length) == 0) { |
263 | dasd_probeonly = 1; | 263 | dasd_probeonly = 1; |
264 | MESSAGE(KERN_INFO, "%s", | 264 | pr_info("The probeonly mode has been activated\n"); |
265 | "turning to probeonly mode"); | ||
266 | return residual_str; | 265 | return residual_str; |
267 | } | 266 | } |
268 | if (strncmp("nopav", parsestring, length) == 0) { | 267 | if (strncmp("nopav", parsestring, length) == 0) { |
269 | if (MACHINE_IS_VM) | 268 | if (MACHINE_IS_VM) |
270 | MESSAGE(KERN_INFO, "%s", "'nopav' not supported on VM"); | 269 | pr_info("'nopav' is not supported on z/VM\n"); |
271 | else { | 270 | else { |
272 | dasd_nopav = 1; | 271 | dasd_nopav = 1; |
273 | MESSAGE(KERN_INFO, "%s", "disable PAV mode"); | 272 | pr_info("PAV support has be deactivated\n"); |
274 | } | 273 | } |
275 | return residual_str; | 274 | return residual_str; |
276 | } | 275 | } |
277 | if (strncmp("nofcx", parsestring, length) == 0) { | 276 | if (strncmp("nofcx", parsestring, length) == 0) { |
278 | dasd_nofcx = 1; | 277 | dasd_nofcx = 1; |
279 | MESSAGE(KERN_INFO, "%s", "disable High Performance Ficon"); | 278 | pr_info("High Performance FICON support has been " |
279 | "deactivated\n"); | ||
280 | return residual_str; | 280 | return residual_str; |
281 | } | 281 | } |
282 | if (strncmp("fixedbuffers", parsestring, length) == 0) { | 282 | if (strncmp("fixedbuffers", parsestring, length) == 0) { |
@@ -287,10 +287,10 @@ dasd_parse_keyword( char *parsestring ) { | |||
287 | PAGE_SIZE, SLAB_CACHE_DMA, | 287 | PAGE_SIZE, SLAB_CACHE_DMA, |
288 | NULL); | 288 | NULL); |
289 | if (!dasd_page_cache) | 289 | if (!dasd_page_cache) |
290 | MESSAGE(KERN_WARNING, "%s", "Failed to create slab, " | 290 | DBF_EVENT(DBF_WARNING, "%s", "Failed to create slab, " |
291 | "fixed buffer mode disabled."); | 291 | "fixed buffer mode disabled."); |
292 | else | 292 | else |
293 | MESSAGE (KERN_INFO, "%s", | 293 | DBF_EVENT(DBF_INFO, "%s", |
294 | "turning on fixed buffer mode"); | 294 | "turning on fixed buffer mode"); |
295 | return residual_str; | 295 | return residual_str; |
296 | } | 296 | } |
@@ -328,7 +328,7 @@ dasd_parse_range( char *parsestring ) { | |||
328 | (from_id0 != to_id0 || from_id1 != to_id1 || from > to)) | 328 | (from_id0 != to_id0 || from_id1 != to_id1 || from > to)) |
329 | rc = -EINVAL; | 329 | rc = -EINVAL; |
330 | if (rc) { | 330 | if (rc) { |
331 | MESSAGE(KERN_ERR, "Invalid device range %s", parsestring); | 331 | pr_err("%s is not a valid device range\n", parsestring); |
332 | return ERR_PTR(rc); | 332 | return ERR_PTR(rc); |
333 | } | 333 | } |
334 | features = dasd_feature_list(str, &str); | 334 | features = dasd_feature_list(str, &str); |
@@ -347,8 +347,8 @@ dasd_parse_range( char *parsestring ) { | |||
347 | return str + 1; | 347 | return str + 1; |
348 | if (*str == '\0') | 348 | if (*str == '\0') |
349 | return str; | 349 | return str; |
350 | MESSAGE(KERN_WARNING, | 350 | pr_warning("The dasd= parameter value %s has an invalid ending\n", |
351 | "junk at end of dasd parameter string: %s\n", str); | 351 | str); |
352 | return ERR_PTR(-EINVAL); | 352 | return ERR_PTR(-EINVAL); |
353 | } | 353 | } |
354 | 354 | ||