Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 into avr32-arch

10 files changed, 348 insertions, 95 deletions

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index cced4d108319..81450fbd8b12 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -241,6 +241,12 @@ config RTC_DRV_M41T80_WDT
           If you say Y here you will get support for the
           watchdog timer in the ST M41T60 and M41T80 RTC chips series.
 
+config RTC_DRV_DM355EVM
+        tristate "TI DaVinci DM355 EVM RTC"
+        depends on MFD_DM355EVM_MSP
+        help
+          Supports the RTC firmware in the MSP430 on the DM355 EVM.
+
 config RTC_DRV_TWL92330
         boolean "TI TWL92330/Menelaus"
         depends on MENELAUS
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index 6e28021abb9d..0e697aa51caa 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -23,6 +23,7 @@ obj-$(CONFIG_RTC_DRV_AT91SAM9)	+= rtc-at91sam9.o
 obj-$(CONFIG_RTC_DRV_AU1XXX)    += rtc-au1xxx.o
 obj-$(CONFIG_RTC_DRV_BFIN)      += rtc-bfin.o
 obj-$(CONFIG_RTC_DRV_CMOS)      += rtc-cmos.o
+obj-$(CONFIG_RTC_DRV_DM355EVM)  += rtc-dm355evm.o
 obj-$(CONFIG_RTC_DRV_DS1216)    += rtc-ds1216.o
 obj-$(CONFIG_RTC_DRV_DS1286)    += rtc-ds1286.o
 obj-$(CONFIG_RTC_DRV_DS1302)    += rtc-ds1302.o
diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
index d5e4e637ddec..86c61f143515 100644
--- a/drivers/rtc/rtc-at91sam9.c
+++ b/drivers/rtc/rtc-at91sam9.c
@@ -351,7 +351,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
         /* register irq handler after we know what name we'll use */
         ret = request_irq(AT91_ID_SYS, at91_rtc_interrupt,
                                 IRQF_DISABLED | IRQF_SHARED,
-                                rtc->rtcdev->dev.bus_id, rtc);
+                                dev_name(&rtc->rtcdev->dev), rtc);
         if (ret) {
                 dev_dbg(&pdev->dev, "can't share IRQ %d?\n", AT91_ID_SYS);
                 rtc_device_unregister(rtc->rtcdev);
@@ -366,7 +366,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
 
         if (gpbr_readl(rtc) == 0)
                 dev_warn(&pdev->dev, "%s: SET TIME!\n",
-                                rtc->rtcdev->dev.bus_id);
+                                dev_name(&rtc->rtcdev->dev));
 
         return 0;
 
diff --git a/drivers/rtc/rtc-au1xxx.c b/drivers/rtc/rtc-au1xxx.c
index 8906a688e6a6..979ed0406ce9 100644
--- a/drivers/rtc/rtc-au1xxx.c
+++ b/drivers/rtc/rtc-au1xxx.c
@@ -81,7 +81,7 @@ static int __devinit au1xtoy_rtc_probe(struct platform_device *pdev)
         if (au_readl(SYS_TOYTRIM) != 32767) {
                 /* wait until hardware gives access to TRIM register */
                 t = 0x00100000;
-                while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_T0S) && t--)
+                while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_T0S) && --t)
                         msleep(1);
 
                 if (!t) {
diff --git a/drivers/rtc/rtc-dm355evm.c b/drivers/rtc/rtc-dm355evm.c
new file mode 100644
index 000000000000..58d4e18530da
--- /dev/null
+++ b/drivers/rtc/rtc-dm355evm.c
@@ -0,0 +1,175 @@
+/*
+ * rtc-dm355evm.c - access battery-backed counter in MSP430 firmware
+ *
+ * Copyright (c) 2008 by David Brownell
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/rtc.h>
+#include <linux/platform_device.h>
+
+#include <linux/i2c/dm355evm_msp.h>
+
+
+/*
+ * The MSP430 firmware on the DM355 EVM uses a watch crystal to feed
+ * a 1 Hz counter.  When a backup battery is supplied, that makes a
+ * reasonable RTC for applications where alarms and non-NTP drift
+ * compensation aren't important.
+ *
+ * The only real glitch is the inability to read or write all four
+ * counter bytes atomically:  the count may increment in the middle
+ * of an operation, causing trouble when the LSB rolls over.
+ *
+ * This driver was tested with firmware revision A4.
+ */
+union evm_time {
+        u8      bytes[4];
+        u32     value;
+};
+
+static int dm355evm_rtc_read_time(struct device *dev, struct rtc_time *tm)
+{
+        union evm_time  time;
+        int             status;
+        int             tries = 0;
+
+        do {
+                /*
+                 * Read LSB(0) to MSB(3) bytes.  Defend against the counter
+                 * rolling over by re-reading until the value is stable,
+                 * and assuming the four reads take at most a few seconds.
+                 */
+                status = dm355evm_msp_read(DM355EVM_MSP_RTC_0);
+                if (status < 0)
+                        return status;
+                if (tries && time.bytes[0] == status)
+                        break;
+                time.bytes[0] = status;
+
+                status = dm355evm_msp_read(DM355EVM_MSP_RTC_1);
+                if (status < 0)
+                        return status;
+                if (tries && time.bytes[1] == status)
+                        break;
+                time.bytes[1] = status;
+
+                status = dm355evm_msp_read(DM355EVM_MSP_RTC_2);
+                if (status < 0)
+                        return status;
+                if (tries && time.bytes[2] == status)
+                        break;
+                time.bytes[2] = status;
+
+                status = dm355evm_msp_read(DM355EVM_MSP_RTC_3);
+                if (status < 0)
+                        return status;
+                if (tries && time.bytes[3] == status)
+                        break;
+                time.bytes[3] = status;
+
+        } while (++tries < 5);
+
+        dev_dbg(dev, "read timestamp %08x\n", time.value);
+
+        rtc_time_to_tm(le32_to_cpu(time.value), tm);
+        return 0;
+}
+
+static int dm355evm_rtc_set_time(struct device *dev, struct rtc_time *tm)
+{
+        union evm_time  time;
+        unsigned long   value;
+        int             status;
+
+        rtc_tm_to_time(tm, &value);
+        time.value = cpu_to_le32(value);
+
+        dev_dbg(dev, "write timestamp %08x\n", time.value);
+
+        /*
+         * REVISIT handle non-atomic writes ... maybe just retry until
+         * byte[1] sticks (no rollover)?
+         */
+        status = dm355evm_msp_write(time.bytes[0], DM355EVM_MSP_RTC_0);
+        if (status < 0)
+                return status;
+
+        status = dm355evm_msp_write(time.bytes[1], DM355EVM_MSP_RTC_1);
+        if (status < 0)
+                return status;
+
+        status = dm355evm_msp_write(time.bytes[2], DM355EVM_MSP_RTC_2);
+        if (status < 0)
+                return status;
+
+        status = dm355evm_msp_write(time.bytes[3], DM355EVM_MSP_RTC_3);
+        if (status < 0)
+                return status;
+
+        return 0;
+}
+
+static struct rtc_class_ops dm355evm_rtc_ops = {
+        .read_time      = dm355evm_rtc_read_time,
+        .set_time       = dm355evm_rtc_set_time,
+};
+
+/*----------------------------------------------------------------------*/
+
+static int __devinit dm355evm_rtc_probe(struct platform_device *pdev)
+{
+        struct rtc_device *rtc;
+
+        rtc = rtc_device_register(pdev->name,
+                                  &pdev->dev, &dm355evm_rtc_ops, THIS_MODULE);
+        if (IS_ERR(rtc)) {
+                dev_err(&pdev->dev, "can't register RTC device, err %ld\n",
+                        PTR_ERR(rtc));
+                return PTR_ERR(rtc);
+        }
+        platform_set_drvdata(pdev, rtc);
+
+        return 0;
+}
+
+static int __devexit dm355evm_rtc_remove(struct platform_device *pdev)
+{
+        struct rtc_device *rtc = platform_get_drvdata(pdev);
+
+        rtc_device_unregister(rtc);
+        platform_set_drvdata(pdev, NULL);
+        return 0;
+}
+
+/*
+ * I2C is used to talk to the MSP430, but this platform device is
+ * exposed by an MFD driver that manages I2C communications.
+ */
+static struct platform_driver rtc_dm355evm_driver = {
+        .probe          = dm355evm_rtc_probe,
+        .remove         = __devexit_p(dm355evm_rtc_remove),
+        .driver         = {
+                .owner  = THIS_MODULE,
+                .name   = "rtc-dm355evm",
+        },
+};
+
+static int __init dm355evm_rtc_init(void)
+{
+        return platform_driver_register(&rtc_dm355evm_driver);
+}
+module_init(dm355evm_rtc_init);
+
+static void __exit dm355evm_rtc_exit(void)
+{
+        platform_driver_unregister(&rtc_dm355evm_driver);
+}
+module_exit(dm355evm_rtc_exit);
+
+MODULE_LICENSE("GPL");
diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
index e54b5c619bdf..e01b955db077 100644
--- a/drivers/rtc/rtc-ds1390.c
+++ b/drivers/rtc/rtc-ds1390.c
@@ -122,7 +122,6 @@ static const struct rtc_class_ops ds1390_rtc_ops = {
 
 static int __devinit ds1390_probe(struct spi_device *spi)
 {
-        struct rtc_device *rtc;
         unsigned char tmp;
         struct ds1390 *chip;
         int res;
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 2cbeb0794f14..bd1ce8e2bc18 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc-omap.c
@@ -377,13 +377,13 @@ static int __init omap_rtc_probe(struct platform_device *pdev)
 
         /* handle periodic and alarm irqs */
         if (request_irq(omap_rtc_timer, rtc_irq, IRQF_DISABLED,
-                        rtc->dev.bus_id, rtc)) {
+                        dev_name(&rtc->dev), rtc)) {
                 pr_debug("%s: RTC timer interrupt IRQ%d already claimed\n",
                         pdev->name, omap_rtc_timer);
                 goto fail0;
         }
         if (request_irq(omap_rtc_alarm, rtc_irq, IRQF_DISABLED,
-                        rtc->dev.bus_id, rtc)) {
+                        dev_name(&rtc->dev), rtc)) {
                 pr_debug("%s: RTC alarm interrupt IRQ%d already claimed\n",
                         pdev->name, omap_rtc_alarm);
                 goto fail1;
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index bd56a033bfd0..bb8cc05605ac 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -485,7 +485,7 @@ static void __exit pxa_rtc_exit(void)
 module_init(pxa_rtc_init);
 module_exit(pxa_rtc_exit);
 
-MODULE_AUTHOR("Robert Jarzmik");
+MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@free.fr>");
 MODULE_DESCRIPTION("PXA27x/PXA3xx Realtime Clock Driver (RTC)");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:pxa-rtc");
diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index 1c3fc6b428e9..4898f7fe8518 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -28,7 +28,7 @@
 #include <asm/rtc.h>
 
 #define DRV_NAME        "sh-rtc"
-#define DRV_VERSION     "0.2.0"
+#define DRV_VERSION     "0.2.1"
 
 #define RTC_REG(r)      ((r) * rtc_reg_size)
 
@@ -99,56 +99,51 @@ struct sh_rtc {
         unsigned short periodic_freq;
 };
 
-static irqreturn_t sh_rtc_interrupt(int irq, void *dev_id)
+static int __sh_rtc_interrupt(struct sh_rtc *rtc)
 {
-        struct sh_rtc *rtc = dev_id;
-        unsigned int tmp;
-
-        spin_lock(&rtc->lock);
+        unsigned int tmp, pending;
 
         tmp = readb(rtc->regbase + RCR1);
+        pending = tmp & RCR1_CF;
         tmp &= ~RCR1_CF;
         writeb(tmp, rtc->regbase + RCR1);
 
         /* Users have requested One x Second IRQ */
-        if (rtc->periodic_freq & PF_OXS)
+        if (pending && rtc->periodic_freq & PF_OXS)
                 rtc_update_irq(rtc->rtc_dev, 1, RTC_UF | RTC_IRQF);
 
-        spin_unlock(&rtc->lock);
-
-        return IRQ_HANDLED;
+        return pending;
 }
 
-static irqreturn_t sh_rtc_alarm(int irq, void *dev_id)
+static int __sh_rtc_alarm(struct sh_rtc *rtc)
 {
-        struct sh_rtc *rtc = dev_id;
-        unsigned int tmp;
-
-        spin_lock(&rtc->lock);
+        unsigned int tmp, pending;
 
         tmp = readb(rtc->regbase + RCR1);
+        pending = tmp & RCR1_AF;
         tmp &= ~(RCR1_AF | RCR1_AIE);
-                writeb(tmp, rtc->regbase + RCR1);
-
-        rtc_update_irq(rtc->rtc_dev, 1, RTC_AF | RTC_IRQF);
+        writeb(tmp, rtc->regbase + RCR1);
 
-        spin_unlock(&rtc->lock);
+        if (pending)
+                rtc_update_irq(rtc->rtc_dev, 1, RTC_AF | RTC_IRQF);
 
-        return IRQ_HANDLED;
+        return pending;
 }
 
-static irqreturn_t sh_rtc_periodic(int irq, void *dev_id)
+static int __sh_rtc_periodic(struct sh_rtc *rtc)
 {
-        struct sh_rtc *rtc = dev_id;
         struct rtc_device *rtc_dev = rtc->rtc_dev;
-        unsigned int tmp;
-
-        spin_lock(&rtc->lock);
+        struct rtc_task *irq_task;
+        unsigned int tmp, pending;
 
         tmp = readb(rtc->regbase + RCR2);
+        pending = tmp & RCR2_PEF;
         tmp &= ~RCR2_PEF;
         writeb(tmp, rtc->regbase + RCR2);
 
+        if (!pending)
+                return 0;
+
         /* Half period enabled than one skipped and the next notified */
         if ((rtc->periodic_freq & PF_HP) && (rtc->periodic_freq & PF_COUNT))
                 rtc->periodic_freq &= ~PF_COUNT;
@@ -157,16 +152,65 @@ static irqreturn_t sh_rtc_periodic(int irq, void *dev_id)
                         rtc->periodic_freq |= PF_COUNT;
                 if (rtc->periodic_freq & PF_KOU) {
                         spin_lock(&rtc_dev->irq_task_lock);
-                        if (rtc_dev->irq_task)
-                                rtc_dev->irq_task->func(rtc_dev->irq_task->private_data);
+                        irq_task = rtc_dev->irq_task;
+                        if (irq_task)
+                                irq_task->func(irq_task->private_data);
                         spin_unlock(&rtc_dev->irq_task_lock);
                 } else
                         rtc_update_irq(rtc->rtc_dev, 1, RTC_PF | RTC_IRQF);
         }
 
+        return pending;
+}
+
+static irqreturn_t sh_rtc_interrupt(int irq, void *dev_id)
+{
+        struct sh_rtc *rtc = dev_id;
+        int ret;
+
+        spin_lock(&rtc->lock);
+        ret = __sh_rtc_interrupt(rtc);
+        spin_unlock(&rtc->lock);
+
+        return IRQ_RETVAL(ret);
+}
+
+static irqreturn_t sh_rtc_alarm(int irq, void *dev_id)
+{
+        struct sh_rtc *rtc = dev_id;
+        int ret;
+
+        spin_lock(&rtc->lock);
+        ret = __sh_rtc_alarm(rtc);
+        spin_unlock(&rtc->lock);
+
+        return IRQ_RETVAL(ret);
+}
+
+static irqreturn_t sh_rtc_periodic(int irq, void *dev_id)
+{
+        struct sh_rtc *rtc = dev_id;
+        int ret;
+
+        spin_lock(&rtc->lock);
+        ret = __sh_rtc_periodic(rtc);
         spin_unlock(&rtc->lock);
 
-        return IRQ_HANDLED;
+        return IRQ_RETVAL(ret);
+}
+
+static irqreturn_t sh_rtc_shared(int irq, void *dev_id)
+{
+        struct sh_rtc *rtc = dev_id;
+        int ret;
+
+        spin_lock(&rtc->lock);
+        ret = __sh_rtc_interrupt(rtc);
+        ret |= __sh_rtc_alarm(rtc);
+        ret |= __sh_rtc_periodic(rtc);
+        spin_unlock(&rtc->lock);
+
+        return IRQ_RETVAL(ret);
 }
 
 static inline void sh_rtc_setpie(struct device *dev, unsigned int enable)
@@ -275,6 +319,25 @@ static int sh_rtc_proc(struct device *dev, struct seq_file *seq)
         return 0;
 }
 
+static inline void sh_rtc_setcie(struct device *dev, unsigned int enable)
+{
+        struct sh_rtc *rtc = dev_get_drvdata(dev);
+        unsigned int tmp;
+
+        spin_lock_irq(&rtc->lock);
+
+        tmp = readb(rtc->regbase + RCR1);
+
+        if (!enable)
+                tmp &= ~RCR1_CIE;
+        else
+                tmp |= RCR1_CIE;
+
+        writeb(tmp, rtc->regbase + RCR1);
+
+        spin_unlock_irq(&rtc->lock);
+}
+
 static int sh_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)
 {
         struct sh_rtc *rtc = dev_get_drvdata(dev);
@@ -291,9 +354,11 @@ static int sh_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)
                 break;
         case RTC_UIE_OFF:
                 rtc->periodic_freq &= ~PF_OXS;
+                sh_rtc_setcie(dev, 0);
                 break;
         case RTC_UIE_ON:
                 rtc->periodic_freq |= PF_OXS;
+                sh_rtc_setcie(dev, 1);
                 break;
         case RTC_IRQP_READ:
                 ret = put_user(rtc->rtc_dev->irq_freq,
@@ -356,18 +421,17 @@ static int sh_rtc_read_time(struct device *dev, struct rtc_time *tm)
                 tm->tm_sec--;
 #endif
 
+        /* only keep the carry interrupt enabled if UIE is on */
+        if (!(rtc->periodic_freq & PF_OXS))
+                sh_rtc_setcie(dev, 0);
+
         dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, "
                 "mday=%d, mon=%d, year=%d, wday=%d\n",
                 __func__,
                 tm->tm_sec, tm->tm_min, tm->tm_hour,
                 tm->tm_mday, tm->tm_mon + 1, tm->tm_year, tm->tm_wday);
 
-        if (rtc_valid_tm(tm) < 0) {
-                dev_err(dev, "invalid date\n");
-                rtc_time_to_tm(0, tm);
-        }
-
-        return 0;
+        return rtc_valid_tm(tm);
 }
 
 static int sh_rtc_set_time(struct device *dev, struct rtc_time *tm)
@@ -572,7 +636,7 @@ static int __devinit sh_rtc_probe(struct platform_device *pdev)
 {
         struct sh_rtc *rtc;
         struct resource *res;
-        unsigned int tmp;
+        struct rtc_time r;
         int ret;
 
         rtc = kzalloc(sizeof(struct sh_rtc), GFP_KERNEL);
@@ -585,26 +649,12 @@ static int __devinit sh_rtc_probe(struct platform_device *pdev)
         ret = platform_get_irq(pdev, 0);
         if (unlikely(ret <= 0)) {
                 ret = -ENOENT;
-                dev_err(&pdev->dev, "No IRQ for period\n");
+                dev_err(&pdev->dev, "No IRQ resource\n");
                 goto err_badres;
         }
         rtc->periodic_irq = ret;
-
-        ret = platform_get_irq(pdev, 1);
-        if (unlikely(ret <= 0)) {
-                ret = -ENOENT;
-                dev_err(&pdev->dev, "No IRQ for carry\n");
-                goto err_badres;
-        }
-        rtc->carry_irq = ret;
-
-        ret = platform_get_irq(pdev, 2);
-        if (unlikely(ret <= 0)) {
-                ret = -ENOENT;
-                dev_err(&pdev->dev, "No IRQ for alarm\n");
-                goto err_badres;
-        }
-        rtc->alarm_irq = ret;
+        rtc->carry_irq = platform_get_irq(pdev, 1);
+        rtc->alarm_irq = platform_get_irq(pdev, 2);
 
         res = platform_get_resource(pdev, IORESOURCE_IO, 0);
         if (unlikely(res == NULL)) {
@@ -646,47 +696,66 @@ static int __devinit sh_rtc_probe(struct platform_device *pdev)
         }
 
         rtc->rtc_dev->max_user_freq = 256;
-        rtc->rtc_dev->irq_freq = 1;
-        rtc->periodic_freq = 0x60;
 
         platform_set_drvdata(pdev, rtc);
 
-        /* register periodic/carry/alarm irqs */
-        ret = request_irq(rtc->periodic_irq, sh_rtc_periodic, IRQF_DISABLED,
-                          "sh-rtc period", rtc);
-        if (unlikely(ret)) {
-                dev_err(&pdev->dev,
-                        "request period IRQ failed with %d, IRQ %d\n", ret,
-                        rtc->periodic_irq);
-                goto err_unmap;
-        }
+        if (rtc->carry_irq <= 0) {
+                /* register shared periodic/carry/alarm irq */
+                ret = request_irq(rtc->periodic_irq, sh_rtc_shared,
+                                  IRQF_DISABLED, "sh-rtc", rtc);
+                if (unlikely(ret)) {
+                        dev_err(&pdev->dev,
+                                "request IRQ failed with %d, IRQ %d\n", ret,
+                                rtc->periodic_irq);
+                        goto err_unmap;
+                }
+        } else {
+                /* register periodic/carry/alarm irqs */
+                ret = request_irq(rtc->periodic_irq, sh_rtc_periodic,
+                                  IRQF_DISABLED, "sh-rtc period", rtc);
+                if (unlikely(ret)) {
+                        dev_err(&pdev->dev,
+                                "request period IRQ failed with %d, IRQ %d\n",
+                                ret, rtc->periodic_irq);
+                        goto err_unmap;
+                }
 
-        ret = request_irq(rtc->carry_irq, sh_rtc_interrupt, IRQF_DISABLED,
-                          "sh-rtc carry", rtc);
-        if (unlikely(ret)) {
-                dev_err(&pdev->dev,
-                        "request carry IRQ failed with %d, IRQ %d\n", ret,
-                        rtc->carry_irq);
-                free_irq(rtc->periodic_irq, rtc);
-                goto err_unmap;
-        }
+                ret = request_irq(rtc->carry_irq, sh_rtc_interrupt,
+                                  IRQF_DISABLED, "sh-rtc carry", rtc);
+                if (unlikely(ret)) {
+                        dev_err(&pdev->dev,
+                                "request carry IRQ failed with %d, IRQ %d\n",
+                                ret, rtc->carry_irq);
+                        free_irq(rtc->periodic_irq, rtc);
+                        goto err_unmap;
+                }
 
-        ret = request_irq(rtc->alarm_irq, sh_rtc_alarm, IRQF_DISABLED,
-                          "sh-rtc alarm", rtc);
-        if (unlikely(ret)) {
-                dev_err(&pdev->dev,
-                        "request alarm IRQ failed with %d, IRQ %d\n", ret,
-                        rtc->alarm_irq);
-                free_irq(rtc->carry_irq, rtc);
-                free_irq(rtc->periodic_irq, rtc);
-                goto err_unmap;
+                ret = request_irq(rtc->alarm_irq, sh_rtc_alarm,
+                                  IRQF_DISABLED, "sh-rtc alarm", rtc);
+                if (unlikely(ret)) {
+                        dev_err(&pdev->dev,
+                                "request alarm IRQ failed with %d, IRQ %d\n",
+                                ret, rtc->alarm_irq);
+                        free_irq(rtc->carry_irq, rtc);
+                        free_irq(rtc->periodic_irq, rtc);
+                        goto err_unmap;
+                }
         }
 
-        tmp = readb(rtc->regbase + RCR1);
-        tmp &= ~RCR1_CF;
-        tmp |= RCR1_CIE;
-        writeb(tmp, rtc->regbase + RCR1);
+        /* everything disabled by default */
+        rtc->periodic_freq = 0;
+        rtc->rtc_dev->irq_freq = 0;
+        sh_rtc_setpie(&pdev->dev, 0);
+        sh_rtc_setaie(&pdev->dev, 0);
+        sh_rtc_setcie(&pdev->dev, 0);
+
+        /* reset rtc to epoch 0 if time is invalid */
+        if (rtc_read_time(rtc->rtc_dev, &r) < 0) {
+                rtc_time_to_tm(0, &r);
+                rtc_set_time(rtc->rtc_dev, &r);
+        }
 
+        device_init_wakeup(&pdev->dev, 1);
         return 0;
 
 err_unmap:
@@ -708,10 +777,13 @@ static int __devexit sh_rtc_remove(struct platform_device *pdev)
 
         sh_rtc_setpie(&pdev->dev, 0);
         sh_rtc_setaie(&pdev->dev, 0);
+        sh_rtc_setcie(&pdev->dev, 0);
 
-        free_irq(rtc->carry_irq, rtc);
         free_irq(rtc->periodic_irq, rtc);
-        free_irq(rtc->alarm_irq, rtc);
+        if (rtc->carry_irq > 0) {
+                free_irq(rtc->carry_irq, rtc);
+                free_irq(rtc->alarm_irq, rtc);
+        }
 
         release_resource(rtc->res);
 
diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c
index ad35f76c46b7..a6341e4f9a0f 100644
--- a/drivers/rtc/rtc-twl4030.c
+++ b/drivers/rtc/rtc-twl4030.c
@@ -426,7 +426,7 @@ static int __devinit twl4030_rtc_probe(struct platform_device *pdev)
 
         ret = request_irq(irq, twl4030_rtc_interrupt,
                                 IRQF_TRIGGER_RISING,
-                                rtc->dev.bus_id, rtc);
+                                dev_name(&rtc->dev), rtc);
         if (ret < 0) {
                 dev_err(&pdev->dev, "IRQ is not free.\n");
                 goto out1;