aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-vt8500.c
diff options
context:
space:
mode:
authorJingoo Han <jg1.han@samsung.com>2013-04-29 19:19:19 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2013-04-29 21:28:27 -0400
commitbc2e9c0b29be813f90e26161a1cc4eeafa4582b7 (patch)
tree19b2d431f405cfe2add147f8495a60339d35c6a3 /drivers/rtc/rtc-vt8500.c
parente38fc305f4da457b35ac4df5723c8f57ad0c9a52 (diff)
rtc: rtc-vt8500: use devm_rtc_device_register()
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-vt8500.c')
-rw-r--r--drivers/rtc/rtc-vt8500.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
index a000bc0a8bff..d89efee6d29e 100644
--- a/drivers/rtc/rtc-vt8500.c
+++ b/drivers/rtc/rtc-vt8500.c
@@ -252,7 +252,7 @@ static int vt8500_rtc_probe(struct platform_device *pdev)
252 writel(VT8500_RTC_CR_ENABLE, 252 writel(VT8500_RTC_CR_ENABLE,
253 vt8500_rtc->regbase + VT8500_RTC_CR); 253 vt8500_rtc->regbase + VT8500_RTC_CR);
254 254
255 vt8500_rtc->rtc = rtc_device_register("vt8500-rtc", &pdev->dev, 255 vt8500_rtc->rtc = devm_rtc_device_register(&pdev->dev, "vt8500-rtc",
256 &vt8500_rtc_ops, THIS_MODULE); 256 &vt8500_rtc_ops, THIS_MODULE);
257 if (IS_ERR(vt8500_rtc->rtc)) { 257 if (IS_ERR(vt8500_rtc->rtc)) {
258 ret = PTR_ERR(vt8500_rtc->rtc); 258 ret = PTR_ERR(vt8500_rtc->rtc);
@@ -266,13 +266,11 @@ static int vt8500_rtc_probe(struct platform_device *pdev)
266 if (ret < 0) { 266 if (ret < 0) {
267 dev_err(&pdev->dev, "can't get irq %i, err %d\n", 267 dev_err(&pdev->dev, "can't get irq %i, err %d\n",
268 vt8500_rtc->irq_alarm, ret); 268 vt8500_rtc->irq_alarm, ret);
269 goto err_unreg; 269 goto err_return;
270 } 270 }
271 271
272 return 0; 272 return 0;
273 273
274err_unreg:
275 rtc_device_unregister(vt8500_rtc->rtc);
276err_return: 274err_return:
277 return ret; 275 return ret;
278} 276}
@@ -281,8 +279,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
281{ 279{
282 struct vt8500_rtc *vt8500_rtc = platform_get_drvdata(pdev); 280 struct vt8500_rtc *vt8500_rtc = platform_get_drvdata(pdev);
283 281
284 rtc_device_unregister(vt8500_rtc->rtc);
285
286 /* Disable alarm matching */ 282 /* Disable alarm matching */
287 writel(0, vt8500_rtc->regbase + VT8500_RTC_IS); 283 writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
288 284