diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-09-11 17:24:27 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 18:58:59 -0400 |
commit | 7c1d69ee11b8986c40a53d8e2238204fc86f5b33 (patch) | |
tree | e711a10129ef7b6e060fdfa82dc7eb31f55be2d8 /drivers/rtc/rtc-ds1511.c | |
parent | 1735be4b822e8e3808f461372ff3942824790172 (diff) |
rtc: simplify devm_request_mem_region/devm_ioremap
Convert the composition of devm_request_mem_region and devm_ioremap to a
single call to devm_ioremap_resource. The associated call to
platform_get_resource is also simplified and moved next to the new call
to devm_ioremap_resource.
This was done using a combination of the semantic patches
devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in
the scripts/coccinelle/api directory.
In rtc-lpc32xx.c and rtc-mv.c, the local variable size is no longer needed.
In rtc-ds1511.c the size field of the local structure is not useful any
more, and is deleted.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-ds1511.c')
-rw-r--r-- | drivers/rtc/rtc-ds1511.c | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c index 308a8fefe76f..bc7b4fcf603c 100644 --- a/drivers/rtc/rtc-ds1511.c +++ b/drivers/rtc/rtc-ds1511.c | |||
@@ -89,7 +89,6 @@ enum ds1511reg { | |||
89 | struct rtc_plat_data { | 89 | struct rtc_plat_data { |
90 | struct rtc_device *rtc; | 90 | struct rtc_device *rtc; |
91 | void __iomem *ioaddr; /* virtual base address */ | 91 | void __iomem *ioaddr; /* virtual base address */ |
92 | int size; /* amount of memory mapped */ | ||
93 | int irq; | 92 | int irq; |
94 | unsigned int irqen; | 93 | unsigned int irqen; |
95 | int alrm_sec; | 94 | int alrm_sec; |
@@ -479,20 +478,14 @@ static int ds1511_rtc_probe(struct platform_device *pdev) | |||
479 | struct rtc_plat_data *pdata; | 478 | struct rtc_plat_data *pdata; |
480 | int ret = 0; | 479 | int ret = 0; |
481 | 480 | ||
482 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
483 | if (!res) | ||
484 | return -ENODEV; | ||
485 | |||
486 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); | 481 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); |
487 | if (!pdata) | 482 | if (!pdata) |
488 | return -ENOMEM; | 483 | return -ENOMEM; |
489 | pdata->size = resource_size(res); | 484 | |
490 | if (!devm_request_mem_region(&pdev->dev, res->start, pdata->size, | 485 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
491 | pdev->name)) | 486 | ds1511_base = devm_ioremap_resource(&pdev->dev, res); |
492 | return -EBUSY; | 487 | if (IS_ERR(ds1511_base)) |
493 | ds1511_base = devm_ioremap(&pdev->dev, res->start, pdata->size); | 488 | return PTR_ERR(ds1511_base); |
494 | if (!ds1511_base) | ||
495 | return -ENOMEM; | ||
496 | pdata->ioaddr = ds1511_base; | 489 | pdata->ioaddr = ds1511_base; |
497 | pdata->irq = platform_get_irq(pdev, 0); | 490 | pdata->irq = platform_get_irq(pdev, 0); |
498 | 491 | ||