RTC: Convert rtc drivers to use the alarm_irq_enable method

Some rtc drivers use the ioctl method instead of the alarm_irq_enable
method for enabling alarm interupts. With the new virtualized RTC
rework, its important for drivers to use the alarm_irq_enable instead.

This patch converts the drivers that use the AIE ioctl method to
use the alarm_irq_enable method. Other ioctl cmds are left untouched.

I have not been able to test or even compile most of these drivers.
Any help to make sure this change is correct would be appreciated!

CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Reported-by: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Tested-by: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
Signed-off-by: John Stultz <john.stultz@linaro.org>

1 files changed, 6 insertions, 13 deletions

diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c
index b2752b6e7a2f..e725d51e773d 100644
--- a/drivers/rtc/rtc-at32ap700x.c
+++ b/drivers/rtc/rtc-at32ap700x.c
@@ -134,36 +134,29 @@ static int at32_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
         return ret;
 }
 
-static int at32_rtc_ioctl(struct device *dev, unsigned int cmd,
-                        unsigned long arg)
+static int at32_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
 {
         struct rtc_at32ap700x *rtc = dev_get_drvdata(dev);
         int ret = 0;
 
         spin_lock_irq(&rtc->lock);
 
-        switch (cmd) {
-        case RTC_AIE_ON:
+        if(enabled) {
                 if (rtc_readl(rtc, VAL) > rtc->alarm_time) {
                         ret = -EINVAL;
-                        break;
+                        goto out;
                 }
                 rtc_writel(rtc, CTRL, rtc_readl(rtc, CTRL)
                                 | RTC_BIT(CTRL_TOPEN));
                 rtc_writel(rtc, ICR, RTC_BIT(ICR_TOPI));
                 rtc_writel(rtc, IER, RTC_BIT(IER_TOPI));
-                break;
-        case RTC_AIE_OFF:
+        } else {
                 rtc_writel(rtc, CTRL, rtc_readl(rtc, CTRL)
                                 & ~RTC_BIT(CTRL_TOPEN));
                 rtc_writel(rtc, IDR, RTC_BIT(IDR_TOPI));
                 rtc_writel(rtc, ICR, RTC_BIT(ICR_TOPI));
-                break;
-        default:
-                ret = -ENOIOCTLCMD;
-                break;
         }
-
+out:
         spin_unlock_irq(&rtc->lock);
 
         return ret;
@@ -195,11 +188,11 @@ static irqreturn_t at32_rtc_interrupt(int irq, void *dev_id)
 }
 
 static struct rtc_class_ops at32_rtc_ops = {
-        .ioctl          = at32_rtc_ioctl,
         .read_time      = at32_rtc_readtime,
         .set_time       = at32_rtc_settime,
         .read_alarm     = at32_rtc_readalarm,
         .set_alarm      = at32_rtc_setalarm,
+        .alarm_irq_enable = at32_rtc_alarm_irq_enable,
 };
 
 static int __init at32_rtc_probe(struct platform_device *pdev)