diff options
author | Laxman Dewangan <ldewangan@nvidia.com> | 2013-03-18 05:29:49 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2013-03-20 08:38:09 -0400 |
commit | bbcf50b1d6b38e34958a1572f4077fa12d3dc24d (patch) | |
tree | d8ca87db12908845b68d398bbd16f0f8f975ff56 /drivers/regulator | |
parent | 71f2146f6c22716838ffafd054391826341874f9 (diff) |
regulator: palmas: rename probe/remove callback functions
When palmas regulator probe creates stack dump during initialization
due to some crash, it prints the call trace as follows:
[3.166321] [<c028fa20>] (_regmap_read+0x5c/0xa8) from [<c028fab0>] (regmap_read+0x44/0x5c)
[3.174669] [<c028fab0>] (regmap_read+0x44/0x5c) from [<c023062c>] (palmas_probe+0x240/0x7d0)
[3.183193] [<c023062c>] (palmas_probe+0x240/0x7d0) from [<c0284064>] (platform_drv_probe+0x14/0x18)
[3.192322] [<c0284064>] (platform_drv_probe+0x14/0x18) from [<c0282ee4>] (driver_probe_device+0x104/0x214)
[3.202055] [<c0282ee4>] (driver_probe_device+0x104/0x214) from [<c028167c>] (bus_for_each_drv+0x5c/0x88)
The palmas_probe is current name but it helps on debugging if the
function name is more appropriate to the sub-module name.
Renaming the palmas_probe() to palmas_regulator_probe() and
palmas_remove() to palams_regulator_remove().
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/regulator')
-rw-r--r-- | drivers/regulator/palmas-regulator.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 122fea432d38..aec2d76096dd 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c | |||
@@ -581,7 +581,7 @@ static void palmas_dt_to_pdata(struct device *dev, | |||
581 | } | 581 | } |
582 | 582 | ||
583 | 583 | ||
584 | static int palmas_probe(struct platform_device *pdev) | 584 | static int palmas_regulators_probe(struct platform_device *pdev) |
585 | { | 585 | { |
586 | struct palmas *palmas = dev_get_drvdata(pdev->dev.parent); | 586 | struct palmas *palmas = dev_get_drvdata(pdev->dev.parent); |
587 | struct palmas_pmic_platform_data *pdata = pdev->dev.platform_data; | 587 | struct palmas_pmic_platform_data *pdata = pdev->dev.platform_data; |
@@ -790,7 +790,7 @@ err_unregister_regulator: | |||
790 | return ret; | 790 | return ret; |
791 | } | 791 | } |
792 | 792 | ||
793 | static int palmas_remove(struct platform_device *pdev) | 793 | static int palmas_regulators_remove(struct platform_device *pdev) |
794 | { | 794 | { |
795 | struct palmas_pmic *pmic = platform_get_drvdata(pdev); | 795 | struct palmas_pmic *pmic = platform_get_drvdata(pdev); |
796 | int id; | 796 | int id; |
@@ -818,8 +818,8 @@ static struct platform_driver palmas_driver = { | |||
818 | .of_match_table = of_palmas_match_tbl, | 818 | .of_match_table = of_palmas_match_tbl, |
819 | .owner = THIS_MODULE, | 819 | .owner = THIS_MODULE, |
820 | }, | 820 | }, |
821 | .probe = palmas_probe, | 821 | .probe = palmas_regulators_probe, |
822 | .remove = palmas_remove, | 822 | .remove = palmas_regulators_remove, |
823 | }; | 823 | }; |
824 | 824 | ||
825 | static int __init palmas_init(void) | 825 | static int __init palmas_init(void) |