diff options
author | Alexandre Bounine <alexandre.bounine@idt.com> | 2010-10-27 18:34:36 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-27 21:03:16 -0400 |
commit | 1548bf316f18090576f611c7318447c512ddbdd2 (patch) | |
tree | 0a33f527a5fc5c2b3c7cacba7b352f7b9e1d0d37 /drivers/rapidio/switches | |
parent | 2d4da0fc0940625d59f014c3f85370f9b60ba7f4 (diff) |
rapidio: fix destructive port EM initialization for Tsi568
Replace possibly damaging broadcast writes into the per-port SP_MODE
registers with individual writes for each port. This will preserve
individual port configurations in case if ports are configured
differently.
Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: Kumar Gala <galak@kernel.crashing.org>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Li Yang <leoli@freescale.com>
Cc: Thomas Moll <thomas.moll@sysgo.com>
Cc: Micha Nelissen <micha@neli.hopto.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rapidio/switches')
-rw-r--r-- | drivers/rapidio/switches/tsi568.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/rapidio/switches/tsi568.c b/drivers/rapidio/switches/tsi568.c index f7fd7898606e..b9a389b9f812 100644 --- a/drivers/rapidio/switches/tsi568.c +++ b/drivers/rapidio/switches/tsi568.c | |||
@@ -29,7 +29,7 @@ | |||
29 | #define SPP_ROUTE_CFG_DESTID(n) (0x11070 + 0x100*n) | 29 | #define SPP_ROUTE_CFG_DESTID(n) (0x11070 + 0x100*n) |
30 | #define SPP_ROUTE_CFG_PORT(n) (0x11074 + 0x100*n) | 30 | #define SPP_ROUTE_CFG_PORT(n) (0x11074 + 0x100*n) |
31 | 31 | ||
32 | #define TSI568_SP_MODE_BC 0x10004 | 32 | #define TSI568_SP_MODE(n) (0x11004 + 0x100*n) |
33 | #define TSI568_SP_MODE_PW_DIS 0x08000000 | 33 | #define TSI568_SP_MODE_PW_DIS 0x08000000 |
34 | 34 | ||
35 | static int | 35 | static int |
@@ -117,14 +117,19 @@ tsi568_em_init(struct rio_dev *rdev) | |||
117 | u16 destid = rdev->rswitch->destid; | 117 | u16 destid = rdev->rswitch->destid; |
118 | u8 hopcount = rdev->rswitch->hopcount; | 118 | u8 hopcount = rdev->rswitch->hopcount; |
119 | u32 regval; | 119 | u32 regval; |
120 | int portnum; | ||
120 | 121 | ||
121 | pr_debug("TSI568 %s [%d:%d]\n", __func__, destid, hopcount); | 122 | pr_debug("TSI568 %s [%d:%d]\n", __func__, destid, hopcount); |
122 | 123 | ||
123 | /* Make sure that Port-Writes are disabled (for all ports) */ | 124 | /* Make sure that Port-Writes are disabled (for all ports) */ |
124 | rio_mport_read_config_32(mport, destid, hopcount, | 125 | for (portnum = 0; |
125 | TSI568_SP_MODE_BC, ®val); | 126 | portnum < RIO_GET_TOTAL_PORTS(rdev->swpinfo); portnum++) { |
126 | rio_mport_write_config_32(mport, destid, hopcount, | 127 | rio_mport_read_config_32(mport, destid, hopcount, |
127 | TSI568_SP_MODE_BC, regval | TSI568_SP_MODE_PW_DIS); | 128 | TSI568_SP_MODE(portnum), ®val); |
129 | rio_mport_write_config_32(mport, destid, hopcount, | ||
130 | TSI568_SP_MODE(portnum), | ||
131 | regval | TSI568_SP_MODE_PW_DIS); | ||
132 | } | ||
128 | 133 | ||
129 | return 0; | 134 | return 0; |
130 | } | 135 | } |