W1: split master mutex to avoid deadlocks.

The 'mutex' in struct w1_master is use for two very different
purposes.

Firstly it protects various data structures such as the list of all
slaves.

Secondly it protects the w1 buss against concurrent accesses.

This can lead to deadlocks when the ->probe code called while adding a
slave needs to talk on the bus, as is the case for power_supply
devices.
ds2780 and ds2781 drivers contain a work around to track which
process hold the lock simply to avoid this deadlock.  bq27000 doesn't
have that work around and so deadlocks.

There are other possible deadlocks involving sysfs.
When removing a device the sysfs s_active lock is held, so the lock
that protects the slave list must take precedence over s_active.
However when access power_supply attributes via sysfs, the s_active
lock must take precedence over the lock that protects accesses to
the bus.

So to avoid deadlocks between w1 slaves and sysfs, these must be
two separate locks.  Making them separate means that the work around
in ds2780 and ds2781 can be removed.

So this patch:
 - adds a new mutex: "bus_mutex" which serialises access to the bus.
 - takes in mutex in w1_search and ds1wm_search while they access
   the bus for searching.  The mutex is dropped before calling the
   callback which adds the slave.
 - changes all slaves to use bus_mutex instead of mutex to
   protect access to the bus
 - removes w1_ds2790_io_nolock and w1_ds2781_io_nolock, and the
   related code from drivers/power/ds278[01]_battery.c which
   calls them.

Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2 files changed, 2 insertions, 21 deletions

diff --git a/drivers/power/ds2780_battery.c b/drivers/power/ds2780_battery.c
index de31cae1ba53..74fad941c56c 100644
--- a/drivers/power/ds2780_battery.c
+++ b/drivers/power/ds2780_battery.c
@@ -39,7 +39,6 @@ struct ds2780_device_info {
         struct device *dev;
         struct power_supply bat;
         struct device *w1_dev;
-        struct task_struct *mutex_holder;
 };
 
 enum current_types {
@@ -64,10 +63,7 @@ static inline struct power_supply *to_power_supply(struct device *dev)
 static inline int ds2780_battery_io(struct ds2780_device_info *dev_info,
         char *buf, int addr, size_t count, int io)
 {
-        if (dev_info->mutex_holder == current)
-                return w1_ds2780_io_nolock(dev_info->w1_dev, buf, addr, count, io);
-        else
-                return w1_ds2780_io(dev_info->w1_dev, buf, addr, count, io);
+        return w1_ds2780_io(dev_info->w1_dev, buf, addr, count, io);
 }
 
 static inline int ds2780_read8(struct ds2780_device_info *dev_info, u8 *val,
@@ -779,7 +775,6 @@ static int __devinit ds2780_battery_probe(struct platform_device *pdev)
         dev_info->bat.properties        = ds2780_battery_props;
         dev_info->bat.num_properties    = ARRAY_SIZE(ds2780_battery_props);
         dev_info->bat.get_property      = ds2780_battery_get_property;
-        dev_info->mutex_holder          = current;
 
         ret = power_supply_register(&pdev->dev, &dev_info->bat);
         if (ret) {
@@ -809,8 +804,6 @@ static int __devinit ds2780_battery_probe(struct platform_device *pdev)
                 goto fail_remove_bin_file;
         }
 
-        dev_info->mutex_holder = NULL;
-
         return 0;
 
 fail_remove_bin_file:
@@ -830,8 +823,6 @@ static int __devexit ds2780_battery_remove(struct platform_device *pdev)
 {
         struct ds2780_device_info *dev_info = platform_get_drvdata(pdev);
 
-        dev_info->mutex_holder = current;
-
         /* remove attributes */
         sysfs_remove_group(&dev_info->bat.dev->kobj, &ds2780_attr_group);
 
diff --git a/drivers/power/ds2781_battery.c b/drivers/power/ds2781_battery.c
index 975684a40f15..5f92a4bb33f9 100644
--- a/drivers/power/ds2781_battery.c
+++ b/drivers/power/ds2781_battery.c
@@ -37,7 +37,6 @@ struct ds2781_device_info {
         struct device *dev;
         struct power_supply bat;
         struct device *w1_dev;
-        struct task_struct *mutex_holder;
 };
 
 enum current_types {
@@ -62,11 +61,7 @@ static inline struct power_supply *to_power_supply(struct device *dev)
 static inline int ds2781_battery_io(struct ds2781_device_info *dev_info,
         char *buf, int addr, size_t count, int io)
 {
-        if (dev_info->mutex_holder == current)
-                return w1_ds2781_io_nolock(dev_info->w1_dev, buf, addr,
-                                count, io);
-        else
-                return w1_ds2781_io(dev_info->w1_dev, buf, addr, count, io);
+        return w1_ds2781_io(dev_info->w1_dev, buf, addr, count, io);
 }
 
 int w1_ds2781_read(struct ds2781_device_info *dev_info, char *buf,
@@ -775,7 +770,6 @@ static int __devinit ds2781_battery_probe(struct platform_device *pdev)
         dev_info->bat.properties        = ds2781_battery_props;
         dev_info->bat.num_properties    = ARRAY_SIZE(ds2781_battery_props);
         dev_info->bat.get_property      = ds2781_battery_get_property;
-        dev_info->mutex_holder          = current;
 
         ret = power_supply_register(&pdev->dev, &dev_info->bat);
         if (ret) {
@@ -805,8 +799,6 @@ static int __devinit ds2781_battery_probe(struct platform_device *pdev)
                 goto fail_remove_bin_file;
         }
 
-        dev_info->mutex_holder = NULL;
-
         return 0;
 
 fail_remove_bin_file:
@@ -826,8 +818,6 @@ static int __devexit ds2781_battery_remove(struct platform_device *pdev)
 {
         struct ds2781_device_info *dev_info = platform_get_drvdata(pdev);
 
-        dev_info->mutex_holder = current;
-
         /* remove attributes */
         sysfs_remove_group(&dev_info->bat.dev->kobj, &ds2781_attr_group);