diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2010-11-11 13:00:52 -0500 |
---|---|---|
committer | Anton Vorontsov <cbouatmailru@gmail.com> | 2010-11-18 08:56:16 -0500 |
commit | 8ec98fe0b4ffdedce4c1caa9fb3d550f52ad1c6b (patch) | |
tree | af77279c42d3c1e9e21676b1d28ca8ec1c043c73 /drivers/power | |
parent | 86af95039b69a90db15294eb1f9c147f1df0a8ea (diff) |
jz4740-battery: Protect against concurrent battery readings
We can not handle more then one ADC request at a time to the battery.
The patch adds a mutex around the ADC read code to ensure this.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: stable@kernel.org
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Diffstat (limited to 'drivers/power')
-rw-r--r-- | drivers/power/jz4740-battery.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c index a8108a73593e..2bbe04ae13a7 100644 --- a/drivers/power/jz4740-battery.c +++ b/drivers/power/jz4740-battery.c | |||
@@ -47,6 +47,8 @@ struct jz_battery { | |||
47 | 47 | ||
48 | struct power_supply battery; | 48 | struct power_supply battery; |
49 | struct delayed_work work; | 49 | struct delayed_work work; |
50 | |||
51 | struct mutex lock; | ||
50 | }; | 52 | }; |
51 | 53 | ||
52 | static inline struct jz_battery *psy_to_jz_battery(struct power_supply *psy) | 54 | static inline struct jz_battery *psy_to_jz_battery(struct power_supply *psy) |
@@ -68,6 +70,8 @@ static long jz_battery_read_voltage(struct jz_battery *battery) | |||
68 | unsigned long val; | 70 | unsigned long val; |
69 | long voltage; | 71 | long voltage; |
70 | 72 | ||
73 | mutex_lock(&battery->lock); | ||
74 | |||
71 | INIT_COMPLETION(battery->read_completion); | 75 | INIT_COMPLETION(battery->read_completion); |
72 | 76 | ||
73 | enable_irq(battery->irq); | 77 | enable_irq(battery->irq); |
@@ -91,6 +95,8 @@ static long jz_battery_read_voltage(struct jz_battery *battery) | |||
91 | battery->cell->disable(battery->pdev); | 95 | battery->cell->disable(battery->pdev); |
92 | disable_irq(battery->irq); | 96 | disable_irq(battery->irq); |
93 | 97 | ||
98 | mutex_unlock(&battery->lock); | ||
99 | |||
94 | return voltage; | 100 | return voltage; |
95 | } | 101 | } |
96 | 102 | ||
@@ -291,6 +297,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev) | |||
291 | jz_battery->pdev = pdev; | 297 | jz_battery->pdev = pdev; |
292 | 298 | ||
293 | init_completion(&jz_battery->read_completion); | 299 | init_completion(&jz_battery->read_completion); |
300 | mutex_init(&jz_battery->lock); | ||
294 | 301 | ||
295 | INIT_DELAYED_WORK(&jz_battery->work, jz_battery_work); | 302 | INIT_DELAYED_WORK(&jz_battery->work, jz_battery_work); |
296 | 303 | ||