usb: phy: fix return value check of usb_get_phy

usb_get_phy will return -ENODEV if it's not able to find the phy. Hence
fixed all the callers of usb_get_phy to check for this error condition
instead of relying on a non-zero value as success condition.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

1 files changed, 8 insertions, 8 deletions

diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
index 7602d49e4d81..8dbcd53c5e67 100644
--- a/drivers/power/pda_power.c
+++ b/drivers/power/pda_power.c
@@ -322,11 +322,11 @@ static int pda_power_probe(struct platform_device *pdev)
 
 #ifdef CONFIG_USB_OTG_UTILS
         transceiver = usb_get_phy(USB_PHY_TYPE_USB2);
-        if (transceiver && !pdata->is_usb_online) {
-                pdata->is_usb_online = otg_is_usb_online;
-        }
-        if (transceiver && !pdata->is_ac_online) {
-                pdata->is_ac_online = otg_is_ac_online;
+        if (!IS_ERR_OR_NULL(transceiver)) {
+                if (!pdata->is_usb_online)
+                        pdata->is_usb_online = otg_is_usb_online;
+                if (!pdata->is_ac_online)
+                        pdata->is_ac_online = otg_is_ac_online;
         }
 #endif
 
@@ -373,7 +373,7 @@ static int pda_power_probe(struct platform_device *pdev)
         }
 
 #ifdef CONFIG_USB_OTG_UTILS
-        if (transceiver && pdata->use_otg_notifier) {
+        if (!IS_ERR_OR_NULL(transceiver) && pdata->use_otg_notifier) {
                 otg_nb.notifier_call = otg_handle_notification;
                 ret = usb_register_notifier(transceiver, &otg_nb);
                 if (ret) {
@@ -408,7 +408,7 @@ usb_supply_failed:
         if (pdata->is_ac_online && ac_irq)
                 free_irq(ac_irq->start, &pda_psy_ac);
 #ifdef CONFIG_USB_OTG_UTILS
-        if (transceiver)
+        if (!IS_ERR_OR_NULL(transceiver))
                 usb_put_phy(transceiver);
 #endif
 ac_irq_failed:
@@ -443,7 +443,7 @@ static int pda_power_remove(struct platform_device *pdev)
         if (pdata->is_ac_online)
                 power_supply_unregister(&pda_psy_ac);
 #ifdef CONFIG_USB_OTG_UTILS
-        if (transceiver)
+        if (!IS_ERR_OR_NULL(transceiver))
                 usb_put_phy(transceiver);
 #endif
         if (ac_draw) {