diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/platform | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/platform')
-rw-r--r-- | drivers/platform/x86/compal-laptop.c | 2 | ||||
-rw-r--r-- | drivers/platform/x86/intel_oaktrail.c | 2 | ||||
-rw-r--r-- | drivers/platform/x86/msi-laptop.c | 2 | ||||
-rw-r--r-- | drivers/platform/x86/samsung-laptop.c | 4 | ||||
-rw-r--r-- | drivers/platform/x86/thinkpad_acpi.c | 16 | ||||
-rw-r--r-- | drivers/platform/x86/wmi.c | 4 |
6 files changed, 15 insertions, 15 deletions
diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c index 8877b836d27c..d96734478324 100644 --- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c | |||
@@ -189,7 +189,7 @@ struct compal_data{ | |||
189 | /* =============== */ | 189 | /* =============== */ |
190 | /* General globals */ | 190 | /* General globals */ |
191 | /* =============== */ | 191 | /* =============== */ |
192 | static int force; | 192 | static bool force; |
193 | module_param(force, bool, 0); | 193 | module_param(force, bool, 0); |
194 | MODULE_PARM_DESC(force, "Force driver load, ignore DMI data"); | 194 | MODULE_PARM_DESC(force, "Force driver load, ignore DMI data"); |
195 | 195 | ||
diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c index 7f88c7923fc6..6ee0b5c90933 100644 --- a/drivers/platform/x86/intel_oaktrail.c +++ b/drivers/platform/x86/intel_oaktrail.c | |||
@@ -95,7 +95,7 @@ | |||
95 | #define OT_EC_BL_CONTROL_ON_DATA 0x1A | 95 | #define OT_EC_BL_CONTROL_ON_DATA 0x1A |
96 | 96 | ||
97 | 97 | ||
98 | static int force; | 98 | static bool force; |
99 | module_param(force, bool, 0); | 99 | module_param(force, bool, 0); |
100 | MODULE_PARM_DESC(force, "Force driver load, ignore DMI data"); | 100 | MODULE_PARM_DESC(force, "Force driver load, ignore DMI data"); |
101 | 101 | ||
diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c index f204643c5052..bb5132128b33 100644 --- a/drivers/platform/x86/msi-laptop.c +++ b/drivers/platform/x86/msi-laptop.c | |||
@@ -89,7 +89,7 @@ static int msi_laptop_resume(struct platform_device *device); | |||
89 | 89 | ||
90 | #define MSI_STANDARD_EC_DEVICES_EXISTS_ADDRESS 0x2f | 90 | #define MSI_STANDARD_EC_DEVICES_EXISTS_ADDRESS 0x2f |
91 | 91 | ||
92 | static int force; | 92 | static bool force; |
93 | module_param(force, bool, 0); | 93 | module_param(force, bool, 0); |
94 | MODULE_PARM_DESC(force, "Force driver load, ignore DMI data"); | 94 | MODULE_PARM_DESC(force, "Force driver load, ignore DMI data"); |
95 | 95 | ||
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index 09e26bfd4643..fd73ea89b857 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c | |||
@@ -228,12 +228,12 @@ static struct platform_device *sdev; | |||
228 | static struct rfkill *rfk; | 228 | static struct rfkill *rfk; |
229 | static bool has_stepping_quirk; | 229 | static bool has_stepping_quirk; |
230 | 230 | ||
231 | static int force; | 231 | static bool force; |
232 | module_param(force, bool, 0); | 232 | module_param(force, bool, 0); |
233 | MODULE_PARM_DESC(force, | 233 | MODULE_PARM_DESC(force, |
234 | "Disable the DMI check and forces the driver to be loaded"); | 234 | "Disable the DMI check and forces the driver to be loaded"); |
235 | 235 | ||
236 | static int debug; | 236 | static bool debug; |
237 | module_param(debug, bool, S_IRUGO | S_IWUSR); | 237 | module_param(debug, bool, S_IRUGO | S_IWUSR); |
238 | MODULE_PARM_DESC(debug, "Debug enabled or not"); | 238 | MODULE_PARM_DESC(debug, "Debug enabled or not"); |
239 | 239 | ||
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 62533c105da4..ea0c6075b720 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c | |||
@@ -378,13 +378,13 @@ static unsigned int bright_maxlvl; /* 0 = unknown */ | |||
378 | 378 | ||
379 | #ifdef CONFIG_THINKPAD_ACPI_DEBUGFACILITIES | 379 | #ifdef CONFIG_THINKPAD_ACPI_DEBUGFACILITIES |
380 | static int dbg_wlswemul; | 380 | static int dbg_wlswemul; |
381 | static int tpacpi_wlsw_emulstate; | 381 | static bool tpacpi_wlsw_emulstate; |
382 | static int dbg_bluetoothemul; | 382 | static int dbg_bluetoothemul; |
383 | static int tpacpi_bluetooth_emulstate; | 383 | static bool tpacpi_bluetooth_emulstate; |
384 | static int dbg_wwanemul; | 384 | static int dbg_wwanemul; |
385 | static int tpacpi_wwan_emulstate; | 385 | static bool tpacpi_wwan_emulstate; |
386 | static int dbg_uwbemul; | 386 | static int dbg_uwbemul; |
387 | static int tpacpi_uwb_emulstate; | 387 | static bool tpacpi_uwb_emulstate; |
388 | #endif | 388 | #endif |
389 | 389 | ||
390 | 390 | ||
@@ -6444,7 +6444,7 @@ static struct ibm_struct brightness_driver_data = { | |||
6444 | 6444 | ||
6445 | static int alsa_index = ~((1 << (SNDRV_CARDS - 3)) - 1); /* last three slots */ | 6445 | static int alsa_index = ~((1 << (SNDRV_CARDS - 3)) - 1); /* last three slots */ |
6446 | static char *alsa_id = "ThinkPadEC"; | 6446 | static char *alsa_id = "ThinkPadEC"; |
6447 | static int alsa_enable = SNDRV_DEFAULT_ENABLE1; | 6447 | static bool alsa_enable = SNDRV_DEFAULT_ENABLE1; |
6448 | 6448 | ||
6449 | struct tpacpi_alsa_data { | 6449 | struct tpacpi_alsa_data { |
6450 | struct snd_card *card; | 6450 | struct snd_card *card; |
@@ -6487,7 +6487,7 @@ static enum tpacpi_volume_access_mode volume_mode = | |||
6487 | TPACPI_VOL_MODE_MAX; | 6487 | TPACPI_VOL_MODE_MAX; |
6488 | 6488 | ||
6489 | static enum tpacpi_volume_capabilities volume_capabilities; | 6489 | static enum tpacpi_volume_capabilities volume_capabilities; |
6490 | static int volume_control_allowed; | 6490 | static bool volume_control_allowed; |
6491 | 6491 | ||
6492 | /* | 6492 | /* |
6493 | * Used to syncronize writers to TP_EC_AUDIO and | 6493 | * Used to syncronize writers to TP_EC_AUDIO and |
@@ -7265,7 +7265,7 @@ enum fan_control_commands { | |||
7265 | * and also watchdog cmd */ | 7265 | * and also watchdog cmd */ |
7266 | }; | 7266 | }; |
7267 | 7267 | ||
7268 | static int fan_control_allowed; | 7268 | static bool fan_control_allowed; |
7269 | 7269 | ||
7270 | static enum fan_status_access_mode fan_status_access_mode; | 7270 | static enum fan_status_access_mode fan_status_access_mode; |
7271 | static enum fan_control_access_mode fan_control_access_mode; | 7271 | static enum fan_control_access_mode fan_control_access_mode; |
@@ -8437,7 +8437,7 @@ static struct proc_dir_entry *proc_dir; | |||
8437 | * Module and infrastructure proble, init and exit handling | 8437 | * Module and infrastructure proble, init and exit handling |
8438 | */ | 8438 | */ |
8439 | 8439 | ||
8440 | static int force_load; | 8440 | static bool force_load; |
8441 | 8441 | ||
8442 | #ifdef CONFIG_THINKPAD_ACPI_DEBUG | 8442 | #ifdef CONFIG_THINKPAD_ACPI_DEBUG |
8443 | static const char * __init str_supported(int is_supported) | 8443 | static const char * __init str_supported(int is_supported) |
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index a134c26870b0..42a4dcc25f92 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c | |||
@@ -82,12 +82,12 @@ struct wmi_block { | |||
82 | #define ACPI_WMI_STRING 0x4 /* GUID takes & returns a string */ | 82 | #define ACPI_WMI_STRING 0x4 /* GUID takes & returns a string */ |
83 | #define ACPI_WMI_EVENT 0x8 /* GUID is an event */ | 83 | #define ACPI_WMI_EVENT 0x8 /* GUID is an event */ |
84 | 84 | ||
85 | static int debug_event; | 85 | static bool debug_event; |
86 | module_param(debug_event, bool, 0444); | 86 | module_param(debug_event, bool, 0444); |
87 | MODULE_PARM_DESC(debug_event, | 87 | MODULE_PARM_DESC(debug_event, |
88 | "Log WMI Events [0/1]"); | 88 | "Log WMI Events [0/1]"); |
89 | 89 | ||
90 | static int debug_dump_wdg; | 90 | static bool debug_dump_wdg; |
91 | module_param(debug_dump_wdg, bool, 0444); | 91 | module_param(debug_dump_wdg, bool, 0444); |
92 | MODULE_PARM_DESC(debug_dump_wdg, | 92 | MODULE_PARM_DESC(debug_dump_wdg, |
93 | "Dump available WMI interfaces [0/1]"); | 93 | "Dump available WMI interfaces [0/1]"); |