diff options
author | Stephen Boyd <sboyd@codeaurora.org> | 2014-03-07 01:44:41 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2014-03-12 10:12:27 -0400 |
commit | dcd278b8604e5c37c61853eb09134cbfea03b7de (patch) | |
tree | d54071ad856f50e8e9c7fa7ff12b2a8cbb8af0ea /drivers/pinctrl | |
parent | 3525f5556a1b9e15cb1b796771f2c62deed7aa7a (diff) |
pinctrl: msm: Check for ngpios > MAX_NR_GPIO
Fail the probe and print a warning if SoC specific drivers have
more GPIOs than there can be accounted for in the static bitmaps.
This should avoid silent corruption/failures in the future.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r-- | drivers/pinctrl/pinctrl-msm.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c index 2df3a48974f3..e563bbc5cefc 100644 --- a/drivers/pinctrl/pinctrl-msm.c +++ b/drivers/pinctrl/pinctrl-msm.c | |||
@@ -897,10 +897,14 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) | |||
897 | int ret; | 897 | int ret; |
898 | int i; | 898 | int i; |
899 | int r; | 899 | int r; |
900 | unsigned ngpio = pctrl->soc->ngpios; | ||
901 | |||
902 | if (WARN_ON(ngpio > MAX_NR_GPIO)) | ||
903 | return -EINVAL; | ||
900 | 904 | ||
901 | chip = &pctrl->chip; | 905 | chip = &pctrl->chip; |
902 | chip->base = 0; | 906 | chip->base = 0; |
903 | chip->ngpio = pctrl->soc->ngpios; | 907 | chip->ngpio = ngpio; |
904 | chip->label = dev_name(pctrl->dev); | 908 | chip->label = dev_name(pctrl->dev); |
905 | chip->dev = pctrl->dev; | 909 | chip->dev = pctrl->dev; |
906 | chip->owner = THIS_MODULE; | 910 | chip->owner = THIS_MODULE; |