diff options
author | Lee Jones <lee.jones@linaro.org> | 2013-05-08 09:29:07 -0400 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2013-05-14 04:34:55 -0400 |
commit | 2fcad12eb4d80b174c69bfbc34d1c094ad37e1bd (patch) | |
tree | 6270d520607cde83b93dcee755cb32fb66c434af /drivers/pinctrl | |
parent | f722406faae2d073cc1d01063d1123c35425939e (diff) |
pinctrl: abx500: Specify failed sub-driver by ID instead of driver_data
If a sub-driver has not been specified correctly, there is a good chance
that plat_id is NULL, hence using an attribute of plat_id in the error
message is likely to not only fail the driver but Oops the kernel. Use
the failed ID instead.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r-- | drivers/pinctrl/pinctrl-abx500.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c index aa17f7580f61..2a2a9df90bba 100644 --- a/drivers/pinctrl/pinctrl-abx500.c +++ b/drivers/pinctrl/pinctrl-abx500.c | |||
@@ -900,8 +900,7 @@ static int abx500_gpio_probe(struct platform_device *pdev) | |||
900 | abx500_pinctrl_ab8505_init(&pct->soc); | 900 | abx500_pinctrl_ab8505_init(&pct->soc); |
901 | break; | 901 | break; |
902 | default: | 902 | default: |
903 | dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n", | 903 | dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n", id); |
904 | (int) platid->driver_data); | ||
905 | mutex_destroy(&pct->lock); | 904 | mutex_destroy(&pct->lock); |
906 | return -EINVAL; | 905 | return -EINVAL; |
907 | } | 906 | } |