pinctrl: Pass all configs to driver on pin_config_set()

When setting pin configuration in the pinctrl framework, pin_config_set() or
pin_config_group_set() is called in a loop to set one configuration at a time
for the specified pin or group.

This patch 1) removes the loop and 2) changes the API to pass the whole pin
config array to the driver.  It is now up to the driver to loop through the
configs.  This allows the driver to potentially combine configs and reduce the
number of writes to pin config registers.

All c files changed have been build-tested to verify the change compiles and
that the corresponding .o is successfully generated.

Signed-off-by: Sherman Yin <syin@broadcom.com>
Reviewed-by: Christian Daudt <csd@broadcom.com>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

1 files changed, 13 insertions, 4 deletions

diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 439f2ef680df..222648d69f25 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -442,9 +442,17 @@ static int samsung_pinconf_rw(struct pinctrl_dev *pctldev, unsigned int pin,
 
 /* set the pin config settings for a specified pin */
 static int samsung_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
-                                unsigned long config)
+                                unsigned long *configs, unsigned num_configs)
 {
-        return samsung_pinconf_rw(pctldev, pin, &config, true);
+        int i, ret;
+
+        for (i = 0; i < num_configs; i++) {
+                ret = samsung_pinconf_rw(pctldev, pin, &configs[i], true);
+                if (ret < 0)
+                        return ret;
+        } /* for each config */
+
+        return 0;
 }
 
 /* get the pin config settings for a specified pin */
@@ -456,7 +464,8 @@ static int samsung_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
 
 /* set the pin config settings for a specified pin group */
 static int samsung_pinconf_group_set(struct pinctrl_dev *pctldev,
-                        unsigned group, unsigned long config)
+                        unsigned group, unsigned long *configs,
+                        unsigned num_configs)
 {
         struct samsung_pinctrl_drv_data *drvdata;
         const unsigned int *pins;
@@ -466,7 +475,7 @@ static int samsung_pinconf_group_set(struct pinctrl_dev *pctldev,
         pins = drvdata->pin_groups[group].pins;
 
         for (cnt = 0; cnt < drvdata->pin_groups[group].num_pins; cnt++)
-                samsung_pinconf_set(pctldev, pins[cnt], config);
+                samsung_pinconf_set(pctldev, pins[cnt], configs, num_configs);
 
         return 0;
 }