pinctrl: Pass all configs to driver on pin_config_set()

When setting pin configuration in the pinctrl framework, pin_config_set() or
pin_config_group_set() is called in a loop to set one configuration at a time
for the specified pin or group.

This patch 1) removes the loop and 2) changes the API to pass the whole pin
config array to the driver.  It is now up to the driver to loop through the
configs.  This allows the driver to potentially combine configs and reduce the
number of writes to pin config registers.

All c files changed have been build-tested to verify the change compiles and
that the corresponding .o is successfully generated.

Signed-off-by: Sherman Yin <syin@broadcom.com>
Reviewed-by: Christian Daudt <csd@broadcom.com>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

1 files changed, 19 insertions, 23 deletions

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 8da2d6db228c..a138965c01cb 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -158,7 +158,7 @@ int pinconf_apply_setting(struct pinctrl_setting const *setting)
 {
         struct pinctrl_dev *pctldev = setting->pctldev;
         const struct pinconf_ops *ops = pctldev->desc->confops;
-        int i, ret;
+        int ret;
 
         if (!ops) {
                 dev_err(pctldev->dev, "missing confops\n");
@@ -171,17 +171,15 @@ int pinconf_apply_setting(struct pinctrl_setting const *setting)
                         dev_err(pctldev->dev, "missing pin_config_set op\n");
                         return -EINVAL;
                 }
-                for (i = 0; i < setting->data.configs.num_configs; i++) {
-                        ret = ops->pin_config_set(pctldev,
-                                        setting->data.configs.group_or_pin,
-                                        setting->data.configs.configs[i]);
-                        if (ret < 0) {
-                                dev_err(pctldev->dev,
-                                        "pin_config_set op failed for pin %d config %08lx\n",
-                                        setting->data.configs.group_or_pin,
-                                        setting->data.configs.configs[i]);
-                                return ret;
-                        }
+                ret = ops->pin_config_set(pctldev,
+                                setting->data.configs.group_or_pin,
+                                setting->data.configs.configs,
+                                setting->data.configs.num_configs);
+                if (ret < 0) {
+                        dev_err(pctldev->dev,
+                                "pin_config_set op failed for pin %d\n",
+                                setting->data.configs.group_or_pin);
+                        return ret;
                 }
                 break;
         case PIN_MAP_TYPE_CONFIGS_GROUP:
@@ -190,17 +188,15 @@ int pinconf_apply_setting(struct pinctrl_setting const *setting)
                                 "missing pin_config_group_set op\n");
                         return -EINVAL;
                 }
-                for (i = 0; i < setting->data.configs.num_configs; i++) {
-                        ret = ops->pin_config_group_set(pctldev,
-                                        setting->data.configs.group_or_pin,
-                                        setting->data.configs.configs[i]);
-                        if (ret < 0) {
-                                dev_err(pctldev->dev,
-                                        "pin_config_group_set op failed for group %d config %08lx\n",
-                                        setting->data.configs.group_or_pin,
-                                        setting->data.configs.configs[i]);
-                                return ret;
-                        }
+                ret = ops->pin_config_group_set(pctldev,
+                                setting->data.configs.group_or_pin,
+                                setting->data.configs.configs,
+                                setting->data.configs.num_configs);
+                if (ret < 0) {
+                        dev_err(pctldev->dev,
+                                "pin_config_group_set op failed for group %d\n",
+                                setting->data.configs.group_or_pin);
+                        return ret;
                 }
                 break;
         default: