diff options
author | Julia Lawall <julia@diku.dk> | 2009-11-21 06:50:34 -0500 |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2009-11-22 07:03:50 -0500 |
commit | 78a14e273d93dfbea9673f9b10398c538096302d (patch) | |
tree | eed6850d3a9903e2cbbb1fda3392eb3e6949cbbf /drivers/pcmcia | |
parent | b285fab4185a9b3db953726f0dd9d343a6e389db (diff) |
drivers/pcmcia: remove unnecessary kzalloc
The result of calling kzalloc is never used or freed.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/pcmcia')
-rw-r--r-- | drivers/pcmcia/sa1111_generic.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/pcmcia/sa1111_generic.c b/drivers/pcmcia/sa1111_generic.c index deb5036ee5fb..de6bc333d299 100644 --- a/drivers/pcmcia/sa1111_generic.c +++ b/drivers/pcmcia/sa1111_generic.c | |||
@@ -127,10 +127,6 @@ int sa1111_pcmcia_add(struct sa1111_dev *dev, struct pcmcia_low_level *ops, | |||
127 | ops->socket_state = sa1111_pcmcia_socket_state; | 127 | ops->socket_state = sa1111_pcmcia_socket_state; |
128 | ops->socket_suspend = sa1111_pcmcia_socket_suspend; | 128 | ops->socket_suspend = sa1111_pcmcia_socket_suspend; |
129 | 129 | ||
130 | s = kzalloc(sizeof(*s) * ops->nr, GFP_KERNEL); | ||
131 | if (!s) | ||
132 | return -ENODEV; | ||
133 | |||
134 | for (i = 0; i < ops->nr; i++) { | 130 | for (i = 0; i < ops->nr; i++) { |
135 | s = kzalloc(sizeof(*s), GFP_KERNEL); | 131 | s = kzalloc(sizeof(*s), GFP_KERNEL); |
136 | if (!s) | 132 | if (!s) |