diff options
author | Dominik Brodowski <linux@dominikbrodowski.net> | 2008-08-31 09:50:33 -0400 |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2008-08-31 09:50:33 -0400 |
commit | 2f3061eb1086f98990d6495b8c63a1b83f2f59aa (patch) | |
tree | 01066412a16e05f459d405c2130ae98f95090d5f /drivers/pcmcia | |
parent | 994917f8b718f1cd7114317cc3cbf04fe46c1841 (diff) |
pcmcia: remove unused argument to pcmcia_parse_tuple()
Since we're just parsing the tuple being passed to this function, we don't
need any device-specific information.
Also, remove the call to pcmcia_validate_cis() from pcmciamtd.c, since it
is already called by the PCMCIA core.
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/pcmcia')
-rw-r--r-- | drivers/pcmcia/cistpl.c | 6 | ||||
-rw-r--r-- | drivers/pcmcia/cs_internal.h | 2 | ||||
-rw-r--r-- | drivers/pcmcia/pcmcia_ioctl.c | 2 | ||||
-rw-r--r-- | drivers/pcmcia/pcmcia_resource.c | 2 |
4 files changed, 7 insertions, 5 deletions
diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c index 772fc96d5ec3..dcce9f5d8465 100644 --- a/drivers/pcmcia/cistpl.c +++ b/drivers/pcmcia/cistpl.c | |||
@@ -1359,7 +1359,7 @@ static int parse_format(tuple_t *tuple, cistpl_format_t *fmt) | |||
1359 | 1359 | ||
1360 | /*====================================================================*/ | 1360 | /*====================================================================*/ |
1361 | 1361 | ||
1362 | int pccard_parse_tuple(tuple_t *tuple, cisparse_t *parse) | 1362 | int pcmcia_parse_tuple(tuple_t *tuple, cisparse_t *parse) |
1363 | { | 1363 | { |
1364 | int ret = 0; | 1364 | int ret = 0; |
1365 | 1365 | ||
@@ -1442,7 +1442,7 @@ int pccard_parse_tuple(tuple_t *tuple, cisparse_t *parse) | |||
1442 | __cs_dbg(0, "parse_tuple failed %d\n", ret); | 1442 | __cs_dbg(0, "parse_tuple failed %d\n", ret); |
1443 | return ret; | 1443 | return ret; |
1444 | } | 1444 | } |
1445 | EXPORT_SYMBOL(pccard_parse_tuple); | 1445 | EXPORT_SYMBOL(pcmcia_parse_tuple); |
1446 | 1446 | ||
1447 | /*====================================================================== | 1447 | /*====================================================================== |
1448 | 1448 | ||
@@ -1472,7 +1472,7 @@ int pccard_read_tuple(struct pcmcia_socket *s, unsigned int function, cisdata_t | |||
1472 | ret = pccard_get_tuple_data(s, &tuple); | 1472 | ret = pccard_get_tuple_data(s, &tuple); |
1473 | if (ret != 0) | 1473 | if (ret != 0) |
1474 | goto done; | 1474 | goto done; |
1475 | ret = pccard_parse_tuple(&tuple, parse); | 1475 | ret = pcmcia_parse_tuple(&tuple, parse); |
1476 | done: | 1476 | done: |
1477 | kfree(buf); | 1477 | kfree(buf); |
1478 | return ret; | 1478 | return ret; |
diff --git a/drivers/pcmcia/cs_internal.h b/drivers/pcmcia/cs_internal.h index d71eeee4992b..79615e6d540b 100644 --- a/drivers/pcmcia/cs_internal.h +++ b/drivers/pcmcia/cs_internal.h | |||
@@ -197,6 +197,8 @@ int pccard_read_tuple(struct pcmcia_socket *s, unsigned int function, | |||
197 | cisdata_t code, void *parse); | 197 | cisdata_t code, void *parse); |
198 | int pcmcia_replace_cis(struct pcmcia_socket *s, | 198 | int pcmcia_replace_cis(struct pcmcia_socket *s, |
199 | const u8 *data, const size_t len); | 199 | const u8 *data, const size_t len); |
200 | int pccard_validate_cis(struct pcmcia_socket *s, unsigned int function, | ||
201 | unsigned int *count); | ||
200 | 202 | ||
201 | /* rsrc_mgr.c */ | 203 | /* rsrc_mgr.c */ |
202 | int pcmcia_validate_mem(struct pcmcia_socket *s); | 204 | int pcmcia_validate_mem(struct pcmcia_socket *s); |
diff --git a/drivers/pcmcia/pcmcia_ioctl.c b/drivers/pcmcia/pcmcia_ioctl.c index 579ec9455706..1703b20cad5d 100644 --- a/drivers/pcmcia/pcmcia_ioctl.c +++ b/drivers/pcmcia/pcmcia_ioctl.c | |||
@@ -858,7 +858,7 @@ static int ds_ioctl(struct inode * inode, struct file * file, | |||
858 | break; | 858 | break; |
859 | case DS_PARSE_TUPLE: | 859 | case DS_PARSE_TUPLE: |
860 | buf->tuple.TupleData = buf->tuple_parse.data; | 860 | buf->tuple.TupleData = buf->tuple_parse.data; |
861 | ret = pccard_parse_tuple(&buf->tuple, &buf->tuple_parse.parse); | 861 | ret = pcmcia_parse_tuple(&buf->tuple, &buf->tuple_parse.parse); |
862 | break; | 862 | break; |
863 | case DS_RESET_CARD: | 863 | case DS_RESET_CARD: |
864 | ret = pcmcia_reset_card(s); | 864 | ret = pcmcia_reset_card(s); |
diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c index 93a270e15cea..afea2b2558b5 100644 --- a/drivers/pcmcia/pcmcia_resource.c +++ b/drivers/pcmcia/pcmcia_resource.c | |||
@@ -937,7 +937,7 @@ int pcmcia_loop_config(struct pcmcia_device *p_dev, | |||
937 | if (pcmcia_get_tuple_data(p_dev, tuple)) | 937 | if (pcmcia_get_tuple_data(p_dev, tuple)) |
938 | goto next_entry; | 938 | goto next_entry; |
939 | 939 | ||
940 | if (pcmcia_parse_tuple(p_dev, tuple, &cfg_mem->parse)) | 940 | if (pcmcia_parse_tuple(tuple, &cfg_mem->parse)) |
941 | goto next_entry; | 941 | goto next_entry; |
942 | 942 | ||
943 | /* default values */ | 943 | /* default values */ |