pcmcia: deprecate CS_OUT_OF_RESOURCE

CS_OUT_OF_RESOURCE was almost only used to note -ENOMEM situations.
Therefore, use -ENOMEM explicitely, and also print out warnings.

CC: netdev@vger.kernel.org
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

3 files changed, 47 insertions, 30 deletions

diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
index 1a513d9a8612..8d37768d0b46 100644
--- a/drivers/pcmcia/cistpl.c
+++ b/drivers/pcmcia/cistpl.c
@@ -352,7 +352,9 @@ int verify_cis_cache(struct pcmcia_socket *s)
 
         buf = kmalloc(256, GFP_KERNEL);
         if (buf == NULL)
-                return -1;
+                dev_printk(KERN_WARNING, &s->dev,
+                           "no memory for verifying CIS\n");
+                return -ENOMEM;
         list_for_each_entry(cis, &s->cis_cache, node) {
                 int len = cis->len;
 
@@ -384,15 +386,19 @@ int verify_cis_cache(struct pcmcia_socket *s)
 int pcmcia_replace_cis(struct pcmcia_socket *s,
                        const u8 *data, const size_t len)
 {
-    if (len > CISTPL_MAX_CIS_SIZE)
-        return CS_BAD_SIZE;
-    kfree(s->fake_cis);
-    s->fake_cis = kmalloc(len, GFP_KERNEL);
-    if (s->fake_cis == NULL)
-        return CS_OUT_OF_RESOURCE;
-    s->fake_cis_len = len;
-    memcpy(s->fake_cis, data, len);
-    return 0;
+        if (len > CISTPL_MAX_CIS_SIZE) {
+                dev_printk(KERN_WARNING, &s->dev, "replacement CIS too big\n");
+                return -EINVAL;
+        }
+        kfree(s->fake_cis);
+        s->fake_cis = kmalloc(len, GFP_KERNEL);
+        if (s->fake_cis == NULL) {
+                dev_printk(KERN_WARNING, &s->dev, "no memory to replace CIS\n");
+                return -ENOMEM;
+        }
+        s->fake_cis_len = len;
+        memcpy(s->fake_cis, data, len);
+        return 0;
 }
 EXPORT_SYMBOL(pcmcia_replace_cis);
 
@@ -1411,8 +1417,10 @@ int pccard_read_tuple(struct pcmcia_socket *s, unsigned int function, cisdata_t
     int ret;
 
     buf = kmalloc(256, GFP_KERNEL);
-    if (buf == NULL)
-        return CS_OUT_OF_RESOURCE;
+    if (buf == NULL) {
+            dev_printk(KERN_WARNING, &s->dev, "no memory to read tuple\n");
+            return -ENOMEM;
+    }
     tuple.DesiredTuple = code;
     tuple.Attributes = TUPLE_RETURN_COMMON;
     ret = pccard_get_first_tuple(s, function, &tuple);
@@ -1452,12 +1460,15 @@ int pccard_validate_cis(struct pcmcia_socket *s, unsigned int function, unsigned
         return CS_BAD_HANDLE;
 
     tuple = kmalloc(sizeof(*tuple), GFP_KERNEL);
-    if (tuple == NULL)
-        return CS_OUT_OF_RESOURCE;
+    if (tuple == NULL) {
+            dev_printk(KERN_WARNING, &s->dev, "no memory to validate CIS\n");
+            return -ENOMEM;
+    }
     p = kmalloc(sizeof(*p), GFP_KERNEL);
     if (p == NULL) {
-        kfree(tuple);
-        return CS_OUT_OF_RESOURCE;
+            kfree(tuple);
+            dev_printk(KERN_WARNING, &s->dev, "no memory to validate CIS\n");
+            return -ENOMEM;
     }
 
     count = reserved = 0;
diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index 48e168e8165b..69d87a7e0766 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -780,7 +780,7 @@ int pcmcia_request_window(struct pcmcia_device **p_dev, win_req_t *req, window_h
         for (w = 0; w < MAX_WIN; w++)
                 if (!(s->state & SOCKET_WIN_REQ(w))) break;
         if (w == MAX_WIN)
-                return CS_OUT_OF_RESOURCE;
+                return CS_IN_USE;
 
         win = &s->win[w];
         win->magic = WINDOW_MAGIC;
diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c
index 9d04fb214ec2..0e4141bac7b1 100644
--- a/drivers/pcmcia/rsrc_nonstatic.c
+++ b/drivers/pcmcia/rsrc_nonstatic.c
@@ -122,19 +122,22 @@ static void free_region(struct resource *res)
 
 static int add_interval(struct resource_map *map, u_long base, u_long num)
 {
-    struct resource_map *p, *q;
+        struct resource_map *p, *q;
 
-    for (p = map; ; p = p->next) {
-        if ((p != map) && (p->base+p->num-1 >= base))
-            return -1;
-        if ((p->next == map) || (p->next->base > base+num-1))
-            break;
-    }
-    q = kmalloc(sizeof(struct resource_map), GFP_KERNEL);
-    if (!q) return CS_OUT_OF_RESOURCE;
-    q->base = base; q->num = num;
-    q->next = p->next; p->next = q;
-    return 0;
+        for (p = map; ; p = p->next) {
+                if ((p != map) && (p->base+p->num-1 >= base))
+                        return -1;
+                if ((p->next == map) || (p->next->base > base+num-1))
+                        break;
+        }
+        q = kmalloc(sizeof(struct resource_map), GFP_KERNEL);
+        if (!q) {
+                printk(KERN_WARNING "out of memory to update resources\n");
+                return -ENOMEM;
+        }
+        q->base = base; q->num = num;
+        q->next = p->next; p->next = q;
+        return 0;
 }
 
 /*====================================================================*/
@@ -166,7 +169,10 @@ static int sub_interval(struct resource_map *map, u_long base, u_long num)
             } else {
                 /* Split the block into two pieces */
                 p = kmalloc(sizeof(struct resource_map), GFP_KERNEL);
-                if (!p) return CS_OUT_OF_RESOURCE;
+                if (!p) {
+                    printk(KERN_WARNING "out of memory to update resources\n");
+                    return -ENOMEM;
+                }
                 p->base = base+num;
                 p->num = q->base+q->num - p->base;
                 q->num = base - q->base;