diff options
author | Magnus Damm <damm@opensource.se> | 2006-12-13 05:46:53 -0500 |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2009-11-28 12:02:50 -0500 |
commit | 0bdf9b3dd3cfa5cbd5d55172c19f5dd166208e17 (patch) | |
tree | a7af14eb0601a443343240cbb11d7693db9de352 /drivers/pcmcia/cs_internal.h | |
parent | 16456ebabfec3f8f509fc18b45f256d066a1b360 (diff) |
pcmcia: Change window_handle_t logic to unsigned long
Logic changes based on top of the other patches:
This set of patches changed window_handle_t from being a pointer to an
unsigned long. The unsigned long is now a simple index into socket->win[].
Going from a pointer to unsigned long should leave the user space interface
unchanged unless I'm mistaken.
This change results in code that is less error prone and a user space
interface which is much cleaner and safer. A nice side effect is that we
are also are able to remove all members except one from window_t.
[ linux@dominikbrodowski.net:
Update to 2.6.31. Also, a plain "index" to socket->win[] does not
work, as several codepaths rely on "window_handle_t" being
non-zero if used. Therefore, set the window_handle_t to the
socket->win[] index + 1. ]
CC: netdev@vger.kernel.org
Signed-off-by: Magnus Damm <damm@opensource.se>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/pcmcia/cs_internal.h')
-rw-r--r-- | drivers/pcmcia/cs_internal.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pcmcia/cs_internal.h b/drivers/pcmcia/cs_internal.h index 8e09a4998c84..6df41de39d16 100644 --- a/drivers/pcmcia/cs_internal.h +++ b/drivers/pcmcia/cs_internal.h | |||
@@ -149,8 +149,8 @@ extern struct list_head pcmcia_socket_list; | |||
149 | extern struct class pcmcia_socket_class; | 149 | extern struct class pcmcia_socket_class; |
150 | 150 | ||
151 | int pcmcia_get_window(struct pcmcia_socket *s, | 151 | int pcmcia_get_window(struct pcmcia_socket *s, |
152 | window_handle_t *handle, | 152 | window_handle_t *wh_out, |
153 | int idx, | 153 | window_handle_t wh, |
154 | win_req_t *req); | 154 | win_req_t *req); |
155 | int pccard_register_pcmcia(struct pcmcia_socket *s, struct pcmcia_callback *c); | 155 | int pccard_register_pcmcia(struct pcmcia_socket *s, struct pcmcia_callback *c); |
156 | struct pcmcia_socket *pcmcia_get_socket_by_nr(unsigned int nr); | 156 | struct pcmcia_socket *pcmcia_get_socket_by_nr(unsigned int nr); |