aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pci
diff options
context:
space:
mode:
authorMilton Miller <miltonm@bga.com>2008-07-10 17:29:37 -0400
committerJesse Barnes <jbarnes@virtuousgeek.org>2008-10-20 13:48:34 -0400
commitedbc25caaa492a82e19baa915f1f6b0a0db6554d (patch)
tree967dbd4f8d35fd8532a612fef55691586b831965 /drivers/pci
parent7d67474e506598fe26e0c262acf02132dc730517 (diff)
PCI: remove dynids.use_driver_data
The driver flag dynids.use_driver_data is almost consistently not set, and causes more problems than it solves. It was initially intended as a flag to indicate whether a driver's usage of driver_data had been carefully inspected and was ready for values from userspace. That audit was never done, so most drivers just get a 0 for driver_data when new IDs are added from userspace via sysfs. So remove the flag, allowing drivers to see the data directly (a followon patch validates the passed driver_data value against what the drivers expect). Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Acked-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Milton Miller <miltonm@bga.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci')
-rw-r--r--drivers/pci/pci-driver.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index a13f53486114..4940a53c56a3 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -65,8 +65,7 @@ store_new_id(struct device_driver *driver, const char *buf, size_t count)
65 dynid->id.subdevice = subdevice; 65 dynid->id.subdevice = subdevice;
66 dynid->id.class = class; 66 dynid->id.class = class;
67 dynid->id.class_mask = class_mask; 67 dynid->id.class_mask = class_mask;
68 dynid->id.driver_data = pdrv->dynids.use_driver_data ? 68 dynid->id.driver_data = driver_data;
69 driver_data : 0UL;
70 69
71 spin_lock(&pdrv->dynids.lock); 70 spin_lock(&pdrv->dynids.lock);
72 list_add_tail(&dynid->node, &pdrv->dynids.list); 71 list_add_tail(&dynid->node, &pdrv->dynids.list);