diff options
author | Stephen Hemminger <stephen@networkplumber.org> | 2014-01-10 17:41:35 -0500 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-01-13 13:14:44 -0500 |
commit | 4ab44676064baeb6c7d807c0f627e07d29ce48e0 (patch) | |
tree | 5680534291343355357f6e94408a0d1067075500 /drivers/pci | |
parent | 8f92fb06ffb090f2b22717481352f1e58511c834 (diff) |
PCI: Remove unused pci_renumber_slot()
My philosophy is unused code is dead code. And dead code is subject to bit
rot and is a likely source of bugs. Use it or lose it.
This reverts part of f46753c5e354 ("PCI: introduce pci_slot") and
d25b7c8d6ba2 ("PCI: rename pci_update_slot_number to pci_renumber_slot"),
removing this interface:
pci_renumber_slot()
[bhelgaas: split to separate patch, add historical link from Alex]
Link: http://lkml.kernel.org/r/20081009043140.8678.44164.stgit@bob.kio
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Alex Chiang <achiang@canonical.com>
Diffstat (limited to 'drivers/pci')
-rw-r--r-- | drivers/pci/slot.c | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c index 448ca562d1f8..7dd62fa9d0bd 100644 --- a/drivers/pci/slot.c +++ b/drivers/pci/slot.c | |||
@@ -320,32 +320,6 @@ err: | |||
320 | EXPORT_SYMBOL_GPL(pci_create_slot); | 320 | EXPORT_SYMBOL_GPL(pci_create_slot); |
321 | 321 | ||
322 | /** | 322 | /** |
323 | * pci_renumber_slot - update %struct pci_slot -> number | ||
324 | * @slot: &struct pci_slot to update | ||
325 | * @slot_nr: new number for slot | ||
326 | * | ||
327 | * The primary purpose of this interface is to allow callers who earlier | ||
328 | * created a placeholder slot in pci_create_slot() by passing a -1 as | ||
329 | * slot_nr, to update their %struct pci_slot with the correct @slot_nr. | ||
330 | */ | ||
331 | void pci_renumber_slot(struct pci_slot *slot, int slot_nr) | ||
332 | { | ||
333 | struct pci_slot *tmp; | ||
334 | |||
335 | down_write(&pci_bus_sem); | ||
336 | |||
337 | list_for_each_entry(tmp, &slot->bus->slots, list) { | ||
338 | WARN_ON(tmp->number == slot_nr); | ||
339 | goto out; | ||
340 | } | ||
341 | |||
342 | slot->number = slot_nr; | ||
343 | out: | ||
344 | up_write(&pci_bus_sem); | ||
345 | } | ||
346 | EXPORT_SYMBOL_GPL(pci_renumber_slot); | ||
347 | |||
348 | /** | ||
349 | * pci_destroy_slot - decrement refcount for physical PCI slot | 323 | * pci_destroy_slot - decrement refcount for physical PCI slot |
350 | * @slot: struct pci_slot to decrement | 324 | * @slot: struct pci_slot to decrement |
351 | * | 325 | * |