diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-04 18:59:13 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-04 18:59:13 -0400 |
commit | d09cc3659db494aca4b3bb2393c533fb4946b794 (patch) | |
tree | 158d1dd5fa5fddf1c99da677a193b8561c11274d /drivers/pci | |
parent | 82e627eb5e07d7993216c9e63fb5550cf6ed25d7 (diff) | |
parent | c0ffa793994a7a69c37a96dabf38323eae1dffa6 (diff) |
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next
Pull core irq updates from Thomas Gleixner:
"The irq department delivers:
- Another tree wide update to get rid of the horrible create_irq
interface along with its even more horrible variants. That also
gets rid of the last leftovers of the initial sparse irq hackery.
arch/driver specific changes have been either acked or ignored.
- A fix for the spurious interrupt detection logic with threaded
interrupts.
- A new ARM SoC interrupt controller
- The usual pile of fixes and improvements all over the place"
* 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (40 commits)
Documentation: brcmstb-l2: Add Broadcom STB Level-2 interrupt controller binding
irqchip: brcmstb-l2: Add Broadcom Set Top Box Level-2 interrupt controller
genirq: Improve documentation to match current implementation
ARM: iop13xx: fix msi support with sparse IRQ
genirq: Provide !SMP stub for irq_set_affinity_notifier()
irqchip: armada-370-xp: Move the devicetree binding documentation
irqchip: gic: Use mask field in GICC_IAR
genirq: Remove dynamic_irq mess
ia64: Use irq_init_desc
genirq: Replace dynamic_irq_init/cleanup
genirq: Remove irq_reserve_irq[s]
genirq: Replace reserve_irqs in core code
s390: Avoid call to irq_reserve_irqs()
s390: Remove pointless arch_show_interrupts()
s390: pci: Check return value of alloc_irq_desc() proper
sh: intc: Remove pointless irq_reserve_irqs() invocation
x86, irq: Remove pointless irq_reserve_irqs() call
genirq: Make create/destroy_irq() ia64 private
tile: Use SPARSE_IRQ
tile: pci: Use irq_alloc/free_hwirq()
...
Diffstat (limited to 'drivers/pci')
-rw-r--r-- | drivers/pci/htirq.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/pci/htirq.c b/drivers/pci/htirq.c index 6e373ea57b32..d68b030ab533 100644 --- a/drivers/pci/htirq.c +++ b/drivers/pci/htirq.c | |||
@@ -87,12 +87,9 @@ void unmask_ht_irq(struct irq_data *data) | |||
87 | int __ht_create_irq(struct pci_dev *dev, int idx, ht_irq_update_t *update) | 87 | int __ht_create_irq(struct pci_dev *dev, int idx, ht_irq_update_t *update) |
88 | { | 88 | { |
89 | struct ht_irq_cfg *cfg; | 89 | struct ht_irq_cfg *cfg; |
90 | int max_irq, pos, irq; | ||
90 | unsigned long flags; | 91 | unsigned long flags; |
91 | u32 data; | 92 | u32 data; |
92 | int max_irq; | ||
93 | int pos; | ||
94 | int irq; | ||
95 | int node; | ||
96 | 93 | ||
97 | pos = pci_find_ht_capability(dev, HT_CAPTYPE_IRQ); | 94 | pos = pci_find_ht_capability(dev, HT_CAPTYPE_IRQ); |
98 | if (!pos) | 95 | if (!pos) |
@@ -120,10 +117,8 @@ int __ht_create_irq(struct pci_dev *dev, int idx, ht_irq_update_t *update) | |||
120 | cfg->msg.address_lo = 0xffffffff; | 117 | cfg->msg.address_lo = 0xffffffff; |
121 | cfg->msg.address_hi = 0xffffffff; | 118 | cfg->msg.address_hi = 0xffffffff; |
122 | 119 | ||
123 | node = dev_to_node(&dev->dev); | 120 | irq = irq_alloc_hwirq(dev_to_node(&dev->dev)); |
124 | irq = create_irq_nr(0, node); | 121 | if (!irq) { |
125 | |||
126 | if (irq <= 0) { | ||
127 | kfree(cfg); | 122 | kfree(cfg); |
128 | return -EBUSY; | 123 | return -EBUSY; |
129 | } | 124 | } |
@@ -166,7 +161,7 @@ void ht_destroy_irq(unsigned int irq) | |||
166 | cfg = irq_get_handler_data(irq); | 161 | cfg = irq_get_handler_data(irq); |
167 | irq_set_chip(irq, NULL); | 162 | irq_set_chip(irq, NULL); |
168 | irq_set_handler_data(irq, NULL); | 163 | irq_set_handler_data(irq, NULL); |
169 | destroy_irq(irq); | 164 | irq_free_hwirq(irq); |
170 | 165 | ||
171 | kfree(cfg); | 166 | kfree(cfg); |
172 | } | 167 | } |