diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2012-12-20 18:36:46 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-01-03 07:09:39 -0500 |
commit | 02f57c67a8677ae55dcdd256a2a7abaf41e4cc1f (patch) | |
tree | de2b6f73409a459119641fd8359694f0367f8f50 /drivers/pci | |
parent | 47525cda88f5cc4dbe24de1cc05617c08e2d7c4a (diff) |
ACPI: Remove acpi_start_single_object() and acpi_bus_start()
The ACPI PCI root bridge driver was the only ACPI driver implementing
the .start() callback, which isn't used by any ACPI drivers any more
now.
For this reason, acpi_start_single_object() has no purpose any more,
so remove it and all references to it. Also remove
acpi_bus_start_device(), whose only purpose was to call
acpi_start_single_object().
Moreover, since after the removal of acpi_bus_start_device() the
only purpose of acpi_bus_start() remains to call
acpi_update_all_gpes(), move that into acpi_bus_add() and drop
acpi_bus_start() too, remove its header from acpi_bus.h and
update all of its former users accordingly.
This change was previously proposed in a different from by
Yinghai Lu.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Toshi Kani <toshi.kani@hp.com>
Diffstat (limited to 'drivers/pci')
-rw-r--r-- | drivers/pci/hotplug/acpiphp_glue.c | 4 | ||||
-rw-r--r-- | drivers/pci/hotplug/sgi_hotplug.c | 2 |
2 files changed, 1 insertions, 5 deletions
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 3d6d4fd1e3c5..7e2bad4c2fcc 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c | |||
@@ -759,7 +759,6 @@ static int acpiphp_bus_add(struct acpiphp_func *func) | |||
759 | -ret_val); | 759 | -ret_val); |
760 | goto acpiphp_bus_add_out; | 760 | goto acpiphp_bus_add_out; |
761 | } | 761 | } |
762 | ret_val = acpi_bus_start(device); | ||
763 | 762 | ||
764 | acpiphp_bus_add_out: | 763 | acpiphp_bus_add_out: |
765 | return ret_val; | 764 | return ret_val; |
@@ -1148,8 +1147,7 @@ static void handle_bridge_insertion(acpi_handle handle, u32 type) | |||
1148 | err("cannot add bridge to acpi list\n"); | 1147 | err("cannot add bridge to acpi list\n"); |
1149 | return; | 1148 | return; |
1150 | } | 1149 | } |
1151 | if (!acpiphp_configure_bridge(handle) && | 1150 | if (!acpiphp_configure_bridge(handle)) |
1152 | !acpi_bus_start(device)) | ||
1153 | add_bridge(handle); | 1151 | add_bridge(handle); |
1154 | else | 1152 | else |
1155 | err("cannot configure and start bridge\n"); | 1153 | err("cannot configure and start bridge\n"); |
diff --git a/drivers/pci/hotplug/sgi_hotplug.c b/drivers/pci/hotplug/sgi_hotplug.c index f64ca92253da..20c960d5317d 100644 --- a/drivers/pci/hotplug/sgi_hotplug.c +++ b/drivers/pci/hotplug/sgi_hotplug.c | |||
@@ -457,8 +457,6 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
457 | ret, (int)(adr>>16), | 457 | ret, (int)(adr>>16), |
458 | (int)(adr&0xffff)); | 458 | (int)(adr&0xffff)); |
459 | /* try to continue on */ | 459 | /* try to continue on */ |
460 | } else { | ||
461 | acpi_bus_start(device); | ||
462 | } | 460 | } |
463 | } | 461 | } |
464 | } | 462 | } |