aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pci/pcie/aer
diff options
context:
space:
mode:
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>2009-11-25 07:06:15 -0500
committerJesse Barnes <jbarnes@virtuousgeek.org>2009-12-04 18:56:19 -0500
commit694f88ef7ada0d99e304f687ba92e268a594358b (patch)
treef7095c20f3a6111947a0edaa99dfddd366dbf4b2 /drivers/pci/pcie/aer
parent40717c39b1e6c064f48a263a27e58642221e8661 (diff)
PCI: portdrv: remove unnecessary struct pcie_port_data
Remove 'port_type' field in struct pcie_port_data(), because we can get port type information from struct pci_dev. With this change, this patch also does followings: - Remove struct pcie_port_data because it no longer has any field. - Remove portdrv private definitions about port type (PCIE_RC_PORT, PCIE_SW_UPSTREAM_PORT and PCIE_SW_DOWNSTREAM_PORT), and use generic definitions instead. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci/pcie/aer')
-rw-r--r--drivers/pci/pcie/aer/aerdrv.c2
-rw-r--r--drivers/pci/pcie/aer/aerdrv_core.c11
2 files changed, 6 insertions, 7 deletions
diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c
index 6d30e795a10d..97a345927b55 100644
--- a/drivers/pci/pcie/aer/aerdrv.c
+++ b/drivers/pci/pcie/aer/aerdrv.c
@@ -53,7 +53,7 @@ static struct pci_error_handlers aer_error_handlers = {
53 53
54static struct pcie_port_service_driver aerdriver = { 54static struct pcie_port_service_driver aerdriver = {
55 .name = "aer", 55 .name = "aer",
56 .port_type = PCIE_RC_PORT, 56 .port_type = PCI_EXP_TYPE_ROOT_PORT,
57 .service = PCIE_PORT_SERVICE_AER, 57 .service = PCIE_PORT_SERVICE_AER,
58 58
59 .probe = aer_probe, 59 .probe = aer_probe,
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
index 5391a9b412e5..2fbbcee033a7 100644
--- a/drivers/pci/pcie/aer/aerdrv_core.c
+++ b/drivers/pci/pcie/aer/aerdrv_core.c
@@ -123,9 +123,9 @@ static int set_device_error_reporting(struct pci_dev *dev, void *data)
123{ 123{
124 bool enable = *((bool *)data); 124 bool enable = *((bool *)data);
125 125
126 if (dev->pcie_type == PCIE_RC_PORT || 126 if ((dev->pcie_type == PCI_EXP_TYPE_ROOT_PORT) ||
127 dev->pcie_type == PCIE_SW_UPSTREAM_PORT || 127 (dev->pcie_type == PCI_EXP_TYPE_UPSTREAM) ||
128 dev->pcie_type == PCIE_SW_DOWNSTREAM_PORT) { 128 (dev->pcie_type == PCI_EXP_TYPE_DOWNSTREAM)) {
129 if (enable) 129 if (enable)
130 pci_enable_pcie_error_reporting(dev); 130 pci_enable_pcie_error_reporting(dev);
131 else 131 else
@@ -437,10 +437,9 @@ static int find_aer_service_iter(struct device *device, void *data)
437 result = (struct find_aer_service_data *) data; 437 result = (struct find_aer_service_data *) data;
438 438
439 if (device->bus == &pcie_port_bus_type) { 439 if (device->bus == &pcie_port_bus_type) {
440 struct pcie_port_data *port_data; 440 struct pcie_device *pcie = to_pcie_device(device);
441 441
442 port_data = pci_get_drvdata(to_pcie_device(device)->port); 442 if (pcie->port->pcie_type == PCI_EXP_TYPE_DOWNSTREAM)
443 if (port_data->port_type == PCIE_SW_DOWNSTREAM_PORT)
444 result->is_downstream = 1; 443 result->is_downstream = 1;
445 444
446 driver = device->driver; 445 driver = device->driver;