diff options
author | Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> | 2009-09-07 04:07:29 -0400 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2009-09-09 16:46:18 -0400 |
commit | c9a918838c07cbef934c8ef818d8f0e719015c3a (patch) | |
tree | fa0978d67632a15fdd014f448ac099ab1ec8df75 /drivers/pci/pcie/aer/aer_inject.c | |
parent | b439b1d4e3ae3c36ed94ed233119ff0d145af257 (diff) |
PCI: pcie, aer: checkpatch style cleanup in pcie/aer/*
Before:
drivers/pci/pcie/aer/aer_inject.c
total: 4 errors, 4 warnings, 473 lines checked
drivers/pci/pcie/aer/aerdrv.c
total: 5 errors, 2 warnings, 333 lines checked
drivers/pci/pcie/aer/aerdrv.h
total: 1 errors, 0 warnings, 139 lines checked
drivers/pci/pcie/aer/aerdrv_core.c
total: 4 errors, 3 warnings, 872 lines checked
drivers/pci/pcie/aer/aerdrv_errprint.c
total: 12 errors, 11 warnings, 248 lines checked
After:
drivers/pci/pcie/aer/aer_inject.c
total: 0 errors, 0 warnings, 466 lines checked
drivers/pci/pcie/aer/aerdrv.c
total: 0 errors, 0 warnings, 335 lines checked
drivers/pci/pcie/aer/aerdrv.h
total: 0 errors, 0 warnings, 139 lines checked
drivers/pci/pcie/aer/aerdrv_core.c
total: 0 errors, 0 warnings, 869 lines checked
drivers/pci/pcie/aer/aerdrv_errprint.c
total: 0 errors, 10 warnings, 247 lines checked
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Reviewed-by: Andrew Patterson <andrew.patterson@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci/pcie/aer/aer_inject.c')
-rw-r--r-- | drivers/pci/pcie/aer/aer_inject.c | 25 |
1 files changed, 9 insertions, 16 deletions
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index d92ae21a59d8..62d15f652bb6 100644 --- a/drivers/pci/pcie/aer/aer_inject.c +++ b/drivers/pci/pcie/aer/aer_inject.c | |||
@@ -22,11 +22,10 @@ | |||
22 | #include <linux/miscdevice.h> | 22 | #include <linux/miscdevice.h> |
23 | #include <linux/pci.h> | 23 | #include <linux/pci.h> |
24 | #include <linux/fs.h> | 24 | #include <linux/fs.h> |
25 | #include <asm/uaccess.h> | 25 | #include <linux/uaccess.h> |
26 | #include "aerdrv.h" | 26 | #include "aerdrv.h" |
27 | 27 | ||
28 | struct aer_error_inj | 28 | struct aer_error_inj { |
29 | { | ||
30 | u8 bus; | 29 | u8 bus; |
31 | u8 dev; | 30 | u8 dev; |
32 | u8 fn; | 31 | u8 fn; |
@@ -38,8 +37,7 @@ struct aer_error_inj | |||
38 | u32 header_log3; | 37 | u32 header_log3; |
39 | }; | 38 | }; |
40 | 39 | ||
41 | struct aer_error | 40 | struct aer_error { |
42 | { | ||
43 | struct list_head list; | 41 | struct list_head list; |
44 | unsigned int bus; | 42 | unsigned int bus; |
45 | unsigned int devfn; | 43 | unsigned int devfn; |
@@ -55,8 +53,7 @@ struct aer_error | |||
55 | u32 source_id; | 53 | u32 source_id; |
56 | }; | 54 | }; |
57 | 55 | ||
58 | struct pci_bus_ops | 56 | struct pci_bus_ops { |
59 | { | ||
60 | struct list_head list; | 57 | struct list_head list; |
61 | struct pci_bus *bus; | 58 | struct pci_bus *bus; |
62 | struct pci_ops *ops; | 59 | struct pci_ops *ops; |
@@ -150,7 +147,7 @@ static u32 *find_pci_config_dword(struct aer_error *err, int where, | |||
150 | target = &err->header_log1; | 147 | target = &err->header_log1; |
151 | break; | 148 | break; |
152 | case PCI_ERR_HEADER_LOG+8: | 149 | case PCI_ERR_HEADER_LOG+8: |
153 | target = &err->header_log2; | 150 | target = &err->header_log2; |
154 | break; | 151 | break; |
155 | case PCI_ERR_HEADER_LOG+12: | 152 | case PCI_ERR_HEADER_LOG+12: |
156 | target = &err->header_log3; | 153 | target = &err->header_log3; |
@@ -258,8 +255,7 @@ static int pci_bus_set_aer_ops(struct pci_bus *bus) | |||
258 | bus_ops = NULL; | 255 | bus_ops = NULL; |
259 | out: | 256 | out: |
260 | spin_unlock_irqrestore(&inject_lock, flags); | 257 | spin_unlock_irqrestore(&inject_lock, flags); |
261 | if (bus_ops) | 258 | kfree(bus_ops); |
262 | kfree(bus_ops); | ||
263 | return 0; | 259 | return 0; |
264 | } | 260 | } |
265 | 261 | ||
@@ -401,10 +397,8 @@ static int aer_inject(struct aer_error_inj *einj) | |||
401 | else | 397 | else |
402 | ret = -EINVAL; | 398 | ret = -EINVAL; |
403 | out_put: | 399 | out_put: |
404 | if (err_alloc) | 400 | kfree(err_alloc); |
405 | kfree(err_alloc); | 401 | kfree(rperr_alloc); |
406 | if (rperr_alloc) | ||
407 | kfree(rperr_alloc); | ||
408 | pci_dev_put(dev); | 402 | pci_dev_put(dev); |
409 | return ret; | 403 | return ret; |
410 | } | 404 | } |
@@ -458,8 +452,7 @@ static void __exit aer_inject_exit(void) | |||
458 | } | 452 | } |
459 | 453 | ||
460 | spin_lock_irqsave(&inject_lock, flags); | 454 | spin_lock_irqsave(&inject_lock, flags); |
461 | list_for_each_entry_safe(err, err_next, | 455 | list_for_each_entry_safe(err, err_next, &pci_bus_ops_list, list) { |
462 | &pci_bus_ops_list, list) { | ||
463 | list_del(&err->list); | 456 | list_del(&err->list); |
464 | kfree(err); | 457 | kfree(err); |
465 | } | 458 | } |