diff options
author | Linus Torvalds <torvalds@g5.osdl.org> | 2005-08-08 21:46:09 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-08-08 21:46:09 -0400 |
commit | dc836b5b6fcde95f750a4790d8200fabaf563dc9 (patch) | |
tree | 893613626de4794a7b13fe6793bdebc79420c433 /drivers/pci/pci.c | |
parent | 138b9dd1fd7b44176af4f3b672060c790b0eaf55 (diff) |
Revert "[PATCH] PCI: restore BAR values..."
Revert commit fec59a711eef002d4ef9eb8de09dd0a26986eb77, which is
breaking sparc64 that doesn't have a working pci_update_resource.
We'll re-do this after 2.6.13 when we'll do it all properly.
Diffstat (limited to 'drivers/pci/pci.c')
-rw-r--r-- | drivers/pci/pci.c | 59 |
1 files changed, 4 insertions, 55 deletions
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 65ea7d25f691..1b34fc56067e 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c | |||
@@ -222,37 +222,6 @@ pci_find_parent_resource(const struct pci_dev *dev, struct resource *res) | |||
222 | } | 222 | } |
223 | 223 | ||
224 | /** | 224 | /** |
225 | * pci_restore_bars - restore a devices BAR values (e.g. after wake-up) | ||
226 | * @dev: PCI device to have its BARs restored | ||
227 | * | ||
228 | * Restore the BAR values for a given device, so as to make it | ||
229 | * accessible by its driver. | ||
230 | */ | ||
231 | void | ||
232 | pci_restore_bars(struct pci_dev *dev) | ||
233 | { | ||
234 | int i, numres; | ||
235 | |||
236 | switch (dev->hdr_type) { | ||
237 | case PCI_HEADER_TYPE_NORMAL: | ||
238 | numres = 6; | ||
239 | break; | ||
240 | case PCI_HEADER_TYPE_BRIDGE: | ||
241 | numres = 2; | ||
242 | break; | ||
243 | case PCI_HEADER_TYPE_CARDBUS: | ||
244 | numres = 1; | ||
245 | break; | ||
246 | default: | ||
247 | /* Should never get here, but just in case... */ | ||
248 | return; | ||
249 | } | ||
250 | |||
251 | for (i = 0; i < numres; i ++) | ||
252 | pci_update_resource(dev, &dev->resource[i], i); | ||
253 | } | ||
254 | |||
255 | /** | ||
256 | * pci_set_power_state - Set the power state of a PCI device | 225 | * pci_set_power_state - Set the power state of a PCI device |
257 | * @dev: PCI device to be suspended | 226 | * @dev: PCI device to be suspended |
258 | * @state: PCI power state (D0, D1, D2, D3hot, D3cold) we're entering | 227 | * @state: PCI power state (D0, D1, D2, D3hot, D3cold) we're entering |
@@ -270,7 +239,7 @@ int (*platform_pci_set_power_state)(struct pci_dev *dev, pci_power_t t); | |||
270 | int | 239 | int |
271 | pci_set_power_state(struct pci_dev *dev, pci_power_t state) | 240 | pci_set_power_state(struct pci_dev *dev, pci_power_t state) |
272 | { | 241 | { |
273 | int pm, need_restore = 0; | 242 | int pm; |
274 | u16 pmcsr, pmc; | 243 | u16 pmcsr, pmc; |
275 | 244 | ||
276 | /* bound the state we're entering */ | 245 | /* bound the state we're entering */ |
@@ -309,17 +278,14 @@ pci_set_power_state(struct pci_dev *dev, pci_power_t state) | |||
309 | return -EIO; | 278 | return -EIO; |
310 | } | 279 | } |
311 | 280 | ||
312 | pci_read_config_word(dev, pm + PCI_PM_CTRL, &pmcsr); | ||
313 | |||
314 | /* If we're in D3, force entire word to 0. | 281 | /* If we're in D3, force entire word to 0. |
315 | * This doesn't affect PME_Status, disables PME_En, and | 282 | * This doesn't affect PME_Status, disables PME_En, and |
316 | * sets PowerState to 0. | 283 | * sets PowerState to 0. |
317 | */ | 284 | */ |
318 | if (dev->current_state >= PCI_D3hot) { | 285 | if (dev->current_state >= PCI_D3hot) |
319 | if (!(pmcsr & PCI_PM_CTRL_NO_SOFT_RESET)) | ||
320 | need_restore = 1; | ||
321 | pmcsr = 0; | 286 | pmcsr = 0; |
322 | } else { | 287 | else { |
288 | pci_read_config_word(dev, pm + PCI_PM_CTRL, &pmcsr); | ||
323 | pmcsr &= ~PCI_PM_CTRL_STATE_MASK; | 289 | pmcsr &= ~PCI_PM_CTRL_STATE_MASK; |
324 | pmcsr |= state; | 290 | pmcsr |= state; |
325 | } | 291 | } |
@@ -342,22 +308,6 @@ pci_set_power_state(struct pci_dev *dev, pci_power_t state) | |||
342 | platform_pci_set_power_state(dev, state); | 308 | platform_pci_set_power_state(dev, state); |
343 | 309 | ||
344 | dev->current_state = state; | 310 | dev->current_state = state; |
345 | |||
346 | /* According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT | ||
347 | * INTERFACE SPECIFICATION, REV. 1.2", a device transitioning | ||
348 | * from D3hot to D0 _may_ perform an internal reset, thereby | ||
349 | * going to "D0 Uninitialized" rather than "D0 Initialized". | ||
350 | * For example, at least some versions of the 3c905B and the | ||
351 | * 3c556B exhibit this behaviour. | ||
352 | * | ||
353 | * At least some laptop BIOSen (e.g. the Thinkpad T21) leave | ||
354 | * devices in a D3hot state at boot. Consequently, we need to | ||
355 | * restore at least the BARs so that the device will be | ||
356 | * accessible to its driver. | ||
357 | */ | ||
358 | if (need_restore) | ||
359 | pci_restore_bars(dev); | ||
360 | |||
361 | return 0; | 311 | return 0; |
362 | } | 312 | } |
363 | 313 | ||
@@ -855,7 +805,6 @@ struct pci_dev *isa_bridge; | |||
855 | EXPORT_SYMBOL(isa_bridge); | 805 | EXPORT_SYMBOL(isa_bridge); |
856 | #endif | 806 | #endif |
857 | 807 | ||
858 | EXPORT_SYMBOL_GPL(pci_restore_bars); | ||
859 | EXPORT_SYMBOL(pci_enable_device_bars); | 808 | EXPORT_SYMBOL(pci_enable_device_bars); |
860 | EXPORT_SYMBOL(pci_enable_device); | 809 | EXPORT_SYMBOL(pci_enable_device); |
861 | EXPORT_SYMBOL(pci_disable_device); | 810 | EXPORT_SYMBOL(pci_disable_device); |