diff options
author | Alex Chiang <achiang@hp.com> | 2008-10-20 19:40:52 -0400 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2008-10-22 19:42:38 -0400 |
commit | 828f37683e6d3ab5912989df0d04201db7ad798e (patch) | |
tree | 5761f28363b8fd4b23eaf88305b3f29cfc6b92ba /drivers/pci/hotplug | |
parent | d25b7c8d6ba2735602003d75a28894772fe8ad6a (diff) |
PCI: update pci_create_slot() to take a 'hotplug' param
Slot detection drivers can co-exist with hotplug drivers. The names
of the detected/claimed slots may be different depending on module
load order.
For legacy reasons, we need to allow hotplug drivers to override
the slot name if a detection driver is loaded first (and they find
the same slots).
Creating and overriding slot names should be an atomic operation,
otherwise you get a locking nightmare as various drivers race to
call pci_create_slot().
pci_create_slot() is already serialized by grabbing the pci_bus_sem.
We update the API and add a 'hotplug' param, which is:
set if the caller is a hotplug driver
NULL if the caller is a detection driver
pci_create_slot() does not actually use the 'hotplug' parameter in this
patch. A later patch will add the logic that uses it.
Cc: kristen.c.accardi@intel.com
Cc: matthew@wil.cx
Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci/hotplug')
-rw-r--r-- | drivers/pci/hotplug/pci_hotplug_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index 02b1ae12a2e6..1cdeb642fdcf 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c | |||
@@ -579,7 +579,7 @@ int pci_hp_register(struct hotplug_slot *slot, struct pci_bus *bus, int slot_nr, | |||
579 | * driver and call it here again. If we've already created the | 579 | * driver and call it here again. If we've already created the |
580 | * pci_slot, the interface will simply bump the refcount. | 580 | * pci_slot, the interface will simply bump the refcount. |
581 | */ | 581 | */ |
582 | pci_slot = pci_create_slot(bus, slot_nr, name); | 582 | pci_slot = pci_create_slot(bus, slot_nr, name, slot); |
583 | if (IS_ERR(pci_slot)) | 583 | if (IS_ERR(pci_slot)) |
584 | return PTR_ERR(pci_slot); | 584 | return PTR_ERR(pci_slot); |
585 | 585 | ||