diff options
author | Tejun Heo <htejun@gmail.com> | 2007-09-20 03:05:10 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-12 17:51:09 -0400 |
commit | 5a7ad7f044941316dc98eda2a087a12a7a50649d (patch) | |
tree | 03b61af0e90dc158df43f24f8a38792d8c6ae651 /drivers/pci/hotplug | |
parent | 59f69015684b3de7b9472be9a81b1a978f93a496 (diff) |
sysfs: kill sysfs_update_file()
sysfs_update_file() depends on inode->i_mtime but sysfs iondes are now
reclaimable making the reported modification time unreliable. There's
only one user (pci hotplug) of this notification mechanism and it
reportedly isn't utilized from userland.
Kill sysfs_update_file().
Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pci/hotplug')
-rw-r--r-- | drivers/pci/hotplug/pci_hotplug_core.c | 60 |
1 files changed, 0 insertions, 60 deletions
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index bd433ef6bfc6..f0eba534f805 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c | |||
@@ -694,66 +694,6 @@ int __must_check pci_hp_change_slot_info(struct hotplug_slot *slot, | |||
694 | if ((slot == NULL) || (info == NULL)) | 694 | if ((slot == NULL) || (info == NULL)) |
695 | return -ENODEV; | 695 | return -ENODEV; |
696 | 696 | ||
697 | /* | ||
698 | * check all fields in the info structure, and update timestamps | ||
699 | * for the files referring to the fields that have now changed. | ||
700 | */ | ||
701 | if ((has_power_file(slot) == 0) && | ||
702 | (slot->info->power_status != info->power_status)) { | ||
703 | retval = sysfs_update_file(&slot->kobj, | ||
704 | &hotplug_slot_attr_power.attr); | ||
705 | if (retval) | ||
706 | return retval; | ||
707 | } | ||
708 | |||
709 | if ((has_attention_file(slot) == 0) && | ||
710 | (slot->info->attention_status != info->attention_status)) { | ||
711 | retval = sysfs_update_file(&slot->kobj, | ||
712 | &hotplug_slot_attr_attention.attr); | ||
713 | if (retval) | ||
714 | return retval; | ||
715 | } | ||
716 | |||
717 | if ((has_latch_file(slot) == 0) && | ||
718 | (slot->info->latch_status != info->latch_status)) { | ||
719 | retval = sysfs_update_file(&slot->kobj, | ||
720 | &hotplug_slot_attr_latch.attr); | ||
721 | if (retval) | ||
722 | return retval; | ||
723 | } | ||
724 | |||
725 | if ((has_adapter_file(slot) == 0) && | ||
726 | (slot->info->adapter_status != info->adapter_status)) { | ||
727 | retval = sysfs_update_file(&slot->kobj, | ||
728 | &hotplug_slot_attr_presence.attr); | ||
729 | if (retval) | ||
730 | return retval; | ||
731 | } | ||
732 | |||
733 | if ((has_address_file(slot) == 0) && | ||
734 | (slot->info->address != info->address)) { | ||
735 | retval = sysfs_update_file(&slot->kobj, | ||
736 | &hotplug_slot_attr_address.attr); | ||
737 | if (retval) | ||
738 | return retval; | ||
739 | } | ||
740 | |||
741 | if ((has_max_bus_speed_file(slot) == 0) && | ||
742 | (slot->info->max_bus_speed != info->max_bus_speed)) { | ||
743 | retval = sysfs_update_file(&slot->kobj, | ||
744 | &hotplug_slot_attr_max_bus_speed.attr); | ||
745 | if (retval) | ||
746 | return retval; | ||
747 | } | ||
748 | |||
749 | if ((has_cur_bus_speed_file(slot) == 0) && | ||
750 | (slot->info->cur_bus_speed != info->cur_bus_speed)) { | ||
751 | retval = sysfs_update_file(&slot->kobj, | ||
752 | &hotplug_slot_attr_cur_bus_speed.attr); | ||
753 | if (retval) | ||
754 | return retval; | ||
755 | } | ||
756 | |||
757 | memcpy (slot->info, info, sizeof (struct hotplug_slot_info)); | 697 | memcpy (slot->info, info, sizeof (struct hotplug_slot_info)); |
758 | 698 | ||
759 | return 0; | 699 | return 0; |