diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2012-07-11 14:26:40 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2012-07-11 14:26:40 -0400 |
commit | 7569c43e4d3fbb0ef1a8db0db3c1d77111bf26ed (patch) | |
tree | f8ce42e62b68b03ae90594830e58390930e8d780 /drivers/pci/hotplug | |
parent | 6ee53f4c38e70ba34777ad38807a50c1812ff36f (diff) | |
parent | 2ac45f28b8eeef576c48579833b40b572f3f9790 (diff) |
Merge branch 'pci/yinghai-hotplug-cleanup' into next
* pci/yinghai-hotplug-cleanup:
PCI: acpiphp: merge acpiphp_debug and debug
PCI: acpiphp: remove unused res_lock
Diffstat (limited to 'drivers/pci/hotplug')
-rw-r--r-- | drivers/pci/hotplug/acpiphp.h | 4 | ||||
-rw-r--r-- | drivers/pci/hotplug/acpiphp_core.c | 7 | ||||
-rw-r--r-- | drivers/pci/hotplug/acpiphp_glue.c | 3 |
3 files changed, 3 insertions, 11 deletions
diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h index 7722108e78df..a1afb5b39ad4 100644 --- a/drivers/pci/hotplug/acpiphp.h +++ b/drivers/pci/hotplug/acpiphp.h | |||
@@ -89,8 +89,6 @@ struct acpiphp_bridge { | |||
89 | 89 | ||
90 | /* PCI-to-PCI bridge device */ | 90 | /* PCI-to-PCI bridge device */ |
91 | struct pci_dev *pci_dev; | 91 | struct pci_dev *pci_dev; |
92 | |||
93 | spinlock_t res_lock; | ||
94 | }; | 92 | }; |
95 | 93 | ||
96 | 94 | ||
@@ -207,6 +205,6 @@ extern u8 acpiphp_get_latch_status (struct acpiphp_slot *slot); | |||
207 | extern u8 acpiphp_get_adapter_status (struct acpiphp_slot *slot); | 205 | extern u8 acpiphp_get_adapter_status (struct acpiphp_slot *slot); |
208 | 206 | ||
209 | /* variables */ | 207 | /* variables */ |
210 | extern int acpiphp_debug; | 208 | extern bool acpiphp_debug; |
211 | 209 | ||
212 | #endif /* _ACPIPHP_H */ | 210 | #endif /* _ACPIPHP_H */ |
diff --git a/drivers/pci/hotplug/acpiphp_core.c b/drivers/pci/hotplug/acpiphp_core.c index aa41631e9e02..96316b74969f 100644 --- a/drivers/pci/hotplug/acpiphp_core.c +++ b/drivers/pci/hotplug/acpiphp_core.c | |||
@@ -47,8 +47,7 @@ | |||
47 | /* name size which is used for entries in pcihpfs */ | 47 | /* name size which is used for entries in pcihpfs */ |
48 | #define SLOT_NAME_SIZE 21 /* {_SUN} */ | 48 | #define SLOT_NAME_SIZE 21 /* {_SUN} */ |
49 | 49 | ||
50 | static bool debug; | 50 | bool acpiphp_debug; |
51 | int acpiphp_debug; | ||
52 | 51 | ||
53 | /* local variables */ | 52 | /* local variables */ |
54 | static int num_slots; | 53 | static int num_slots; |
@@ -62,7 +61,7 @@ MODULE_AUTHOR(DRIVER_AUTHOR); | |||
62 | MODULE_DESCRIPTION(DRIVER_DESC); | 61 | MODULE_DESCRIPTION(DRIVER_DESC); |
63 | MODULE_LICENSE("GPL"); | 62 | MODULE_LICENSE("GPL"); |
64 | MODULE_PARM_DESC(debug, "Debugging mode enabled or not"); | 63 | MODULE_PARM_DESC(debug, "Debugging mode enabled or not"); |
65 | module_param(debug, bool, 0644); | 64 | module_param_named(debug, acpiphp_debug, bool, 0644); |
66 | 65 | ||
67 | /* export the attention callback registration methods */ | 66 | /* export the attention callback registration methods */ |
68 | EXPORT_SYMBOL_GPL(acpiphp_register_attention); | 67 | EXPORT_SYMBOL_GPL(acpiphp_register_attention); |
@@ -379,8 +378,6 @@ static int __init acpiphp_init(void) | |||
379 | if (acpi_pci_disabled) | 378 | if (acpi_pci_disabled) |
380 | return 0; | 379 | return 0; |
381 | 380 | ||
382 | acpiphp_debug = debug; | ||
383 | |||
384 | /* read all the ACPI info from the system */ | 381 | /* read all the ACPI info from the system */ |
385 | return init_acpi(); | 382 | return init_acpi(); |
386 | } | 383 | } |
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 395c67d3d296..ad6fd6695495 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c | |||
@@ -396,8 +396,6 @@ static void add_host_bridge(acpi_handle *handle) | |||
396 | 396 | ||
397 | bridge->pci_bus = root->bus; | 397 | bridge->pci_bus = root->bus; |
398 | 398 | ||
399 | spin_lock_init(&bridge->res_lock); | ||
400 | |||
401 | init_bridge_misc(bridge); | 399 | init_bridge_misc(bridge); |
402 | } | 400 | } |
403 | 401 | ||
@@ -430,7 +428,6 @@ static void add_p2p_bridge(acpi_handle *handle) | |||
430 | * (which we access during module unload). | 428 | * (which we access during module unload). |
431 | */ | 429 | */ |
432 | get_device(&bridge->pci_bus->dev); | 430 | get_device(&bridge->pci_bus->dev); |
433 | spin_lock_init(&bridge->res_lock); | ||
434 | 431 | ||
435 | init_bridge_misc(bridge); | 432 | init_bridge_misc(bridge); |
436 | return; | 433 | return; |