diff options
author | Dmitry Torokhov <dtor_core@ameritech.net> | 2005-04-29 02:26:27 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-06-20 18:15:02 -0400 |
commit | fc7e4828995d8c9e4c9597f8a19179e4ab53f73e (patch) | |
tree | 0ca83b71052eb241acc64d0152bff21188944b9c /drivers/pci/hotplug | |
parent | 4a0c20bf8c0fe2116f8fd7d3da6122bf8a01f026 (diff) |
[PATCH] sysfs: (driver/pci) if show/store is missing return -EIO
sysfs: fix drivers/pci so if an attribute does not implement
show or store method read/write will return -EIO
instead of 0.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pci/hotplug')
-rw-r--r-- | drivers/pci/hotplug/pci_hotplug_core.c | 4 | ||||
-rw-r--r-- | drivers/pci/hotplug/rpadlpar_sysfs.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index c802f6270b89..c4282902cb52 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c | |||
@@ -73,7 +73,7 @@ static ssize_t hotplug_slot_attr_show(struct kobject *kobj, | |||
73 | { | 73 | { |
74 | struct hotplug_slot *slot = to_hotplug_slot(kobj); | 74 | struct hotplug_slot *slot = to_hotplug_slot(kobj); |
75 | struct hotplug_slot_attribute *attribute = to_hotplug_attr(attr); | 75 | struct hotplug_slot_attribute *attribute = to_hotplug_attr(attr); |
76 | return attribute->show ? attribute->show(slot, buf) : 0; | 76 | return attribute->show ? attribute->show(slot, buf) : -EIO; |
77 | } | 77 | } |
78 | 78 | ||
79 | static ssize_t hotplug_slot_attr_store(struct kobject *kobj, | 79 | static ssize_t hotplug_slot_attr_store(struct kobject *kobj, |
@@ -81,7 +81,7 @@ static ssize_t hotplug_slot_attr_store(struct kobject *kobj, | |||
81 | { | 81 | { |
82 | struct hotplug_slot *slot = to_hotplug_slot(kobj); | 82 | struct hotplug_slot *slot = to_hotplug_slot(kobj); |
83 | struct hotplug_slot_attribute *attribute = to_hotplug_attr(attr); | 83 | struct hotplug_slot_attribute *attribute = to_hotplug_attr(attr); |
84 | return attribute->store ? attribute->store(slot, buf, len) : 0; | 84 | return attribute->store ? attribute->store(slot, buf, len) : -EIO; |
85 | } | 85 | } |
86 | 86 | ||
87 | static struct sysfs_ops hotplug_slot_sysfs_ops = { | 87 | static struct sysfs_ops hotplug_slot_sysfs_ops = { |
diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c index 3285b822478d..752e6513c447 100644 --- a/drivers/pci/hotplug/rpadlpar_sysfs.c +++ b/drivers/pci/hotplug/rpadlpar_sysfs.c | |||
@@ -48,7 +48,7 @@ dlpar_attr_store(struct kobject * kobj, struct attribute * attr, | |||
48 | struct dlpar_io_attr *dlpar_attr = container_of(attr, | 48 | struct dlpar_io_attr *dlpar_attr = container_of(attr, |
49 | struct dlpar_io_attr, attr); | 49 | struct dlpar_io_attr, attr); |
50 | return dlpar_attr->store ? | 50 | return dlpar_attr->store ? |
51 | dlpar_attr->store(dlpar_attr, buf, nbytes) : 0; | 51 | dlpar_attr->store(dlpar_attr, buf, nbytes) : -EIO; |
52 | } | 52 | } |
53 | 53 | ||
54 | static struct sysfs_ops dlpar_attr_sysfs_ops = { | 54 | static struct sysfs_ops dlpar_attr_sysfs_ops = { |