aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pci/bus.c
diff options
context:
space:
mode:
authorMyron Stowe <myron.stowe@redhat.com>2012-07-09 17:36:46 -0400
committerBjorn Helgaas <bhelgaas@google.com>2012-07-09 22:56:45 -0400
commit735bff10c157fdbba2291e10ca3e28a59c7acc1c (patch)
tree2cae34fe274546d5a9ab4e7a24699833aab0e8eb /drivers/pci/bus.c
parent3274c8eb26896fc4cae3b199de71e985e20771a9 (diff)
PCI: call final fixups hot-added devices
Final fixups are currently applied only at boot-time by pci_apply_final_quirks(), which is an fs_initcall(). Hot-added devices don't get these fixups, so they may not be completely initialized. This patch makes us run final fixups for hot-added devices in pci_bus_add_device() just before the new device becomes eligible for driver binding. This patch keeps the fs_initcall() for devices present at boot because we do resource assignment between pci_bus_add_device and the fs_initcall(), and we don't want to break any fixups that depend on that assignment. This is a design issue that may be addressed in the future -- any resource assignment should be done *before* device_add(). [bhelgaas: changelog] Signed-off-by: Myron Stowe <myron.stowe@redhat.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/bus.c')
-rw-r--r--drivers/pci/bus.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 4ce5ef2f2826..b511bd4e3f7c 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -164,6 +164,10 @@ pci_bus_alloc_resource(struct pci_bus *bus, struct resource *res,
164int pci_bus_add_device(struct pci_dev *dev) 164int pci_bus_add_device(struct pci_dev *dev)
165{ 165{
166 int retval; 166 int retval;
167 extern bool pci_fixup_final_inited;
168
169 if (pci_fixup_final_inited)
170 pci_fixup_device(pci_fixup_final, dev);
167 retval = device_add(&dev->dev); 171 retval = device_add(&dev->dev);
168 if (retval) 172 if (retval)
169 return retval; 173 return retval;