Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6 into sh/for-2.6.31

1 files changed, 27 insertions, 14 deletions

diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
index 59fbbf128365..ede614616f8e 100644
--- a/drivers/parisc/lba_pci.c
+++ b/drivers/parisc/lba_pci.c
@@ -980,28 +980,38 @@ static void
 lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
 {
         unsigned long bytecnt;
-        pdc_pat_cell_mod_maddr_block_t pa_pdc_cell;     /* PA_VIEW */
-        pdc_pat_cell_mod_maddr_block_t io_pdc_cell;     /* IO_VIEW */
         long io_count;
         long status;    /* PDC return status */
         long pa_count;
+        pdc_pat_cell_mod_maddr_block_t *pa_pdc_cell;    /* PA_VIEW */
+        pdc_pat_cell_mod_maddr_block_t *io_pdc_cell;    /* IO_VIEW */
         int i;
 
+        pa_pdc_cell = kzalloc(sizeof(pdc_pat_cell_mod_maddr_block_t), GFP_KERNEL);
+        if (!pa_pdc_cell)
+                return;
+
+        io_pdc_cell = kzalloc(sizeof(pdc_pat_cell_mod_maddr_block_t), GFP_KERNEL);
+        if (!pa_pdc_cell) {
+                kfree(pa_pdc_cell);
+                return;
+        }
+
         /* return cell module (IO view) */
         status = pdc_pat_cell_module(&bytecnt, pa_dev->pcell_loc, pa_dev->mod_index,
-                                PA_VIEW, & pa_pdc_cell);
-        pa_count = pa_pdc_cell.mod[1];
+                                PA_VIEW, pa_pdc_cell);
+        pa_count = pa_pdc_cell->mod[1];
 
         status |= pdc_pat_cell_module(&bytecnt, pa_dev->pcell_loc, pa_dev->mod_index,
-                                IO_VIEW, &io_pdc_cell);
-        io_count = io_pdc_cell.mod[1];
+                                IO_VIEW, io_pdc_cell);
+        io_count = io_pdc_cell->mod[1];
 
         /* We've already done this once for device discovery...*/
         if (status != PDC_OK) {
                 panic("pdc_pat_cell_module() call failed for LBA!\n");
         }
 
-        if (PAT_GET_ENTITY(pa_pdc_cell.mod_info) != PAT_ENTITY_LBA) {
+        if (PAT_GET_ENTITY(pa_pdc_cell->mod_info) != PAT_ENTITY_LBA) {
                 panic("pdc_pat_cell_module() entity returned != PAT_ENTITY_LBA!\n");
         }
 
@@ -1016,8 +1026,8 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
                 } *p, *io;
                 struct resource *r;
 
-                p = (void *) &(pa_pdc_cell.mod[2+i*3]);
-                io = (void *) &(io_pdc_cell.mod[2+i*3]);
+                p = (void *) &(pa_pdc_cell->mod[2+i*3]);
+                io = (void *) &(io_pdc_cell->mod[2+i*3]);
 
                 /* Convert the PAT range data to PCI "struct resource" */
                 switch(p->type & 0xff) {
@@ -1096,6 +1106,9 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
                         break;
                 }
         }
+
+        kfree(pa_pdc_cell);
+        kfree(io_pdc_cell);
 }
 #else
 /* keep compiler from complaining about missing declarations */
@@ -1509,10 +1522,6 @@ lba_driver_probe(struct parisc_device *dev)
         lba_bus = lba_dev->hba.hba_bus =
                 pci_scan_bus_parented(&dev->dev, lba_dev->hba.bus_num.start,
                                 cfg_ops, NULL);
-        if (lba_bus) {
-                lba_next_bus = lba_bus->subordinate + 1;
-                pci_bus_add_devices(lba_bus);
-        }
 
         /* This is in lieu of calling pci_assign_unassigned_resources() */
         if (is_pdc_pat()) {
@@ -1533,7 +1542,6 @@ lba_driver_probe(struct parisc_device *dev)
         }
         pci_enable_bridges(lba_bus);
 
-
         /*
         ** Once PCI register ops has walked the bus, access to config
         ** space is restricted. Avoids master aborts on config cycles.
@@ -1543,6 +1551,11 @@ lba_driver_probe(struct parisc_device *dev)
                 lba_dev->flags |= LBA_FLAG_SKIP_PROBE;
         }
 
+        if (lba_bus) {
+                lba_next_bus = lba_bus->subordinate + 1;
+                pci_bus_add_devices(lba_bus);
+        }
+
         /* Whew! Finally done! Tell services we got this one covered. */
         return 0;
 }