diff options
author | Konstantin Khlebnikov <khlebnikov@openvz.org> | 2012-10-08 19:28:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-09 03:22:18 -0400 |
commit | 2dd8ad81e31d0d36a5d448329c646ab43eb17788 (patch) | |
tree | cd358be45ed8067673edac7f1db6b6a42a96d9db /drivers/oprofile | |
parent | 0b173bc4daa8f8ec03a85abf5e47b23502ff80af (diff) |
mm: use mm->exe_file instead of first VM_EXECUTABLE vma->vm_file
Some security modules and oprofile still uses VM_EXECUTABLE for retrieving
a task's executable file. After this patch they will use mm->exe_file
directly. mm->exe_file is protected with mm->mmap_sem, so locking stays
the same.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Chris Metcalf <cmetcalf@tilera.com> [arch/tile]
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> [tomoyo]
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Carsten Otte <cotte@de.ibm.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Eric Paris <eparis@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Acked-by: James Morris <james.l.morris@oracle.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: Matt Helsley <matthltc@us.ibm.com>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Venkatesh Pallipadi <venki@google.com>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/oprofile')
-rw-r--r-- | drivers/oprofile/buffer_sync.c | 17 |
1 files changed, 3 insertions, 14 deletions
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c index f34b5b29fb95..d93b2b6b1f7a 100644 --- a/drivers/oprofile/buffer_sync.c +++ b/drivers/oprofile/buffer_sync.c | |||
@@ -216,7 +216,7 @@ static inline unsigned long fast_get_dcookie(struct path *path) | |||
216 | } | 216 | } |
217 | 217 | ||
218 | 218 | ||
219 | /* Look up the dcookie for the task's first VM_EXECUTABLE mapping, | 219 | /* Look up the dcookie for the task's mm->exe_file, |
220 | * which corresponds loosely to "application name". This is | 220 | * which corresponds loosely to "application name". This is |
221 | * not strictly necessary but allows oprofile to associate | 221 | * not strictly necessary but allows oprofile to associate |
222 | * shared-library samples with particular applications | 222 | * shared-library samples with particular applications |
@@ -224,21 +224,10 @@ static inline unsigned long fast_get_dcookie(struct path *path) | |||
224 | static unsigned long get_exec_dcookie(struct mm_struct *mm) | 224 | static unsigned long get_exec_dcookie(struct mm_struct *mm) |
225 | { | 225 | { |
226 | unsigned long cookie = NO_COOKIE; | 226 | unsigned long cookie = NO_COOKIE; |
227 | struct vm_area_struct *vma; | ||
228 | |||
229 | if (!mm) | ||
230 | goto out; | ||
231 | 227 | ||
232 | for (vma = mm->mmap; vma; vma = vma->vm_next) { | 228 | if (mm && mm->exe_file) |
233 | if (!vma->vm_file) | 229 | cookie = fast_get_dcookie(&mm->exe_file->f_path); |
234 | continue; | ||
235 | if (!(vma->vm_flags & VM_EXECUTABLE)) | ||
236 | continue; | ||
237 | cookie = fast_get_dcookie(&vma->vm_file->f_path); | ||
238 | break; | ||
239 | } | ||
240 | 230 | ||
241 | out: | ||
242 | return cookie; | 231 | return cookie; |
243 | } | 232 | } |
244 | 233 | ||