aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/oprofile
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2006-09-27 04:50:46 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-09-27 11:26:17 -0400
commit8e18e2941c53416aa219708e7dcad21fb4bd6794 (patch)
tree44118f8b09556193ac93e0b71aecfa3e1d4bc182 /drivers/oprofile
parent6a1d9805ec506d8b9d04450997707da5f643d87c (diff)
[PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private
The following patches reduce the size of the VFS inode structure by 28 bytes on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction in the inode size on a UP kernel that is configured in a production mode (i.e., with no spinlock or other debugging functions enabled; if you want to save memory taken up by in-core inodes, the first thing you should do is disable the debugging options; they are responsible for a huge amount of bloat in the VFS inode structure). This patch: The filesystem or device-specific pointer in the inode is inside a union, which is pretty pointless given that all 30+ users of this field have been using the void pointer. Get rid of the union and rename it to i_private, with a comment to explain who is allowed to use the void pointer. This is just a cleanup, but it allows us to reuse the union 'u' for something something where the union will actually be used. [judith@osdl.org: powerpc build fix] Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Judith Lebzelter <judith@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/oprofile')
-rw-r--r--drivers/oprofile/oprofilefs.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/oprofile/oprofilefs.c b/drivers/oprofile/oprofilefs.c
index 71c2da277d6e..deb37354785b 100644
--- a/drivers/oprofile/oprofilefs.c
+++ b/drivers/oprofile/oprofilefs.c
@@ -110,8 +110,8 @@ static ssize_t ulong_write_file(struct file * file, char const __user * buf, siz
110 110
111static int default_open(struct inode * inode, struct file * filp) 111static int default_open(struct inode * inode, struct file * filp)
112{ 112{
113 if (inode->u.generic_ip) 113 if (inode->i_private)
114 filp->private_data = inode->u.generic_ip; 114 filp->private_data = inode->i_private;
115 return 0; 115 return 0;
116} 116}
117 117
@@ -158,7 +158,7 @@ int oprofilefs_create_ulong(struct super_block * sb, struct dentry * root,
158 if (!d) 158 if (!d)
159 return -EFAULT; 159 return -EFAULT;
160 160
161 d->d_inode->u.generic_ip = val; 161 d->d_inode->i_private = val;
162 return 0; 162 return 0;
163} 163}
164 164
@@ -171,7 +171,7 @@ int oprofilefs_create_ro_ulong(struct super_block * sb, struct dentry * root,
171 if (!d) 171 if (!d)
172 return -EFAULT; 172 return -EFAULT;
173 173
174 d->d_inode->u.generic_ip = val; 174 d->d_inode->i_private = val;
175 return 0; 175 return 0;
176} 176}
177 177
@@ -197,7 +197,7 @@ int oprofilefs_create_ro_atomic(struct super_block * sb, struct dentry * root,
197 if (!d) 197 if (!d)
198 return -EFAULT; 198 return -EFAULT;
199 199
200 d->d_inode->u.generic_ip = val; 200 d->d_inode->i_private = val;
201 return 0; 201 return 0;
202} 202}
203 203