aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/oprofile
diff options
context:
space:
mode:
authorRobert Richter <robert.richter@amd.com>2008-12-19 06:59:28 -0500
committerRobert Richter <robert.richter@amd.com>2009-01-07 11:06:32 -0500
commit8350c78734e67ac1f8bfd4eb14b70ff4d01a9a12 (patch)
treea4a78d79a0d88f98fffab92e66906121841ca893 /drivers/oprofile
parentf4ff2364417f0092e49f6a3aa474549a56697f2d (diff)
oprofile: remove backtrace code for ibs
This code is broken since a TRACE_BEGIN_CODE is never sent to the daemon. The data becomes corrupt since the backtrace is interpreted as ibs sample. Signed-off-by: Robert Richter <robert.richter@amd.com>
Diffstat (limited to 'drivers/oprofile')
-rw-r--r--drivers/oprofile/buffer_sync.c2
-rw-r--r--drivers/oprofile/cpu_buffer.c10
2 files changed, 2 insertions, 10 deletions
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index 7415d2e6b3a1..e61e25fda1ad 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -557,11 +557,9 @@ void sync_buffer(int cpu)
557 break; 557 break;
558#ifdef CONFIG_OPROFILE_IBS 558#ifdef CONFIG_OPROFILE_IBS
559 case IBS_FETCH_BEGIN: 559 case IBS_FETCH_BEGIN:
560 state = sb_bt_start;
561 add_ibs_begin(cpu, IBS_FETCH_CODE, mm); 560 add_ibs_begin(cpu, IBS_FETCH_CODE, mm);
562 break; 561 break;
563 case IBS_OP_BEGIN: 562 case IBS_OP_BEGIN:
564 state = sb_bt_start;
565 add_ibs_begin(cpu, IBS_OP_CODE, mm); 563 add_ibs_begin(cpu, IBS_OP_CODE, mm);
566 break; 564 break;
567#endif 565#endif
diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
index 8ae37c9d0ec4..92bf8c0d86fe 100644
--- a/drivers/oprofile/cpu_buffer.c
+++ b/drivers/oprofile/cpu_buffer.c
@@ -347,17 +347,11 @@ void oprofile_add_ibs_sample(struct pt_regs * const regs,
347 fail = fail || add_sample(cpu_buf, ibs_sample[10], ibs_sample[11]); 347 fail = fail || add_sample(cpu_buf, ibs_sample[10], ibs_sample[11]);
348 } 348 }
349 349
350 if (fail) 350 if (!fail)
351 goto fail; 351 return;
352
353 if (oprofile_backtrace_depth)
354 oprofile_ops.backtrace(regs, oprofile_backtrace_depth);
355
356 return;
357 352
358fail: 353fail:
359 cpu_buf->sample_lost_overflow++; 354 cpu_buf->sample_lost_overflow++;
360 return;
361} 355}
362 356
363#endif 357#endif