diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2014-12-02 07:54:00 -0500 |
---|---|---|
committer | Grant Likely <grant.likely@linaro.org> | 2014-12-03 18:12:41 -0500 |
commit | c46ca3c8310b61d253a39ff1375ea97912794cd1 (patch) | |
tree | c2083c006491b8ad03eed666ff1ce60dd7b62e15 /drivers/of/unittest.c | |
parent | 70161ff336674ecfd20614a9c0c61cb17a6e9e83 (diff) |
of: Delete unnecessary check before calling "of_node_put()"
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
Diffstat (limited to 'drivers/of/unittest.c')
-rw-r--r-- | drivers/of/unittest.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 1807a0458648..844838e11ef1 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c | |||
@@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void) | |||
516 | /* Make sure node names are constructed correctly */ | 516 | /* Make sure node names are constructed correctly */ |
517 | selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")), | 517 | selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")), |
518 | "'%s' not added\n", n21->full_name); | 518 | "'%s' not added\n", n21->full_name); |
519 | if (np) | 519 | of_node_put(np); |
520 | of_node_put(np); | ||
521 | 520 | ||
522 | mutex_lock(&of_mutex); | 521 | mutex_lock(&of_mutex); |
523 | selftest(!of_changeset_revert(&chgset), "revert failed\n"); | 522 | selftest(!of_changeset_revert(&chgset), "revert failed\n"); |