aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/of/base.c
diff options
context:
space:
mode:
authorGrant Likely <grant.likely@secretlab.ca>2010-07-23 03:48:25 -0400
committerGrant Likely <grant.likely@secretlab.ca>2010-07-24 18:51:52 -0400
commit9a6b2e588c7809e86161236da3d29581bf5f8402 (patch)
tree0aebb8e868615a2354042a376405cd73d80ef19e /drivers/of/base.c
parent883c2cfc8bcc0fd00c5d9f596fb8870f481b5bda (diff)
of: Fix phandle endian issues
The flat tree code wasn't fixing the endianness on phandle values when unflattening the tree, and the code in drivers/of wasn't always doing a be32_to_cpu before trying to dereference the phandle values. This patch fixes them. Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/of/base.c')
-rw-r--r--drivers/of/base.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c
index e3f7af882e45..aa805250de76 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -605,14 +605,14 @@ EXPORT_SYMBOL(of_find_node_by_phandle);
605struct device_node * 605struct device_node *
606of_parse_phandle(struct device_node *np, const char *phandle_name, int index) 606of_parse_phandle(struct device_node *np, const char *phandle_name, int index)
607{ 607{
608 const phandle *phandle; 608 const __be32 *phandle;
609 int size; 609 int size;
610 610
611 phandle = of_get_property(np, phandle_name, &size); 611 phandle = of_get_property(np, phandle_name, &size);
612 if ((!phandle) || (size < sizeof(*phandle) * (index + 1))) 612 if ((!phandle) || (size < sizeof(*phandle) * (index + 1)))
613 return NULL; 613 return NULL;
614 614
615 return of_find_node_by_phandle(phandle[index]); 615 return of_find_node_by_phandle(be32_to_cpup(phandle + index));
616} 616}
617EXPORT_SYMBOL(of_parse_phandle); 617EXPORT_SYMBOL(of_parse_phandle);
618 618
@@ -668,16 +668,16 @@ int of_parse_phandles_with_args(struct device_node *np, const char *list_name,
668 668
669 while (list < list_end) { 669 while (list < list_end) {
670 const __be32 *cells; 670 const __be32 *cells;
671 const phandle *phandle; 671 phandle phandle;
672 672
673 phandle = list++; 673 phandle = be32_to_cpup(list++);
674 args = list; 674 args = list;
675 675
676 /* one cell hole in the list = <>; */ 676 /* one cell hole in the list = <>; */
677 if (!*phandle) 677 if (!phandle)
678 goto next; 678 goto next;
679 679
680 node = of_find_node_by_phandle(*phandle); 680 node = of_find_node_by_phandle(phandle);
681 if (!node) { 681 if (!node) {
682 pr_debug("%s: could not find phandle\n", 682 pr_debug("%s: could not find phandle\n",
683 np->full_name); 683 np->full_name);