diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-08 09:19:44 -0400 |
---|---|---|
committer | Samuel Ortiz <sameo@linux.intel.com> | 2012-09-24 18:17:26 -0400 |
commit | c51ad34e542606854d0545533329e916689599ba (patch) | |
tree | b75b57bf14c63014d427fe790fbea134154893f9 /drivers/nfc | |
parent | d6650a2ccfdcf536841c2f880a1a6f19fce2e3a1 (diff) |
NFC: Move the pn544_hci dereference below the NULL test
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/nfc')
-rw-r--r-- | drivers/nfc/pn544_hci.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/nfc/pn544_hci.c b/drivers/nfc/pn544_hci.c index e681da2e3413..7b0c2176e89b 100644 --- a/drivers/nfc/pn544_hci.c +++ b/drivers/nfc/pn544_hci.c | |||
@@ -346,13 +346,16 @@ flush: | |||
346 | static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id) | 346 | static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id) |
347 | { | 347 | { |
348 | struct pn544_hci_info *info = dev_id; | 348 | struct pn544_hci_info *info = dev_id; |
349 | struct i2c_client *client = info->i2c_dev; | 349 | struct i2c_client *client; |
350 | struct sk_buff *skb = NULL; | 350 | struct sk_buff *skb = NULL; |
351 | int r; | 351 | int r; |
352 | 352 | ||
353 | BUG_ON(!info); | 353 | if (!info || irq != info->i2c_dev->irq) { |
354 | BUG_ON(irq != info->i2c_dev->irq); | 354 | WARN_ON_ONCE(1); |
355 | return IRQ_NONE; | ||
356 | } | ||
355 | 357 | ||
358 | client = info->i2c_dev; | ||
356 | dev_dbg(&client->dev, "IRQ\n"); | 359 | dev_dbg(&client->dev, "IRQ\n"); |
357 | 360 | ||
358 | if (info->hard_fault != 0) | 361 | if (info->hard_fault != 0) |