diff options
author | David S. Miller <davem@davemloft.net> | 2008-09-22 00:28:51 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-09-22 00:28:51 -0400 |
commit | 43f59c89399fd76883a06c551f24794e98409432 (patch) | |
tree | 7ef8ac7047ea5e74c9d522d6438d03fb69a3ba67 /drivers/net | |
parent | f5fff5dc8a7a3f395b0525c02ba92c95d42b7390 (diff) |
net: Remove __skb_insert() calls outside of skbuff internals.
This minor cleanup simplifies later changes which will convert
struct sk_buff and friends over to using struct list_head.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/cassini.c | 2 | ||||
-rw-r--r-- | drivers/net/ppp_generic.c | 2 | ||||
-rw-r--r-- | drivers/net/pppol2tp.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c index f1936d51b458..40ff6a90d0da 100644 --- a/drivers/net/cassini.c +++ b/drivers/net/cassini.c | |||
@@ -2182,7 +2182,7 @@ static inline void cas_rx_flow_pkt(struct cas *cp, const u64 *words, | |||
2182 | * do any additional locking here. stick the buffer | 2182 | * do any additional locking here. stick the buffer |
2183 | * at the end. | 2183 | * at the end. |
2184 | */ | 2184 | */ |
2185 | __skb_insert(skb, flow->prev, (struct sk_buff *) flow, flow); | 2185 | __skb_queue_tail(flow, skb); |
2186 | if (words[0] & RX_COMP1_RELEASE_FLOW) { | 2186 | if (words[0] & RX_COMP1_RELEASE_FLOW) { |
2187 | while ((skb = __skb_dequeue(flow))) { | 2187 | while ((skb = __skb_dequeue(flow))) { |
2188 | cas_skb_release(skb); | 2188 | cas_skb_release(skb); |
diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index ddccc074a76a..98e04958fef3 100644 --- a/drivers/net/ppp_generic.c +++ b/drivers/net/ppp_generic.c | |||
@@ -1864,7 +1864,7 @@ ppp_mp_insert(struct ppp *ppp, struct sk_buff *skb) | |||
1864 | for (p = list->next; p != (struct sk_buff *)list; p = p->next) | 1864 | for (p = list->next; p != (struct sk_buff *)list; p = p->next) |
1865 | if (seq_before(seq, p->sequence)) | 1865 | if (seq_before(seq, p->sequence)) |
1866 | break; | 1866 | break; |
1867 | __skb_insert(skb, p->prev, p, list); | 1867 | __skb_queue_before(list, p, skb); |
1868 | } | 1868 | } |
1869 | 1869 | ||
1870 | /* | 1870 | /* |
diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c index ff175e8f36b2..185b1dff10a8 100644 --- a/drivers/net/pppol2tp.c +++ b/drivers/net/pppol2tp.c | |||
@@ -353,7 +353,7 @@ static void pppol2tp_recv_queue_skb(struct pppol2tp_session *session, struct sk_ | |||
353 | spin_lock_bh(&session->reorder_q.lock); | 353 | spin_lock_bh(&session->reorder_q.lock); |
354 | skb_queue_walk_safe(&session->reorder_q, skbp, tmp) { | 354 | skb_queue_walk_safe(&session->reorder_q, skbp, tmp) { |
355 | if (PPPOL2TP_SKB_CB(skbp)->ns > ns) { | 355 | if (PPPOL2TP_SKB_CB(skbp)->ns > ns) { |
356 | __skb_insert(skb, skbp->prev, skbp, &session->reorder_q); | 356 | __skb_queue_before(&session->reorder_q, skbp, skb); |
357 | PRINTK(session->debug, PPPOL2TP_MSG_SEQ, KERN_DEBUG, | 357 | PRINTK(session->debug, PPPOL2TP_MSG_SEQ, KERN_DEBUG, |
358 | "%s: pkt %hu, inserted before %hu, reorder_q len=%d\n", | 358 | "%s: pkt %hu, inserted before %hu, reorder_q len=%d\n", |
359 | session->name, ns, PPPOL2TP_SKB_CB(skbp)->ns, | 359 | session->name, ns, PPPOL2TP_SKB_CB(skbp)->ns, |