diff options
author | Eran Ben Elisha <eranbe@mellanox.com> | 2015-05-05 10:07:11 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-05-05 19:39:12 -0400 |
commit | cae0633872fc8b0c34930dd2862856563bce58ec (patch) | |
tree | a618dd534721f5f7539a4c14facdd714752589e7 /drivers/net | |
parent | 7aab5159fa0100ee3f80d1b0f55cd7e9b5823270 (diff) |
net/mlx4_en: Fix off-by-one in counters manipulation
This caused the en_stats_adder helper to accumulate a field which is
not related to the counter, fix that.
Fixes: a3333b35da16 ('net/mlx4_en: Moderate ethtool callback to show [..]')
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/en_port.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_port.c b/drivers/net/ethernet/mellanox/mlx4/en_port.c index 54f0e5ab2e55..0a56f010c846 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_port.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_port.c | |||
@@ -139,7 +139,7 @@ static unsigned long en_stats_adder(__be64 *start, __be64 *next, int num) | |||
139 | int i; | 139 | int i; |
140 | int offset = next - start; | 140 | int offset = next - start; |
141 | 141 | ||
142 | for (i = 0; i <= num; i++) { | 142 | for (i = 0; i < num; i++) { |
143 | ret += be64_to_cpu(*curr); | 143 | ret += be64_to_cpu(*curr); |
144 | curr += offset; | 144 | curr += offset; |
145 | } | 145 | } |