tty: move the termios object into the tty

This will let us sort out a whole pile of tty related races. The
alternative would be to keep points and refcount the termios objects.
However
1. They are tiny anyway
2. Many devices don't use the stored copies
3. We can remove a pty special case

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2 files changed, 10 insertions, 12 deletions

diff --git a/drivers/net/irda/irtty-sir.c b/drivers/net/irda/irtty-sir.c
index 3352b2443e58..30087ca23a0f 100644
--- a/drivers/net/irda/irtty-sir.c
+++ b/drivers/net/irda/irtty-sir.c
@@ -124,8 +124,8 @@ static int irtty_change_speed(struct sir_dev *dev, unsigned speed)
         tty = priv->tty;
 
         mutex_lock(&tty->termios_mutex);
-        old_termios = *(tty->termios);
-        cflag = tty->termios->c_cflag;
+        old_termios = tty->termios;
+        cflag = tty->termios.c_cflag;
         tty_encode_baud_rate(tty, speed, speed);
         if (tty->ops->set_termios)
                 tty->ops->set_termios(tty, &old_termios);
@@ -281,15 +281,15 @@ static inline void irtty_stop_receiver(struct tty_struct *tty, int stop)
         int cflag;
 
         mutex_lock(&tty->termios_mutex);
-        old_termios = *(tty->termios);
-        cflag = tty->termios->c_cflag;
+        old_termios = tty->termios;
+        cflag = tty->termios.c_cflag;
         
         if (stop)
                 cflag &= ~CREAD;
         else
                 cflag |= CREAD;
 
-        tty->termios->c_cflag = cflag;
+        tty->termios.c_cflag = cflag;
         if (tty->ops->set_termios)
                 tty->ops->set_termios(tty, &old_termios);
         mutex_unlock(&tty->termios_mutex);
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 62f30b46fa42..7736af75e12b 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1107,7 +1107,6 @@ static void _hso_serial_set_termios(struct tty_struct *tty,
                                     struct ktermios *old)
 {
         struct hso_serial *serial = tty->driver_data;
-        struct ktermios *termios;
 
         if (!serial) {
                 printk(KERN_ERR "%s: no tty structures", __func__);
@@ -1119,16 +1118,15 @@ static void _hso_serial_set_termios(struct tty_struct *tty,
         /*
          *      Fix up unsupported bits
          */
-        termios = tty->termios;
-        termios->c_iflag &= ~IXON; /* disable enable XON/XOFF flow control */
+        tty->termios.c_iflag &= ~IXON; /* disable enable XON/XOFF flow control */
 
-        termios->c_cflag &=
+        tty->termios.c_cflag &=
                 ~(CSIZE         /* no size */
                 | PARENB        /* disable parity bit */
                 | CBAUD         /* clear current baud rate */
                 | CBAUDEX);     /* clear current buad rate */
 
-        termios->c_cflag |= CS8;        /* character size 8 bits */
+        tty->termios.c_cflag |= CS8;    /* character size 8 bits */
 
         /* baud rate 115200 */
         tty_encode_baud_rate(tty, 115200, 115200);
@@ -1425,14 +1423,14 @@ static void hso_serial_set_termios(struct tty_struct *tty, struct ktermios *old)
 
         if (old)
                 D5("Termios called with: cflags new[%d] - old[%d]",
-                   tty->termios->c_cflag, old->c_cflag);
+                   tty->termios.c_cflag, old->c_cflag);
 
         /* the actual setup */
         spin_lock_irqsave(&serial->serial_lock, flags);
         if (serial->port.count)
                 _hso_serial_set_termios(tty, old);
         else
-                tty->termios = old;
+                tty->termios = *old;
         spin_unlock_irqrestore(&serial->serial_lock, flags);
 
         /* done */