diff options
author | David S. Miller <davem@davemloft.net> | 2008-04-19 21:09:39 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-04-19 21:09:39 -0400 |
commit | 344234de54891ed15bf8127e4640ff9238076d6c (patch) | |
tree | 4f2581b2629b52b22958d7d3d4e64ce409c96125 /drivers/net | |
parent | e1f9a464026011b3f7d0f7b6dfab3e562e870a46 (diff) |
iwlwifi: Fix unconditional access to station->tidp[].agg.
Reportred by Ingo Molnar:
drivers/net/wireless/iwlwifi/iwl-debugfs.c: In function 'iwl_dbgfs_stations_read':
drivers/net/wireless/iwlwifi/iwl-debugfs.c:256: error: 'struct iwl4965_tid_data' has no member named 'agg'
Needs CONFIG_IWL4965_HT protection.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-debugfs.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-debugfs.c b/drivers/net/wireless/iwlwifi/iwl-debugfs.c index 0f16f2606f29..9a30e1df311d 100644 --- a/drivers/net/wireless/iwlwifi/iwl-debugfs.c +++ b/drivers/net/wireless/iwlwifi/iwl-debugfs.c | |||
@@ -239,28 +239,34 @@ static ssize_t iwl_dbgfs_stations_read(struct file *file, char __user *user_buf, | |||
239 | "ps_status: %u\n", station->ps_status); | 239 | "ps_status: %u\n", station->ps_status); |
240 | pos += scnprintf(buf + pos, bufsz - pos, "tid data:\n"); | 240 | pos += scnprintf(buf + pos, bufsz - pos, "tid data:\n"); |
241 | pos += scnprintf(buf + pos, bufsz - pos, | 241 | pos += scnprintf(buf + pos, bufsz - pos, |
242 | "seq_num\t\ttxq_id\t"); | 242 | "seq_num\t\ttxq_id"); |
243 | #ifdef CONFIG_IWL4965_HT | ||
243 | pos += scnprintf(buf + pos, bufsz - pos, | 244 | pos += scnprintf(buf + pos, bufsz - pos, |
244 | "frame_count\twait_for_ba\t"); | 245 | "\tframe_count\twait_for_ba\t"); |
245 | pos += scnprintf(buf + pos, bufsz - pos, | 246 | pos += scnprintf(buf + pos, bufsz - pos, |
246 | "start_idx\tbitmap0\t"); | 247 | "start_idx\tbitmap0\t"); |
247 | pos += scnprintf(buf + pos, bufsz - pos, | 248 | pos += scnprintf(buf + pos, bufsz - pos, |
248 | "bitmap1\trate_n_flags\n"); | 249 | "bitmap1\trate_n_flags"); |
250 | #endif | ||
251 | pos += scnprintf(buf + pos, bufsz - pos, "\n"); | ||
249 | 252 | ||
250 | for (j = 0; j < MAX_TID_COUNT; j++) { | 253 | for (j = 0; j < MAX_TID_COUNT; j++) { |
251 | pos += scnprintf(buf + pos, bufsz - pos, | 254 | pos += scnprintf(buf + pos, bufsz - pos, |
252 | "[%d]:\t\t%u\t", j, | 255 | "[%d]:\t\t%u", j, |
253 | station->tid[j].seq_number); | 256 | station->tid[j].seq_number); |
257 | #ifdef CONFIG_IWL4965_HT | ||
254 | pos += scnprintf(buf + pos, bufsz - pos, | 258 | pos += scnprintf(buf + pos, bufsz - pos, |
255 | "%u\t\t%u\t\t%u\t\t", | 259 | "\t%u\t\t%u\t\t%u\t\t", |
256 | station->tid[j].agg.txq_id, | 260 | station->tid[j].agg.txq_id, |
257 | station->tid[j].agg.frame_count, | 261 | station->tid[j].agg.frame_count, |
258 | station->tid[j].agg.wait_for_ba); | 262 | station->tid[j].agg.wait_for_ba); |
259 | pos += scnprintf(buf + pos, bufsz - pos, | 263 | pos += scnprintf(buf + pos, bufsz - pos, |
260 | "%u\t%llu\t%u\n", | 264 | "%u\t%llu\t%u", |
261 | station->tid[j].agg.start_idx, | 265 | station->tid[j].agg.start_idx, |
262 | (unsigned long long)station->tid[j].agg.bitmap, | 266 | (unsigned long long)station->tid[j].agg.bitmap, |
263 | station->tid[j].agg.rate_n_flags); | 267 | station->tid[j].agg.rate_n_flags); |
268 | #endif | ||
269 | pos += scnprintf(buf + pos, bufsz - pos, "\n"); | ||
264 | } | 270 | } |
265 | pos += scnprintf(buf + pos, bufsz - pos, "\n"); | 271 | pos += scnprintf(buf + pos, bufsz - pos, "\n"); |
266 | } | 272 | } |