diff options
author | Joe Perches <joe@perches.com> | 2014-08-08 17:24:42 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-08 18:57:29 -0400 |
commit | 504e3b4f5a210057419fe7a2ea3a0b5b3bc15aa1 (patch) | |
tree | c91052cf1b5e3929cab3423ecd0031dbf3bd192a /drivers/net | |
parent | e6443b24c74110309790a2bb3f5566c9fb5eac66 (diff) |
rtl818x: use pci_zalloc_consistent
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/wireless/rtl818x/rtl8180/dev.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/net/wireless/rtl818x/rtl8180/dev.c b/drivers/net/wireless/rtl818x/rtl8180/dev.c index 4b904f708184..fcc45e5bf50a 100644 --- a/drivers/net/wireless/rtl818x/rtl8180/dev.c +++ b/drivers/net/wireless/rtl818x/rtl8180/dev.c | |||
@@ -972,16 +972,13 @@ static int rtl8180_init_rx_ring(struct ieee80211_hw *dev) | |||
972 | else | 972 | else |
973 | priv->rx_ring_sz = sizeof(struct rtl8180_rx_desc); | 973 | priv->rx_ring_sz = sizeof(struct rtl8180_rx_desc); |
974 | 974 | ||
975 | priv->rx_ring = pci_alloc_consistent(priv->pdev, | 975 | priv->rx_ring = pci_zalloc_consistent(priv->pdev, priv->rx_ring_sz * 32, |
976 | priv->rx_ring_sz * 32, | 976 | &priv->rx_ring_dma); |
977 | &priv->rx_ring_dma); | ||
978 | |||
979 | if (!priv->rx_ring || (unsigned long)priv->rx_ring & 0xFF) { | 977 | if (!priv->rx_ring || (unsigned long)priv->rx_ring & 0xFF) { |
980 | wiphy_err(dev->wiphy, "Cannot allocate RX ring\n"); | 978 | wiphy_err(dev->wiphy, "Cannot allocate RX ring\n"); |
981 | return -ENOMEM; | 979 | return -ENOMEM; |
982 | } | 980 | } |
983 | 981 | ||
984 | memset(priv->rx_ring, 0, priv->rx_ring_sz * 32); | ||
985 | priv->rx_idx = 0; | 982 | priv->rx_idx = 0; |
986 | 983 | ||
987 | for (i = 0; i < 32; i++) { | 984 | for (i = 0; i < 32; i++) { |
@@ -1040,14 +1037,14 @@ static int rtl8180_init_tx_ring(struct ieee80211_hw *dev, | |||
1040 | dma_addr_t dma; | 1037 | dma_addr_t dma; |
1041 | int i; | 1038 | int i; |
1042 | 1039 | ||
1043 | ring = pci_alloc_consistent(priv->pdev, sizeof(*ring) * entries, &dma); | 1040 | ring = pci_zalloc_consistent(priv->pdev, sizeof(*ring) * entries, |
1041 | &dma); | ||
1044 | if (!ring || (unsigned long)ring & 0xFF) { | 1042 | if (!ring || (unsigned long)ring & 0xFF) { |
1045 | wiphy_err(dev->wiphy, "Cannot allocate TX ring (prio = %d)\n", | 1043 | wiphy_err(dev->wiphy, "Cannot allocate TX ring (prio = %d)\n", |
1046 | prio); | 1044 | prio); |
1047 | return -ENOMEM; | 1045 | return -ENOMEM; |
1048 | } | 1046 | } |
1049 | 1047 | ||
1050 | memset(ring, 0, sizeof(*ring)*entries); | ||
1051 | priv->tx_ring[prio].desc = ring; | 1048 | priv->tx_ring[prio].desc = ring; |
1052 | priv->tx_ring[prio].dma = dma; | 1049 | priv->tx_ring[prio].dma = dma; |
1053 | priv->tx_ring[prio].idx = 0; | 1050 | priv->tx_ring[prio].idx = 0; |