diff options
author | Marc Pignat <marc.pignat@hevs.ch> | 2007-10-15 02:51:52 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2007-10-18 15:46:52 -0400 |
commit | e0579d576cb894a4cf3c5af04fbf38e8c1281738 (patch) | |
tree | 63a4a1d5d9c2a473f8f70d5c0075c3ddd9fd7c4f /drivers/net | |
parent | 208eec88639a61002bb140dc5c64984684c2705d (diff) |
[PATCH] zd1211rw, fix oops when ejecting install media
The disconnect function can dereference the net_device structure when it
is never allocated. This is the case when ejecting the device installer.
Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
Acked-by: Daniel Drake <dsd@gentoo.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/wireless/zd1211rw/zd_usb.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/wireless/zd1211rw/zd_usb.c b/drivers/net/wireless/zd1211rw/zd_usb.c index b0684f965761..c755b6923812 100644 --- a/drivers/net/wireless/zd1211rw/zd_usb.c +++ b/drivers/net/wireless/zd1211rw/zd_usb.c | |||
@@ -1044,14 +1044,17 @@ error: | |||
1044 | static void disconnect(struct usb_interface *intf) | 1044 | static void disconnect(struct usb_interface *intf) |
1045 | { | 1045 | { |
1046 | struct net_device *netdev = zd_intf_to_netdev(intf); | 1046 | struct net_device *netdev = zd_intf_to_netdev(intf); |
1047 | struct zd_mac *mac = zd_netdev_mac(netdev); | 1047 | struct zd_mac *mac; |
1048 | struct zd_usb *usb = &mac->chip.usb; | 1048 | struct zd_usb *usb; |
1049 | 1049 | ||
1050 | /* Either something really bad happened, or we're just dealing with | 1050 | /* Either something really bad happened, or we're just dealing with |
1051 | * a DEVICE_INSTALLER. */ | 1051 | * a DEVICE_INSTALLER. */ |
1052 | if (netdev == NULL) | 1052 | if (netdev == NULL) |
1053 | return; | 1053 | return; |
1054 | 1054 | ||
1055 | mac = zd_netdev_mac(netdev); | ||
1056 | usb = &mac->chip.usb; | ||
1057 | |||
1055 | dev_dbg_f(zd_usb_dev(usb), "\n"); | 1058 | dev_dbg_f(zd_usb_dev(usb), "\n"); |
1056 | 1059 | ||
1057 | zd_netdev_disconnect(netdev); | 1060 | zd_netdev_disconnect(netdev); |