diff options
author | David S. Miller <davem@davemloft.net> | 2008-07-21 11:34:49 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-07-21 11:34:49 -0400 |
commit | fd24c4af6e82231391fa09875ae6378fa1399f0f (patch) | |
tree | 0fddd1b5b1fe7e13013e61e0e050d2751b8f1168 /drivers/net | |
parent | ebbdbd7c02f4f8dea84e2956aa942bd18e1ddf93 (diff) |
sunhme: Remove stop/wake TX queue calls in set-multicast-list handler.
Based upon a bug report by Alexander Beregalov and commentary
from Ben Hutchings.
These are totally unnecessary, in particular because this
driver's ->hard_start_xmit() handler takes the same driver
spinlock that the set-multicast-list handler uses.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/sunhme.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c index 1aa425be3067..b79d5f018f79 100644 --- a/drivers/net/sunhme.c +++ b/drivers/net/sunhme.c | |||
@@ -2377,8 +2377,6 @@ static void happy_meal_set_multicast(struct net_device *dev) | |||
2377 | 2377 | ||
2378 | spin_lock_irq(&hp->happy_lock); | 2378 | spin_lock_irq(&hp->happy_lock); |
2379 | 2379 | ||
2380 | netif_stop_queue(dev); | ||
2381 | |||
2382 | if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) { | 2380 | if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) { |
2383 | hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff); | 2381 | hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff); |
2384 | hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff); | 2382 | hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff); |
@@ -2410,8 +2408,6 @@ static void happy_meal_set_multicast(struct net_device *dev) | |||
2410 | hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]); | 2408 | hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]); |
2411 | } | 2409 | } |
2412 | 2410 | ||
2413 | netif_wake_queue(dev); | ||
2414 | |||
2415 | spin_unlock_irq(&hp->happy_lock); | 2411 | spin_unlock_irq(&hp->happy_lock); |
2416 | } | 2412 | } |
2417 | 2413 | ||