diff options
author | Olof Johansson <olof@lixom.net> | 2008-03-25 10:58:40 -0400 |
---|---|---|
committer | Olof Johansson <olof@lixom.net> | 2008-04-07 10:16:24 -0400 |
commit | 1724ac2ef1caf5b4f764d4b86a85d552a7d7c8fb (patch) | |
tree | be14970df3d1ee5fd96b999d7cb383862856be13 /drivers/net | |
parent | a8f75ea70c58546205fb7673be41455b9da5d9a7 (diff) |
pasemi_mac: Jumbo frame bugfixes
Fix a couple of corner cases around interface up/down when jumbo frames are
configured. Resources weren't always freed and reallocated properly.
Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/pasemi_mac.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index c50f0f4de6d8..abb1dc4592f7 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi_mac.c | |||
@@ -404,6 +404,7 @@ static void pasemi_mac_free_csring(struct pasemi_mac_csring *csring) | |||
404 | pasemi_dma_free_flag(csring->events[1]); | 404 | pasemi_dma_free_flag(csring->events[1]); |
405 | pasemi_dma_free_ring(&csring->chan); | 405 | pasemi_dma_free_ring(&csring->chan); |
406 | pasemi_dma_free_chan(&csring->chan); | 406 | pasemi_dma_free_chan(&csring->chan); |
407 | pasemi_dma_free_fun(csring->fun); | ||
407 | } | 408 | } |
408 | 409 | ||
409 | static int pasemi_mac_setup_rx_resources(const struct net_device *dev) | 410 | static int pasemi_mac_setup_rx_resources(const struct net_device *dev) |
@@ -1150,7 +1151,10 @@ static int pasemi_mac_open(struct net_device *dev) | |||
1150 | if (!mac->tx) | 1151 | if (!mac->tx) |
1151 | goto out_tx_ring; | 1152 | goto out_tx_ring; |
1152 | 1153 | ||
1153 | if (dev->mtu > 1500) { | 1154 | /* We might already have allocated rings in case mtu was changed |
1155 | * before interface was brought up. | ||
1156 | */ | ||
1157 | if (dev->mtu > 1500 && !mac->num_cs) { | ||
1154 | pasemi_mac_setup_csrings(mac); | 1158 | pasemi_mac_setup_csrings(mac); |
1155 | if (!mac->num_cs) | 1159 | if (!mac->num_cs) |
1156 | goto out_tx_ring; | 1160 | goto out_tx_ring; |
@@ -1388,8 +1392,12 @@ static int pasemi_mac_close(struct net_device *dev) | |||
1388 | free_irq(mac->tx->chan.irq, mac->tx); | 1392 | free_irq(mac->tx->chan.irq, mac->tx); |
1389 | free_irq(mac->rx->chan.irq, mac->rx); | 1393 | free_irq(mac->rx->chan.irq, mac->rx); |
1390 | 1394 | ||
1391 | for (i = 0; i < mac->num_cs; i++) | 1395 | for (i = 0; i < mac->num_cs; i++) { |
1392 | pasemi_mac_free_csring(mac->cs[i]); | 1396 | pasemi_mac_free_csring(mac->cs[i]); |
1397 | mac->cs[i] = NULL; | ||
1398 | } | ||
1399 | |||
1400 | mac->num_cs = 0; | ||
1393 | 1401 | ||
1394 | /* Free resources */ | 1402 | /* Free resources */ |
1395 | pasemi_mac_free_rx_resources(mac); | 1403 | pasemi_mac_free_rx_resources(mac); |